From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] USB mxs-phy: Register phy with framework
Date: Fri, 1 Feb 2013 09:16:51 +0800 [thread overview]
Message-ID: <20130201011650.GG14629@nchen-desktop> (raw)
In-Reply-To: <1359631937-26646-2-git-send-email-s.hauer@pengutronix.de>
On Thu, Jan 31, 2013 at 12:32:16PM +0100, Sascha Hauer wrote:
> We now have usb_add_phy_dev(), so use it to register with the framework
> to be able to find the phy from the USB driver.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/usb/otg/mxs-phy.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c
> index 5158332..5b39885 100644
> --- a/drivers/usb/otg/mxs-phy.c
> +++ b/drivers/usb/otg/mxs-phy.c
> @@ -127,6 +127,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
> void __iomem *base;
> struct clk *clk;
> struct mxs_phy *mxs_phy;
> + int ret;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!res) {
> @@ -166,11 +167,19 @@ static int mxs_phy_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, &mxs_phy->phy);
>
> + ret = usb_add_phy_dev(&mxs_phy->phy);
> + if (ret)
> + return ret;
> +
> return 0;
> }
>
> static int mxs_phy_remove(struct platform_device *pdev)
> {
> + struct mxs_phy *mxs_phy = platform_get_drvdata(pdev);
> +
> + usb_remove_phy(&mxs_phy->phy);
> +
> platform_set_drvdata(pdev, NULL);
>
> return 0;
Reviewed-by: Peter Chen <peter.chen@freescale.com>
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2013-02-01 1:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 11:32 [PATCH] USB chipidea i.MX: use framework phy handling Sascha Hauer
2013-01-31 11:32 ` [PATCH 1/2] USB mxs-phy: Register phy with framework Sascha Hauer
2013-01-31 14:14 ` kishon
2013-02-01 1:16 ` Peter Chen [this message]
2013-02-14 10:37 ` Felipe Balbi
2013-02-14 16:23 ` Sascha Hauer
2013-02-14 18:00 ` Felipe Balbi
2013-02-14 18:43 ` Sascha Hauer
2013-02-27 8:10 ` Felipe Balbi
2013-02-27 9:22 ` Marc Kleine-Budde
2013-01-31 11:32 ` [PATCH 2/2] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy Sascha Hauer
2013-01-31 14:13 ` kishon
2013-02-01 1:16 ` Peter Chen
2013-02-01 7:36 ` [PATCH] USB chipidea i.MX: use framework phy handling Sascha Hauer
2013-02-01 12:38 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201011650.GG14629@nchen-desktop \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox