From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 for soc 3/4] arm: Add v7_invalidate_l1 to cache-v7.S
Date: Fri, 1 Feb 2013 12:54:17 +0000 [thread overview]
Message-ID: <20130201125417.GL23505@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130201121137.GC23869@e102568-lin.cambridge.arm.com>
On Fri, Feb 01, 2013 at 12:11:38PM +0000, Lorenzo Pieralisi wrote:
> Well, on latest processors (A15, A7) caches are invalidated on reset unless
> the chip is programmed to skip that on reset (ie L2 retained).
>
> But it makes sense, for sure it should not be called v7_invalidate_l1,
> but invalidate_louis, and instead of forcing level 0 we should be
> reading LoUIS and invalidate up to that level as we do in the clean and
> invalidate function.
No. Think about it. c7, c6, 2 _invalidates_ the cache. That means any
data contained within the cache is discarded. Data is not written back.
If you do this down to the LoUIS, that includes all cache levels in the
inner sharable domain. The inner sharable domain includes the other CPUs
in the system which may already be running (certainly the boot CPU will
be running).
Are you _really_ sure you want to be invalidating _valid_ data held in
caches in the inner sharable domain by other CPUs, rather than just the
cache associated with the CPU which is being brought online?
next prev parent reply other threads:[~2013-02-01 12:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 17:05 [PATCHv2 for soc 0/4] Enabling socfpga on hardware dinguyen at altera.com
2013-01-31 17:05 ` [PATCHv2 for soc 1/4] arm: socfpga: Add new device tree source for actual socfpga HW dinguyen at altera.com
2013-02-01 3:46 ` Olof Johansson
2013-02-01 15:23 ` Dinh Nguyen
2013-01-31 17:05 ` [PATCHv2 for soc 2/4] arm: socfpga: Add entries to enable make dtbs socfpga dinguyen at altera.com
2013-01-31 17:05 ` [PATCHv2 for soc 3/4] arm: Add v7_invalidate_l1 to cache-v7.S dinguyen at altera.com
2013-01-31 18:11 ` Stephen Warren
2013-02-01 3:47 ` Olof Johansson
2013-02-01 11:29 ` Santosh Shilimkar
2013-02-01 11:32 ` Russell King - ARM Linux
2013-02-01 11:44 ` Santosh Shilimkar
2013-02-01 12:48 ` Russell King - ARM Linux
2013-02-01 13:04 ` Santosh Shilimkar
2013-02-01 13:20 ` Russell King - ARM Linux
2013-02-01 14:09 ` Santosh Shilimkar
2013-02-01 12:11 ` Lorenzo Pieralisi
2013-02-01 12:24 ` Santosh Shilimkar
2013-02-01 12:54 ` Russell King - ARM Linux [this message]
2013-02-01 14:10 ` Lorenzo Pieralisi
2013-02-01 14:19 ` Russell King - ARM Linux
2013-02-01 14:31 ` Russell King - ARM Linux
2013-02-01 14:43 ` Santosh Shilimkar
2013-02-01 14:49 ` Russell King - ARM Linux
2013-02-01 14:53 ` Santosh Shilimkar
2013-02-01 14:34 ` Lorenzo Pieralisi
2013-01-31 17:05 ` [PATCHv2 for soc 4/4] arm: socfpga: Add SMP support for actual socfpga harware dinguyen at altera.com
2013-02-01 3:50 ` Olof Johansson
2013-02-01 10:46 ` Pavel Machek
2013-02-01 15:27 ` Dinh Nguyen
2013-02-01 15:31 ` Russell King - ARM Linux
2013-02-01 16:39 ` Dinh Nguyen
2013-02-02 19:24 ` Pavel Machek
2013-02-02 21:37 ` Dinh Nguyen
2013-02-03 18:36 ` Pavel Machek
2013-02-04 16:12 ` Dinh Nguyen
2013-02-01 10:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201125417.GL23505@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).