public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: dpll: Add missing soc_is_am33xx() check
Date: Fri, 01 Feb 2013 09:54:27 -0800	[thread overview]
Message-ID: <20130201175427.16898.39901@quantum> (raw)
In-Reply-To: <1359714424-21167-1-git-send-email-anilkumar@ti.com>

Quoting AnilKumar Ch (2013-02-01 02:27:04)
> Add missing soc_is_am33xx() check in noncore DPLL set rate function.
> Without this, dpll set_rate function throughs warnings for am33xx
> family of devices.
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>

I think that only 3430 needs the freqsel calculation.  If this is true,
then I think it would be better to just have a check for cpu_is_3430()
instead of appending new SoCs to the list that do not care about the
freqsel calculation.

Regards,
Mike

> ---
>  arch/arm/mach-omap2/dpll3xxx.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
> index 0a02aab5..4bb3f78 100644
> --- a/arch/arm/mach-omap2/dpll3xxx.c
> +++ b/arch/arm/mach-omap2/dpll3xxx.c
> @@ -501,7 +501,8 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
>                         return -EINVAL;
>  
>                 /* No freqsel on OMAP4 and OMAP3630 */
> -               if (!cpu_is_omap44xx() && !cpu_is_omap3630()) {
> +               if (!cpu_is_omap44xx() && !cpu_is_omap3630() &&
> +                                       !soc_is_am33xx()) {
>                         freqsel = _omap3_dpll_compute_freqsel(clk,
>                                                 dd->last_rounded_n);
>                         WARN_ON(!freqsel);
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2013-02-01 17:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 10:27 [PATCH] ARM: OMAP2+: dpll: Add missing soc_is_am33xx() check AnilKumar Ch
2013-02-01 17:54 ` Mike Turquette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130201175427.16898.39901@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox