* [PATCH] ARM: OMAP2+: dpll: Add missing soc_is_am33xx() check
@ 2013-02-01 10:27 AnilKumar Ch
2013-02-01 17:54 ` Mike Turquette
0 siblings, 1 reply; 2+ messages in thread
From: AnilKumar Ch @ 2013-02-01 10:27 UTC (permalink / raw)
To: linux-arm-kernel
Add missing soc_is_am33xx() check in noncore DPLL set rate function.
Without this, dpll set_rate function throughs warnings for am33xx
family of devices.
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
arch/arm/mach-omap2/dpll3xxx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
index 0a02aab5..4bb3f78 100644
--- a/arch/arm/mach-omap2/dpll3xxx.c
+++ b/arch/arm/mach-omap2/dpll3xxx.c
@@ -501,7 +501,8 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
return -EINVAL;
/* No freqsel on OMAP4 and OMAP3630 */
- if (!cpu_is_omap44xx() && !cpu_is_omap3630()) {
+ if (!cpu_is_omap44xx() && !cpu_is_omap3630() &&
+ !soc_is_am33xx()) {
freqsel = _omap3_dpll_compute_freqsel(clk,
dd->last_rounded_n);
WARN_ON(!freqsel);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: OMAP2+: dpll: Add missing soc_is_am33xx() check
2013-02-01 10:27 [PATCH] ARM: OMAP2+: dpll: Add missing soc_is_am33xx() check AnilKumar Ch
@ 2013-02-01 17:54 ` Mike Turquette
0 siblings, 0 replies; 2+ messages in thread
From: Mike Turquette @ 2013-02-01 17:54 UTC (permalink / raw)
To: linux-arm-kernel
Quoting AnilKumar Ch (2013-02-01 02:27:04)
> Add missing soc_is_am33xx() check in noncore DPLL set rate function.
> Without this, dpll set_rate function throughs warnings for am33xx
> family of devices.
>
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
I think that only 3430 needs the freqsel calculation. If this is true,
then I think it would be better to just have a check for cpu_is_3430()
instead of appending new SoCs to the list that do not care about the
freqsel calculation.
Regards,
Mike
> ---
> arch/arm/mach-omap2/dpll3xxx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
> index 0a02aab5..4bb3f78 100644
> --- a/arch/arm/mach-omap2/dpll3xxx.c
> +++ b/arch/arm/mach-omap2/dpll3xxx.c
> @@ -501,7 +501,8 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
> return -EINVAL;
>
> /* No freqsel on OMAP4 and OMAP3630 */
> - if (!cpu_is_omap44xx() && !cpu_is_omap3630()) {
> + if (!cpu_is_omap44xx() && !cpu_is_omap3630() &&
> + !soc_is_am33xx()) {
> freqsel = _omap3_dpll_compute_freqsel(clk,
> dd->last_rounded_n);
> WARN_ON(!freqsel);
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-01 17:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-01 10:27 [PATCH] ARM: OMAP2+: dpll: Add missing soc_is_am33xx() check AnilKumar Ch
2013-02-01 17:54 ` Mike Turquette
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).