public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: gmbnomis@gmail.com (Simon Baatz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] rtc: rtc-mv: Add support for clk to avoid lockups
Date: Sun, 3 Feb 2013 20:44:07 +0100	[thread overview]
Message-ID: <20130203194407.GA16366@schnuecks.de> (raw)
In-Reply-To: <1359891126-21909-1-git-send-email-andrew@lunn.ch>

Hi Andrew,

On Sun, Feb 03, 2013 at 12:32:06PM +0100, Andrew Lunn wrote:
> The Marvell RTC on Kirkwood makes use of the runit clock. Ensure the
> driver clk_prepare_enable() this clock, otherwise there is a danger
> the SoC will lockup when accessing RTC registers with the clock
> disabled.
> 
> Reported-by: Simon Baatz gmbnomis at gmail.com
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

And:

Tested-by: Simon Baatz <gmbnomis@gmail.com>

Btw, <...> is missing from the email address in the Reported-by line.

Thanks for providing this so quickly. Now, it looks like this
(without applying the GPIO fix, yet, because it would already enable
the runit clock):

# cat /sys/kernel/debug/clk/tclk/runit/clk_enable_count
0
# insmod ./rtc-mv.ko
# cat /sys/kernel/debug/clk/tclk/runit/clk_enable_count
1
# hwclock
Sun Feb  3 19:34:53 2013  -1.003522 seconds
# rmmod rtc-mv
# cat /sys/kernel/debug/clk/tclk/runit/clk_enable_count
0


- Simon

  reply	other threads:[~2013-02-03 19:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-03 11:32 [PATCH v2] rtc: rtc-mv: Add support for clk to avoid lockups Andrew Lunn
2013-02-03 19:44 ` Simon Baatz [this message]
2013-02-03 22:14   ` Jason Cooper
2013-02-04  1:50 ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130203194407.GA16366@schnuecks.de \
    --to=gmbnomis@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox