From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 01/12] gpio: add gpio offset in gpio range cells property
Date: Mon, 4 Feb 2013 16:23:38 -0800 [thread overview]
Message-ID: <20130205002338.GA25185@atomide.com> (raw)
In-Reply-To: <1359825953-15663-2-git-send-email-haojian.zhuang@linaro.org>
* Haojian Zhuang <haojian.zhuang@linaro.org> [130202 09:29]:
> Add gpio offset into "gpio-range-cells" property. It's used to support
> sparse pinctrl range in gpio chip.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> ---
> Documentation/devicetree/bindings/gpio/gpio.txt | 6 +++---
> arch/arm/boot/dts/spear1310.dtsi | 4 ++--
> arch/arm/boot/dts/spear1340.dtsi | 4 ++--
> arch/arm/boot/dts/spear310.dtsi | 4 ++--
> arch/arm/boot/dts/spear320.dtsi | 4 ++--
> drivers/gpio/gpiolib-of.c | 15 ++-------------
> 6 files changed, 13 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt
> index a336287..d933af3 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio.txt
> @@ -98,7 +98,7 @@ announce the pinrange to the pin ctrl subsystem. For example,
> compatible = "fsl,qe-pario-bank-e", "fsl,qe-pario-bank";
> reg = <0x1460 0x18>;
> gpio-controller;
> - gpio-ranges = <&pinctrl1 20 10>, <&pinctrl2 50 20>;
> + gpio-ranges = <&pinctrl1 0 20 10>, <&pinctrl2 10 50 20>;
>
> }
>
> @@ -107,8 +107,8 @@ where,
>
> Next values specify the base pin and number of pins for the range
> handled by 'qe_pio_e' gpio. In the given example from base pin 20 to
> - pin 29 under pinctrl1 and pin 50 to pin 69 under pinctrl2 is handled
> - by this gpio controller.
> + pin 29 under pinctrl1 with gpio offset 0 and pin 50 to pin 69 under
> + pinctrl2 with gpio offset 10 is handled by this gpio controller.
>
> The pinctrl node must have "#gpio-range-cells" property to show number of
> arguments to pass with phandle from gpio controllers node.
> diff --git a/arch/arm/boot/dts/spear1310.dtsi b/arch/arm/boot/dts/spear1310.dtsi
> index 1513c19..122ae94 100644
> --- a/arch/arm/boot/dts/spear1310.dtsi
> +++ b/arch/arm/boot/dts/spear1310.dtsi
> @@ -89,7 +89,7 @@
> pinmux: pinmux at e0700000 {
> compatible = "st,spear1310-pinmux";
> reg = <0xe0700000 0x1000>;
> - #gpio-range-cells = <2>;
> + #gpio-range-cells = <3>;
> };
>
> apb {
Hmm is this safe to do if there are bootloaders using the old binding?
Maybe we should support both #gpio-range-cells = <2> and <3> bindings
instead?
Regards,
Tony
next prev parent reply other threads:[~2013-02-05 0:23 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 17:25 [PATCH v8 00/12] support pinconf in pinctrl single Haojian Zhuang
2013-02-02 17:25 ` [PATCH v8 01/12] gpio: add gpio offset in gpio range cells property Haojian Zhuang
2013-02-05 0:23 ` Tony Lindgren [this message]
2013-02-05 1:06 ` Haojian Zhuang
2013-02-10 19:03 ` Linus Walleij
2013-02-11 4:25 ` Viresh Kumar
2013-04-29 16:00 ` [v8,01/12] " James Hogan
2013-04-29 16:49 ` Haojian Zhuang
2013-04-29 20:16 ` James Hogan
2013-02-02 17:25 ` [PATCH v8 02/12] gpio: fix wrong checking condition for gpio range Haojian Zhuang
2013-02-05 17:02 ` Linus Walleij
2013-02-02 17:25 ` [PATCH v8 03/12] gpio: find gpio base by ascend order Haojian Zhuang
2013-02-05 17:14 ` Linus Walleij
2013-02-06 1:59 ` Haojian Zhuang
2013-02-06 4:33 ` Alex Courbot
2013-02-06 5:20 ` Haojian Zhuang
2013-02-06 8:44 ` Linus Walleij
2013-02-06 9:15 ` Haojian Zhuang
2013-02-02 17:25 ` [PATCH v8 04/12] gpio: pl061: allocate irq dynamically Haojian Zhuang
2013-02-02 17:25 ` [PATCH v8 05/12] pinctrl: verify whether gpio chip overlapps range Haojian Zhuang
2013-02-02 17:25 ` [PATCH v8 06/12] gpio: pl061: bind pinctrl by gpio request Haojian Zhuang
2013-02-02 17:25 ` [PATCH v8 07/12] pinctrl: single: create new gpio function range Haojian Zhuang
2013-02-02 17:25 ` [PATCH v8 08/12] pinctrl: generic: dump pin configuration Haojian Zhuang
2013-02-05 0:35 ` Tony Lindgren
2013-02-05 0:57 ` Tony Lindgren
2013-02-05 1:09 ` Haojian Zhuang
2013-02-05 1:08 ` Haojian Zhuang
2013-02-02 17:25 ` [PATCH v8 09/12] pinctrl: single: set function mask as optional Haojian Zhuang
2013-02-02 17:25 ` [PATCH v8 10/12] pinctrl: single: support generic pinconf Haojian Zhuang
2013-02-05 0:46 ` Tony Lindgren
2013-02-05 1:07 ` Haojian Zhuang
2013-02-02 17:25 ` [PATCH v8 11/12] ARM: hs: enable hi4511 with device tree Haojian Zhuang
2013-02-02 17:25 ` [PATCH v8 12/12] document: devicetree: bind pinconf with pin single Haojian Zhuang
2013-02-05 4:07 ` Tony Lindgren
2013-02-05 8:06 ` Haojian Zhuang
2013-02-05 13:51 ` Haojian Zhuang
2013-02-05 23:30 ` Tony Lindgren
2013-02-06 15:07 ` Haojian Zhuang
2013-02-06 17:16 ` Tony Lindgren
2013-02-05 23:21 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2013-02-11 17:10 [PATCH v8 00/12] bind pinconf with pinctrl single Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 01/12] gpio: add gpio offset in gpio range cells property Haojian Zhuang
2013-02-13 13:33 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205002338.GA25185@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).