public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type
Date: Tue, 5 Feb 2013 13:54:57 +0800	[thread overview]
Message-ID: <20130205055456.GA6234@nchen-desktop> (raw)
In-Reply-To: <1359984275-24646-1-git-send-email-s.hauer@pengutronix.de>

On Mon, Feb 04, 2013 at 02:24:26PM +0100, Sascha Hauer wrote:
> 4th round of patches.
> 
> Peter, I would be glad if you could test them before your holiday. I rebased
> your last round of Chipidea OTG patches onto this series which you can pull
> here:
> 
> git://git.pengutronix.de/git/imx/linux-2.6.git tags/usb-chipidea-otg-for-next
> 
> I couldn't really test the otg patches since my current hardware does not have
> the ID pin connected, but I can verify that my usecase still works with your
> patches applied.

Sascha, I have tested your patchset, it works after adding a few of changes
at my otg patchset (we still need to read otgsc for gadget-only function).
I use my mx6q sabrelite board to test.

I have tested all roles with below diff:
diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts
index 49527d7..cdbf2ec 100644
--- a/arch/arm/boot/dts/imx6q-sabrelite.dts
+++ b/arch/arm/boot/dts/imx6q-sabrelite.dts
@@ -72,6 +72,10 @@
 				pinctrl-0 = <&pinctrl_usbotg_1>;
 				disable-over-current;
 				otg_id_pin_select_change;
+				/* dr_mode = "peripheral"; */
+				/* dr_mode = "host"; */
+				dr_mode = "otg";
+				phy_type = "utmi_wide";
 				status = "okay";
 			};

So, feel free to add my Tested-by: Peter Chen <peter.chen@freescale.com>

Besides, if you have a mx51 bbg board, you can test id-switch function.
For mx5x, you may need a phy driver.

My git: https://github.com/hzpeterchen/linux-usb.git master

It is based on your tag, and add latest otg patch.
Besides, it has Michael Grzeschik/Marc Kleine-Budde
usb misc patch as well as my platform changes for mx6q board.

> 
> Alex, should the patches work for you and are fine otherwise, could you apply
> them for v3.9?
> 
> Sascha
> 
> 
-- 

Best Regards,
Peter Chen

  parent reply	other threads:[~2013-02-05  5:54 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04 13:24 [PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type Sascha Hauer
2013-02-04 13:24 ` [PATCH 1/9] usb: otg: use try_module_get in all usb_get_phy functions and add missing module_put Sascha Hauer
2013-02-04 13:59   ` Roger Quadros
2013-02-04 14:10     ` Marc Kleine-Budde
2013-02-04 14:39       ` Roger Quadros
2013-02-04 13:24 ` [PATCH 2/9] USB: move bulk of otg/otg.c to phy/phy.c Sascha Hauer
2013-02-19  9:30   ` Felipe Balbi
2013-02-19 19:06     ` Sascha Hauer
2013-02-19 19:48       ` Felipe Balbi
2013-02-04 13:24 ` [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type Sascha Hauer
2013-02-14  9:36   ` Alexander Shishkin
2013-02-14  9:49     ` Marc Kleine-Budde
2013-02-14  9:58       ` Felipe Balbi
2013-02-14 10:07         ` Sascha Hauer
2013-02-14 10:15           ` Felipe Balbi
2013-02-14 11:24             ` Sascha Hauer
2013-02-14 13:10               ` Felipe Balbi
2013-02-14 16:06                 ` Sascha Hauer
2013-02-14 18:04                   ` Felipe Balbi
2013-02-14 18:30                     ` Sascha Hauer
2013-02-14 19:36                       ` Felipe Balbi
2013-02-15 10:54                         ` Sascha Hauer
2013-02-17  9:00                           ` Peter Chen
2013-02-14 10:11         ` Marc Kleine-Budde
2013-02-14 10:16           ` Felipe Balbi
2013-03-13  9:43   ` Peter Chen
2013-02-04 13:24 ` [PATCH 4/9] USB: chipidea: ci13xxx-imx: create dynamic platformdata Sascha Hauer
2013-02-04 13:24 ` [PATCH 5/9] USB: chipidea: add PTW and PTS handling Sascha Hauer
2013-02-14 13:07   ` Alexander Shishkin
2013-02-27 10:23     ` Marc Kleine-Budde
2013-02-04 13:24 ` [PATCH 6/9] USB chipidea: introduce dual role mode pdata flags Sascha Hauer
2013-02-22  2:09   ` Peter Chen
2013-02-27 10:42     ` Marc Kleine-Budde
2013-02-04 13:24 ` [PATCH 7/9] USB chipidea i.MX: introduce dr_mode property Sascha Hauer
2013-02-04 13:24 ` [PATCH 8/9] USB mxs-phy: Register phy with framework Sascha Hauer
2013-02-04 13:24 ` [PATCH 9/9] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy Sascha Hauer
2013-02-05 11:45   ` Sergei Shtylyov
2013-02-05 11:58     ` Sascha Hauer
2013-02-05  5:54 ` Peter Chen [this message]
2013-02-07 10:56 ` [PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type Sascha Hauer
2013-02-12 13:59   ` Sascha Hauer
2013-02-14 13:22 ` Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130205055456.GA6234@nchen-desktop \
    --to=peter.chen@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox