linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM i.MX25: clk: parent per5_clk to AHB clock
Date: Tue, 5 Feb 2013 10:45:53 +0100	[thread overview]
Message-ID: <20130205094553.GY1906@pengutronix.de> (raw)
In-Reply-To: <1359551760-28862-1-git-send-email-s.trumtrar@pengutronix.de>

On Wed, Jan 30, 2013 at 02:16:00PM +0100, Steffen Trumtrar wrote:
> The mxc-timer on the imx25 needs to be derived from the AHB clock.
> If a bootloader reparents this clock to the ipg_clk_highfreq, which according
> to the datasheet is a valid operation, the system can/will produce lockups/
> freezes after some time [1].
> 
> This can be forced with code like
> 	while(1)
>                 syscall(SYS_clock_gettime, CLOCK_REALTIME, &tp);
> 
> This was already fixed with the commit
> 	"i.MX25 GPT clock fix: ensure correct the clock source" [2],
> for 3.1-rc2, but was lost, when i.MX was converted to the common clock framework
> ("ARM i.MX25: implement clocks using common clock framework") [3]
> 
> [1]: http://lists.arm.linux.org.uk/lurker/message/20130129.161230.229bda17.en.html
> [2]: 2012d9ca2a1381ae3e733330a7f0d1d2f1988bba
> [3]: 6bbaec5676e4f475b0d78743cbd4c70a8804ce14
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Cc: stable at vger.kernel.org # v3.5+

Applied, thanks

Sascha

> ---
>  arch/arm/mach-imx/clk-imx25.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/clk-imx25.c b/arch/arm/mach-imx/clk-imx25.c
> index 5d34f67..0e6dde6 100644
> --- a/arch/arm/mach-imx/clk-imx25.c
> +++ b/arch/arm/mach-imx/clk-imx25.c
> @@ -177,6 +177,9 @@ static int __init __mx25_clocks_init(unsigned long osc_rate)
>  			pr_err("i.MX25 clk %d: register failed with %ld\n",
>  				i, PTR_ERR(clk[i]));
>  
> +	/* Clock source for gpt must be derived from AHB */
> +	clk_set_parent(clk[per5_sel], clk[ahb]);
> +
>  	clk_register_clkdev(clk[ipg], "ipg", "imx-gpt.0");
>  	clk_register_clkdev(clk[gpt_ipg_per], "per", "imx-gpt.0");
>  
> -- 
> 1.7.10.4
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      reply	other threads:[~2013-02-05  9:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30 13:16 [PATCH v2] ARM i.MX25: clk: parent per5_clk to AHB clock Steffen Trumtrar
2013-02-05  9:45 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130205094553.GY1906@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).