From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] ARM: OMAP: Audio support via omap-twl4030 and pwm support
Date: Tue, 5 Feb 2013 12:30:55 +0000 [thread overview]
Message-ID: <20130205123055.GA17852@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130204195251.GS22517@atomide.com>
On Mon, Feb 04, 2013 at 11:52:51AM -0800, Tony Lindgren wrote:
> @@ -245,7 +245,7 @@ static int sdp3430_twl_gpio_setup(struct device *dev,
> return 0;
> }
>
> -static struct twl4030_gpio_platform_data sdp3430_gpio_data = {
> +static struct twl4030_gpio_platform_data __initdata sdp3430_gpio_data = {
> .pulldowns = BIT(2) | BIT(6) | BIT(8) | BIT(13)
> | BIT(16) | BIT(17),
> .setup = sdp3430_twl_gpio_setup,
Seeing platform data marked with __initdata makes me extremely nervous.
Are you _absolutely_ _sure_ that this data either:
(a) gets copied before use, or
(b) is not used after kernel init
?
Normally, platform data is passed via a pointer in struct device to
drivers, and drivers either store a pointer to it, or if the driver is
unbound/rebound, they can access it well after init time.
Certainly marking a function pointed to by platform data as __init looks
very very wrong.
next prev parent reply other threads:[~2013-02-05 12:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 10:07 [GIT PULL] ARM: OMAP: Audio support via omap-twl4030 and pwm support Peter Ujfalusi
2013-01-29 8:30 ` Peter Ujfalusi
2013-01-30 22:05 ` Tony Lindgren
2013-02-04 19:52 ` Tony Lindgren
2013-02-05 9:46 ` Peter Ujfalusi
2013-02-05 18:40 ` Tony Lindgren
2013-02-06 7:21 ` Peter Ujfalusi
2013-02-06 16:56 ` Tony Lindgren
2013-02-05 12:30 ` Russell King - ARM Linux [this message]
2013-02-05 18:44 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205123055.GA17852@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).