From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: Export the CPU logical map to modules
Date: Thu, 7 Feb 2013 12:22:53 +0000 [thread overview]
Message-ID: <20130207122253.GA2309@linaro.org> (raw)
In-Reply-To: <1359394444-16610-1-git-send-email-dave.martin@linaro.org>
Hi,
Does anyone have a comment on this?
Cheers
---Dave
On Mon, Jan 28, 2013 at 05:34:04PM +0000, Dave Martin wrote:
> It is reasonable for loadable modules to be CPU topology aware
> (particular examples include cpufreq and cpuidle drivers).
>
> This patch exports __cpu_logical_map, so that modules can use the
> cpu_logical_map() interface declared in <asm/smp_plat.h>.
>
> Signed-off-by: Dave Martin <dave.martin@linaro.org>
> ---
> If anyone has a strong view on whether this should be
> EXPORT_SYMBOL_GPL(), I don't have a problem with changing
> that. I'm not sure of the precise etiquette here.
> Certainly this does not feel like a very "public" interface.
>
> Perhaps we should wrap this in a real function for export
> to modules, rather than encouraging them to poke the
> __cpu_logical_map[] array (albeit via a predefined macro).
>
>
> arch/arm/kernel/setup.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> index 3f6cbb2..1b9e5bf 100644
> --- a/arch/arm/kernel/setup.c
> +++ b/arch/arm/kernel/setup.c
> @@ -428,6 +428,7 @@ void cpu_init(void)
> }
>
> int __cpu_logical_map[NR_CPUS];
> +EXPORT_SYMBOL(__cpu_logical_map);
>
> void __init smp_setup_processor_id(void)
> {
> --
> 1.7.4.1
>
next prev parent reply other threads:[~2013-02-07 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 17:34 [RFC PATCH] ARM: Export the CPU logical map to modules Dave Martin
2013-02-07 12:22 ` Dave Martin [this message]
2013-02-07 20:05 ` Nicolas Pitre
2013-02-08 11:33 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130207122253.GA2309@linaro.org \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).