public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAPDSS: enable omapdss for ARCH_MULTIPLATFORM
Date: Thu, 7 Feb 2013 12:50:39 +0000	[thread overview]
Message-ID: <201302071250.39923.arnd@arndb.de> (raw)
In-Reply-To: <51139E63.2030302@ti.com>

On Thursday 07 February 2013, Tomi Valkeinen wrote:
> > I would suggest only the first patch, since Linus quite specifically
> > asked only for serious bug fixes. I think an allyesconfig build
> > breakage is serious enough, but doing multiple patches for one
> > bug should not be necessary and is much harder to justify.
> 
> Well, as I see, the bug is omapdrm using "select", not "depends on". So
> if I'd have to pick one patch, I'd send 0003. That would fix allyesconfig.
> 
> Applying only 0003 means that omapdrm (and omapdss) won't be built on
> ARCH_MULTIPLATFORM, but building omapdrm on ARCH_MULTIPLATFORM is a
> feature added in this merge window, so leaving it out is not a regression.
> 
> But I'm not sure if I'm being overly pedantic here. Patch 0001 would fix
> allyesconfig, and allow building omapdrm with ARCH_MULTIPLATFORM.
> However, the fixing there happens as a side effect, and so the 0001
> patch isn't even called a "fix" in its subject. That's the reason I'm a
> bit reluctant with the 0001 patch as a fix.

Makes sense. I suggested the same initially, but Rob preferred enabling
DSS on multiplatform as well, since he wants to see broad build coverage
for the DRM part. We should probably do that in 3.9, but for 3.8,
just changing DRM to depend on DSS seems like the least intrusive
choice.

	Arnd

      reply	other threads:[~2013-02-07 12:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22 21:46 [PATCH] OMAPDSS: enable omapdss for ARCH_MULTIPLATFORM Rob Clark
2013-01-22 21:53 ` Arnd Bergmann
2013-02-05 16:31   ` Arnd Bergmann
2013-02-06 14:15     ` Tomi Valkeinen
2013-02-06 14:29       ` Arnd Bergmann
2013-02-07 11:40         ` Tomi Valkeinen
2013-02-07 11:55           ` Arnd Bergmann
2013-02-07 12:30             ` Tomi Valkeinen
2013-02-07 12:50               ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201302071250.39923.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox