From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn()
Date: Sat, 9 Feb 2013 15:05:31 -0300 [thread overview]
Message-ID: <20130209180530.GC32349@localhost> (raw)
In-Reply-To: <20130209165532.GB13338@arwen.pp.htv.fi>
On Sat, Feb 09, 2013 at 06:55:32PM +0200, Felipe Balbi wrote:
> Hi,
>
> On Sat, Feb 09, 2013 at 01:38:16PM -0300, Ezequiel Garcia wrote:
> > Since the condition is not an error but a warning, replace
> > printk KERN_ERR with dev_warn.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > ---
> > arch/arm/mach-omap2/gpmc-onenand.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c
> > index 4771945..fd6e35b 100644
> > --- a/arch/arm/mach-omap2/gpmc-onenand.c
> > +++ b/arch/arm/mach-omap2/gpmc-onenand.c
> > @@ -367,7 +367,7 @@ void gpmc_onenand_init(struct omap_onenand_platform_data *_onenand_data)
> >
> > if (cpu_is_omap24xx() &&
> > (gpmc_onenand_data->flags & ONENAND_SYNC_READWRITE)) {
> > - printk(KERN_ERR "Onenand using only SYNC_READ on 24xx\n");
> > + dev_warn(dev, "OneNAND using only SYNC_READ on 24xx\n");
>
> it would seem more natural to use dev_err() instead.
>
Are you sure? The error seems more a warning to me,
although I guess it's arguable.
Let me know and I'll fix it in v2.
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-02-09 18:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-09 16:38 [PATCH 0/7] ARM: omap2: GPMC cleanup Ezequiel Garcia
2013-02-09 16:38 ` [PATCH 1/7] ARM: omap2: gpmc: Mark local scoped functions static Ezequiel Garcia
2013-02-09 16:38 ` [PATCH 2/7] ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function Ezequiel Garcia
2013-02-09 16:38 ` [PATCH 3/7] ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value Ezequiel Garcia
2013-02-09 16:53 ` Felipe Balbi
2013-02-09 18:14 ` Ezequiel Garcia
2013-02-09 20:56 ` Felipe Balbi
2013-02-09 16:38 ` [PATCH 4/7] ARM: omap2: gpmc-nand: Print something useful on CS request failure Ezequiel Garcia
2013-02-09 16:38 ` [PATCH 5/7] ARM: omap2: gpmc-onenand: " Ezequiel Garcia
2013-02-09 16:38 ` [PATCH 6/7] ARM: omap2: gpmc-onenand: Replace pr_err() with dev_err() Ezequiel Garcia
2013-02-09 16:38 ` [PATCH 7/7] ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn() Ezequiel Garcia
2013-02-09 16:55 ` Felipe Balbi
2013-02-09 18:05 ` Ezequiel Garcia [this message]
2013-02-09 20:58 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130209180530.GC32349@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).