From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: Latest additional build warnings
Date: Mon, 11 Feb 2013 11:05:13 -0800 [thread overview]
Message-ID: <20130211190513.GU4801@atomide.com> (raw)
In-Reply-To: <CAOesGMjQEJesfDqSHoV727=pTHjQ4CE+La2QWikG0r4gZ9iSjA@mail.gmail.com>
* Olof Johansson <olof@lixom.net> [130209 20:25]:
> On Sat, Feb 9, 2013 at 7:22 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Olof Johansson <olof@lixom.net> [130209 19:08]:
> >> On Sat, Feb 9, 2013 at 7:00 PM, Tony Lindgren <tony@atomide.com> wrote:
> >> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [130209 03:53]:
> >> >> On Tue, Feb 05, 2013 at 02:22:18PM +0000, Russell King - ARM Linux wrote:
> >> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class
> >> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall'
> >> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration
> >> >> > arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used
> >> >>
> >> >> I'm still seeing the above in the build of Friday's merge. I'm also
> >> >> seeing additional warnings in the randconfig similar to the above for
> >> >> arch/arm/mach-omap2/omap-iommu.c.
> >> >
> >> > Thanks for letting me know about the omap-iommu.c one. Looks like
> >> > there's also one patch for drm.c.
> >> >
> >> > Olof, if you did not yet apply the hwspinlock.c warning fix, I'll
> >> > just do a branch with all three of them for you.
> >>
> >> I haven't (must have missed it), so please just send a branch.
> >
> > OK will do. Probably you started fixing up the bad Reported-by
> > line in my patch and then got disrupted :)
> >
> > Found one more after some grepping, after the following patch they
> > should be all fixed up. Pull request coming shortly.
>
> Oh wait -- I got confused there for a bit (this came in right as I had
> to step out for a while).
>
> I definitely picked up the hwspinlock patch, and it's there in my
> local for-next. Looks like I missed pushing it out though. That
> explains why Russell didn't see the fix. :(
>
>
> So, the hwspinlock patch is already applied. The soc.h one is not, and
> I'm not sure what the third one is?
Maybe check that you have these in your multiplatform branch:
09cee18dbced86b27c6c7d4501126cf2a287d089 ARM: OMAP2+: Make sure files with omap initcalls include soc.h
b9a30021abeaf9687640c13ef8006346736dc29f ARM: OMAP2+: Include soc.h to drm.c to fix compiling
f3533403b5a8ac970f6159664d145cb88b1aa6bf ARM: OMAP2+: Fix warning for hwspinlock omap_postcore_initcall
You can cherry pick the missing ones from my omap-for-v3.9/multiplatform-fixes
branch.
Regards,
Tony
next prev parent reply other threads:[~2013-02-11 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 14:22 Latest additional build warnings Russell King - ARM Linux
2013-02-05 17:51 ` Tony Lindgren
2013-02-05 22:11 ` Olof Johansson
2013-02-09 11:49 ` Russell King - ARM Linux
2013-02-10 3:00 ` Tony Lindgren
2013-02-10 3:01 ` Olof Johansson
2013-02-10 3:22 ` Tony Lindgren
2013-02-10 3:47 ` Tony Lindgren
2013-02-10 4:22 ` Olof Johansson
2013-02-11 19:05 ` Tony Lindgren [this message]
2013-02-11 19:06 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211190513.GU4801@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).