From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 06/12] pinctrl: single: create new gpio function range
Date: Wed, 13 Feb 2013 10:39:31 -0800 [thread overview]
Message-ID: <20130213183931.GL7144@atomide.com> (raw)
In-Reply-To: <1360602659-4774-7-git-send-email-haojian.zhuang@linaro.org>
* Haojian Zhuang <haojian.zhuang@linaro.org> [130211 09:15]:
> Since gpio driver could create gpio range in DTS, it could invokes
> pinctrl_request_gpio(). In the pinctrl-single driver, it needs to
> configure pins with gpio function mode.
Minor typo above: s/invokes/invoke/
> A new gpio function range should be created in DTS file in below.
>
> pinctrl-single,gpio-range = <phandle pin_offset nr_pins gpio_func>;
>
> range: gpio-range {
> #pinctrl-single,gpio-range-cells = <3>;
> };
>
> The gpio-ranges property is used in gpio driver and the
> pinctrl-single,gpio-range property is used in pinctrl-single driver.
>
> 1. gpio-ranges = <phandle gpio_offset_in_chip pin_offset nr_pins>
> gpio-ranges = < &pmx0 0 89 1 &pmx0 1 89 1 &pmx0 2 90 1
> &pmx0 3 90 1 &pmx0 4 91 1 &pmx0 5 92 1>;
I think the second gpio-ranges above should be really
pinctr-single,gpio-range instead of gpio-ranges?
> 2. gpio driver could get pin offset from gpio-ranges property.
> pinctrl-single driver could get gpio function mode from gpio_func
> that is stored in @gpiofuncs list in struct pcs_device.
> This new pinctrl-single,gpio-range is used as complement for
> gpio-ranges property in gpio driver.
Other than that looks OK to me. Assuming the other related GPIO patches
are fine and don't cause changes to this:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2013-02-13 18:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 17:10 [PATCH v8 00/12] bind pinconf with pinctrl single Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 01/12] gpio: add gpio offset in gpio range cells property Haojian Zhuang
2013-02-13 13:33 ` Linus Walleij
2013-02-11 17:10 ` [PATCH v8 02/12] gpio: fix wrong checking condition for gpio range Haojian Zhuang
2013-02-14 12:15 ` Linus Walleij
2013-02-11 17:10 ` [PATCH v8 03/12] gpio: pl061: allocate irq dynamically Haojian Zhuang
2013-02-14 14:04 ` Linus Walleij
2013-02-14 17:10 ` Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 04/12] pinctrl: verify whether gpio chip overlapps range Haojian Zhuang
2013-02-14 15:23 ` Linus Walleij
2013-02-14 17:01 ` Haojian Zhuang
2013-02-15 9:06 ` Linus Walleij
2013-02-17 9:42 ` Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 05/12] gpio: pl061: bind pinctrl by gpio request Haojian Zhuang
2013-02-14 15:29 ` Linus Walleij
2013-02-14 17:06 ` Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 06/12] pinctrl: single: create new gpio function range Haojian Zhuang
2013-02-13 18:39 ` Tony Lindgren [this message]
2013-02-17 10:00 ` Haojian Zhuang
2013-02-14 15:24 ` Linus Walleij
2013-02-14 16:25 ` Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 07/12] pinctrl: generic: dump pin configuration Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 08/12] pinctrl: single: set function mask as optional Haojian Zhuang
2013-02-13 18:40 ` Tony Lindgren
2013-02-11 17:10 ` [PATCH v8 09/12] pinctrl: generic: add auto pull config parameter Haojian Zhuang
2013-02-13 23:40 ` Tony Lindgren
2013-02-15 8:54 ` Linus Walleij
2013-02-15 16:37 ` Tony Lindgren
2013-02-15 20:55 ` Linus Walleij
2013-02-15 21:06 ` Tony Lindgren
2013-02-11 17:10 ` [PATCH v8 10/12] pinctrl: generic: rename input schmitt disable Haojian Zhuang
2013-02-13 23:41 ` Tony Lindgren
2013-02-11 17:10 ` [PATCH v8 11/12] pinctrl: single: support generic pinconf Haojian Zhuang
2013-02-13 23:50 ` Tony Lindgren
2013-02-11 17:10 ` [PATCH v8 12/12] document: devicetree: bind pinconf with pin single Haojian Zhuang
2013-02-13 23:51 ` Tony Lindgren
2013-02-15 9:11 ` [PATCH v8 00/12] bind pinconf with pinctrl single Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213183931.GL7144@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).