linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 10/12] pinctrl: generic: rename input schmitt disable
Date: Wed, 13 Feb 2013 15:41:27 -0800	[thread overview]
Message-ID: <20130213234127.GU7144@atomide.com> (raw)
In-Reply-To: <1360602659-4774-11-git-send-email-haojian.zhuang@linaro.org>

* Haojian Zhuang <haojian.zhuang@linaro.org> [130211 09:15]:
> Rename PIN_CONFIG_INPUT_SCHMITT_DISABLE to
> PIN_CONFIG_INPUT_SCHMITT_ENABLE. It's used to make it more generialize.
> 
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>

Makes sense to me for future naming of things:

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/pinctrl/pinconf-generic.c       |    2 +-
>  include/linux/pinctrl/pinconf-generic.h |    6 ++++--
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c
> index 4a67848..e43d2e0 100644
> --- a/drivers/pinctrl/pinconf-generic.c
> +++ b/drivers/pinctrl/pinconf-generic.c
> @@ -43,7 +43,7 @@ struct pin_config_item conf_items[] = {
>  	PCONFDUMP(PIN_CONFIG_DRIVE_PUSH_PULL, "output drive push pull", NULL),
>  	PCONFDUMP(PIN_CONFIG_DRIVE_OPEN_DRAIN, "output drive open drain", NULL),
>  	PCONFDUMP(PIN_CONFIG_DRIVE_OPEN_SOURCE, "output drive open source", NULL),
> -	PCONFDUMP(PIN_CONFIG_INPUT_SCHMITT_DISABLE, "input schmitt disabled", NULL),
> +	PCONFDUMP(PIN_CONFIG_INPUT_SCHMITT_ENABLE, "input schmitt enabled", NULL),
>  	PCONFDUMP(PIN_CONFIG_INPUT_SCHMITT, "input schmitt trigger", NULL),
>  	PCONFDUMP(PIN_CONFIG_INPUT_DEBOUNCE, "input debounce", "time units"),
>  	PCONFDUMP(PIN_CONFIG_POWER_SOURCE, "pin power source", "selector"),
> diff --git a/include/linux/pinctrl/pinconf-generic.h b/include/linux/pinctrl/pinconf-generic.h
> index f2daff4..93314cb 100644
> --- a/include/linux/pinctrl/pinconf-generic.h
> +++ b/include/linux/pinctrl/pinconf-generic.h
> @@ -50,7 +50,9 @@
>   *	argument is ignored.
>   * @PIN_CONFIG_DRIVE_STRENGTH: the pin will output the current passed as
>   * 	argument. The argument is in mA.
> - * @PIN_CONFIG_INPUT_SCHMITT_DISABLE: disable schmitt-trigger mode on the pin.
> + * @PIN_CONFIG_INPUT_SCHMITT_ENABLE: control schmitt-trigger mode on the pin.
> + *      If the argument != 0, schmitt-trigger mode is enabled. If it's 0,
> + *      schmitt-trigger mode is disabled.
>   * @PIN_CONFIG_INPUT_SCHMITT: this will configure an input pin to run in
>   *	schmitt-trigger mode. If the schmitt-trigger has adjustable hysteresis,
>   *	the threshold value is given on a custom format as argument when
> @@ -85,7 +87,7 @@ enum pin_config_param {
>  	PIN_CONFIG_DRIVE_OPEN_DRAIN,
>  	PIN_CONFIG_DRIVE_OPEN_SOURCE,
>  	PIN_CONFIG_DRIVE_STRENGTH,
> -	PIN_CONFIG_INPUT_SCHMITT_DISABLE,
> +	PIN_CONFIG_INPUT_SCHMITT_ENABLE,
>  	PIN_CONFIG_INPUT_SCHMITT,
>  	PIN_CONFIG_INPUT_DEBOUNCE,
>  	PIN_CONFIG_POWER_SOURCE,
> -- 
> 1.7.10.4
> 

  reply	other threads:[~2013-02-13 23:41 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 17:10 [PATCH v8 00/12] bind pinconf with pinctrl single Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 01/12] gpio: add gpio offset in gpio range cells property Haojian Zhuang
2013-02-13 13:33   ` Linus Walleij
2013-02-11 17:10 ` [PATCH v8 02/12] gpio: fix wrong checking condition for gpio range Haojian Zhuang
2013-02-14 12:15   ` Linus Walleij
2013-02-11 17:10 ` [PATCH v8 03/12] gpio: pl061: allocate irq dynamically Haojian Zhuang
2013-02-14 14:04   ` Linus Walleij
2013-02-14 17:10     ` Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 04/12] pinctrl: verify whether gpio chip overlapps range Haojian Zhuang
2013-02-14 15:23   ` Linus Walleij
2013-02-14 17:01     ` Haojian Zhuang
2013-02-15  9:06       ` Linus Walleij
2013-02-17  9:42         ` Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 05/12] gpio: pl061: bind pinctrl by gpio request Haojian Zhuang
2013-02-14 15:29   ` Linus Walleij
2013-02-14 17:06     ` Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 06/12] pinctrl: single: create new gpio function range Haojian Zhuang
2013-02-13 18:39   ` Tony Lindgren
2013-02-17 10:00     ` Haojian Zhuang
2013-02-14 15:24   ` Linus Walleij
2013-02-14 16:25     ` Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 07/12] pinctrl: generic: dump pin configuration Haojian Zhuang
2013-02-11 17:10 ` [PATCH v8 08/12] pinctrl: single: set function mask as optional Haojian Zhuang
2013-02-13 18:40   ` Tony Lindgren
2013-02-11 17:10 ` [PATCH v8 09/12] pinctrl: generic: add auto pull config parameter Haojian Zhuang
2013-02-13 23:40   ` Tony Lindgren
2013-02-15  8:54   ` Linus Walleij
2013-02-15 16:37     ` Tony Lindgren
2013-02-15 20:55       ` Linus Walleij
2013-02-15 21:06         ` Tony Lindgren
2013-02-11 17:10 ` [PATCH v8 10/12] pinctrl: generic: rename input schmitt disable Haojian Zhuang
2013-02-13 23:41   ` Tony Lindgren [this message]
2013-02-11 17:10 ` [PATCH v8 11/12] pinctrl: single: support generic pinconf Haojian Zhuang
2013-02-13 23:50   ` Tony Lindgren
2013-02-11 17:10 ` [PATCH v8 12/12] document: devicetree: bind pinconf with pin single Haojian Zhuang
2013-02-13 23:51   ` Tony Lindgren
2013-02-15  9:11 ` [PATCH v8 00/12] bind pinconf with pinctrl single Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130213234127.GU7144@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).