From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: arch_timer: include linux/errno.h to declare ENXIO
Date: Fri, 15 Feb 2013 10:18:01 +0000 [thread overview]
Message-ID: <20130215101801.GI25537@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <511D215C.2040807@wwwdotorg.org>
On Thu, Feb 14, 2013 at 05:39:40PM +0000, Stephen Warren wrote:
> On 02/14/2013 05:18 AM, Mark Rutland wrote:
> > On Wed, Feb 13, 2013 at 06:05:46PM +0000, Stephen Warren wrote:
> >> From: Stephen Warren <swarren@nvidia.com>
> >>
> >> This fixes:
> >> arch/arm/kernel/arch_timer.c: In function ?arch_timer_sched_clock_init?:
> >> arch/arm/kernel/arch_timer.c:55:11: error: ?ENXIO? undeclared (first use in this function)
> ..
> > We should probably also add this to include/clocksource/arm_arch_timer.h and
> > drivers/clocksource/arm_arch_timer.c, as they both use errno values (though
> > currently these get included indirectly via a different path).
>
> Ah yes, it should certainly be added to the header file then. Since both
> those .c files include that header, I guess there isn't much need to add
> it separately to the .c files though?
>
> Do you want me to respin the patch, or will you just create one to add
> the include to the header?
>
I think it makes sense to have the include in both the header and the .c file,
as they both use error codes explicitly. The header (and
drivers/clocksource/arm_arch_timer.c) seem to build for the moment, so they can
be fixed up later.
Arnd seems to have arrived at the same patch in his allyesconfig fix series:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/149856.html
I'm happy to see either version go in.
Thanks,
Mark.
prev parent reply other threads:[~2013-02-15 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 18:05 [PATCH] arm: arch_timer: include linux/errno.h to declare ENXIO Stephen Warren
2013-02-14 12:18 ` Mark Rutland
2013-02-14 17:39 ` Stephen Warren
2013-02-15 10:18 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215101801.GI25537@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).