From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig
Date: Fri, 15 Feb 2013 22:13:31 +0900 [thread overview]
Message-ID: <20130215131331.GA27724@verge.net.au> (raw)
In-Reply-To: <Pine.LNX.4.64.1302140942250.29693@axis700.grange>
On Thu, Feb 14, 2013 at 09:45:24AM +0100, Guennadi Liakhovetski wrote:
> On Thu, 14 Feb 2013, Simon Horman wrote:
>
> > On Wed, Feb 13, 2013 at 10:11:43PM +0900, Simon Horman wrote:
> > > Don't enable REGULATOR_DUMMY, it is only intended for development / testing.
> > > There doesn't seem to be any value in setting it here and doing
> > > so was an error on my part.
> > >
> > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > ---
> > > arch/arm/configs/kzm9g_defconfig | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig
> > > index 670c3b6..6751c02 100644
> > > --- a/arch/arm/configs/kzm9g_defconfig
> > > +++ b/arch/arm/configs/kzm9g_defconfig
> > > @@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y
> > > CONFIG_GPIO_PCF857X=y
> > > # CONFIG_HWMON is not set
> > > CONFIG_REGULATOR=y
> > > -CONFIG_REGULATOR_DUMMY=y
> > > CONFIG_FB=y
> > > CONFIG_FB_SH_MOBILE_LCDC=y
> > > CONFIG_FRAMEBUFFER_CONSOLE=y
> >
> > This patch seems to break NIC initialisation.
> >
> > smsc911x: Driver version 2008-10-21
> > smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517
> > smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517
> > platform smsc911x.0: Driver smsc911x requests probe deferral
>
> Right, you need a fixed regulator similar to how I adde it here
>
> http://www.spinics.net/lists/linux-sh/msg15713.html
Perhaps that is the wrong link?
The code in the link seems to be the same as what is preseng
in boards-kzm9g.c already and with it in place I see the error
above if CONFIG_REGULATOR_DUMMY is not enabled.
I am testing against with next branch in the renesas tree
with the kzm9g_defconfig, less CONFIG_REGULATOR_DUMMY.
next prev parent reply other threads:[~2013-02-15 13:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 13:11 [PATCH 0/3 v2] ARM: mach-shmobile: defconfig REGULATOR settings Simon Horman
2013-02-13 13:11 ` [PATCH 1/3] ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig Simon Horman
2013-02-13 13:21 ` Guennadi Liakhovetski
2013-02-13 14:10 ` Simon Horman
2013-02-13 13:11 ` [PATCH 2/3] ARM: mach-shmobile: armadillo800eva: " Simon Horman
2013-02-14 2:48 ` Simon Horman
2013-02-14 7:49 ` Guennadi Liakhovetski
2013-02-14 8:36 ` Simon Horman
2013-02-13 13:11 ` [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY " Simon Horman
2013-02-14 8:36 ` Simon Horman
2013-02-14 8:45 ` Guennadi Liakhovetski
2013-02-15 13:13 ` Simon Horman [this message]
2013-02-15 13:23 ` Guennadi Liakhovetski
2013-02-15 13:39 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215131331.GA27724@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).