* [PATCH 0/3 v2] ARM: mach-shmobile: defconfig REGULATOR settings
@ 2013-02-13 13:11 Simon Horman
2013-02-13 13:11 ` [PATCH 1/3] ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig Simon Horman
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Simon Horman @ 2013-02-13 13:11 UTC (permalink / raw)
To: linux-arm-kernel
* Enable REGULATOR for mackerel and armadillo800eva as
it will be needed for MMCIF to function.
* Do not enable REGULATOR_DUMMY for kzm9g,
it is only intended to be used for development and testing.
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 1/3] ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig 2013-02-13 13:11 [PATCH 0/3 v2] ARM: mach-shmobile: defconfig REGULATOR settings Simon Horman @ 2013-02-13 13:11 ` Simon Horman 2013-02-13 13:21 ` Guennadi Liakhovetski 2013-02-13 13:11 ` [PATCH 2/3] ARM: mach-shmobile: armadillo800eva: " Simon Horman 2013-02-13 13:11 ` [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY " Simon Horman 2 siblings, 1 reply; 14+ messages in thread From: Simon Horman @ 2013-02-13 13:11 UTC (permalink / raw) To: linux-arm-kernel As well as being a generally sane thing to do this is required for MMCIF to function in conjunction with " ARM: shmobile: streamline mackerel SD and MMC devices". Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v2 * Don't enable REGULATOR_DUMMY, it is only intended for development / testing. --- arch/arm/configs/mackerel_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/mackerel_defconfig b/arch/arm/configs/mackerel_defconfig index ec8e605..9fb1189 100644 --- a/arch/arm/configs/mackerel_defconfig +++ b/arch/arm/configs/mackerel_defconfig @@ -75,6 +75,7 @@ CONFIG_I2C=y CONFIG_I2C_SH_MOBILE=y # CONFIG_HWMON is not set # CONFIG_MFD_SUPPORT is not set +CONFIG_REGULATOR=y CONFIG_FB=y CONFIG_FB_MODE_HELPERS=y CONFIG_FB_SH_MOBILE_LCDC=y -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/3] ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig 2013-02-13 13:11 ` [PATCH 1/3] ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig Simon Horman @ 2013-02-13 13:21 ` Guennadi Liakhovetski 2013-02-13 14:10 ` Simon Horman 0 siblings, 1 reply; 14+ messages in thread From: Guennadi Liakhovetski @ 2013-02-13 13:21 UTC (permalink / raw) To: linux-arm-kernel Hi Simon On Wed, 13 Feb 2013, Simon Horman wrote: > As well as being a generally sane thing to do this > is required for MMCIF to function in conjunction with > " ARM: shmobile: streamline mackerel SD and MMC devices". > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > v2 > * Don't enable REGULATOR_DUMMY, it is only intended for development / testing. > --- > arch/arm/configs/mackerel_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/mackerel_defconfig b/arch/arm/configs/mackerel_defconfig > index ec8e605..9fb1189 100644 > --- a/arch/arm/configs/mackerel_defconfig > +++ b/arch/arm/configs/mackerel_defconfig > @@ -75,6 +75,7 @@ CONFIG_I2C=y > CONFIG_I2C_SH_MOBILE=y > # CONFIG_HWMON is not set > # CONFIG_MFD_SUPPORT is not set > +CONFIG_REGULATOR=y We really don't have to enable CONFIG_REGULATOR_GPIO and CONFIG_REGULATOR_FIXED_VOLTAGE? IIRC, CONFIG_REGULATOR_GPIO is so far only used on armadillo800eva, but the fixed regulator is required for other boards too? Thanks Guennadi > CONFIG_FB=y > CONFIG_FB_MODE_HELPERS=y > CONFIG_FB_SH_MOBILE_LCDC=y > -- > 1.7.10.4 --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/3] ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig 2013-02-13 13:21 ` Guennadi Liakhovetski @ 2013-02-13 14:10 ` Simon Horman 0 siblings, 0 replies; 14+ messages in thread From: Simon Horman @ 2013-02-13 14:10 UTC (permalink / raw) To: linux-arm-kernel On Wed, Feb 13, 2013 at 02:21:53PM +0100, Guennadi Liakhovetski wrote: > Hi Simon > > On Wed, 13 Feb 2013, Simon Horman wrote: > > > As well as being a generally sane thing to do this > > is required for MMCIF to function in conjunction with > > " ARM: shmobile: streamline mackerel SD and MMC devices". > > > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > > --- > > > > v2 > > * Don't enable REGULATOR_DUMMY, it is only intended for development / testing. > > --- > > arch/arm/configs/mackerel_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/configs/mackerel_defconfig b/arch/arm/configs/mackerel_defconfig > > index ec8e605..9fb1189 100644 > > --- a/arch/arm/configs/mackerel_defconfig > > +++ b/arch/arm/configs/mackerel_defconfig > > @@ -75,6 +75,7 @@ CONFIG_I2C=y > > CONFIG_I2C_SH_MOBILE=y > > # CONFIG_HWMON is not set > > # CONFIG_MFD_SUPPORT is not set > > +CONFIG_REGULATOR=y > > We really don't have to enable CONFIG_REGULATOR_GPIO and > CONFIG_REGULATOR_FIXED_VOLTAGE? IIRC, CONFIG_REGULATOR_GPIO is so far only > used on armadillo800eva, but the fixed regulator is required for other > boards too? The Kconfig for MACH_ARMADILLO800EVA selects REGULATOR_FIXED_VOLTAGE is REGULATOR is enabled. Likewise for kzm9g, mackerel and a bunch of other boards. ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig 2013-02-13 13:11 [PATCH 0/3 v2] ARM: mach-shmobile: defconfig REGULATOR settings Simon Horman 2013-02-13 13:11 ` [PATCH 1/3] ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig Simon Horman @ 2013-02-13 13:11 ` Simon Horman 2013-02-14 2:48 ` Simon Horman 2013-02-13 13:11 ` [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY " Simon Horman 2 siblings, 1 reply; 14+ messages in thread From: Simon Horman @ 2013-02-13 13:11 UTC (permalink / raw) To: linux-arm-kernel As well as being a generally sane thing to do this is required for MMCIF to function in conjunction with "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva". Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v2 * Don't enable REGULATOR_DUMMY, it is only intended for development / testing. --- arch/arm/configs/armadillo800eva_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig index 0b98100..0cc8014 100644 --- a/arch/arm/configs/armadillo800eva_defconfig +++ b/arch/arm/configs/armadillo800eva_defconfig @@ -88,6 +88,7 @@ CONFIG_I2C=y CONFIG_I2C_GPIO=y CONFIG_I2C_SH_MOBILE=y # CONFIG_HWMON is not set +CONFIG_REGULATOR=y CONFIG_MEDIA_SUPPORT=y CONFIG_VIDEO_DEV=y CONFIG_MEDIA_CAMERA_SUPPORT=y -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig 2013-02-13 13:11 ` [PATCH 2/3] ARM: mach-shmobile: armadillo800eva: " Simon Horman @ 2013-02-14 2:48 ` Simon Horman 2013-02-14 7:49 ` Guennadi Liakhovetski 0 siblings, 1 reply; 14+ messages in thread From: Simon Horman @ 2013-02-14 2:48 UTC (permalink / raw) To: linux-arm-kernel On Wed, Feb 13, 2013 at 10:11:42PM +0900, Simon Horman wrote: > As well as being a generally sane thing to do this > is required for MMCIF to function in conjunction with > "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva". > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > v2 > * Don't enable REGULATOR_DUMMY, it is only intended for development / testing. > --- > arch/arm/configs/armadillo800eva_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig > index 0b98100..0cc8014 100644 > --- a/arch/arm/configs/armadillo800eva_defconfig > +++ b/arch/arm/configs/armadillo800eva_defconfig > @@ -88,6 +88,7 @@ CONFIG_I2C=y > CONFIG_I2C_GPIO=y > CONFIG_I2C_SH_MOBILE=y > # CONFIG_HWMON is not set > +CONFIG_REGULATOR=y > CONFIG_MEDIA_SUPPORT=y > CONFIG_VIDEO_DEV=y > CONFIG_MEDIA_CAMERA_SUPPORT=y This patch seems to break NIC initialisation. smsc911x: Driver version 2008-10-21 smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 platform smsc911x.0: Driver smsc911x requests probe deferral ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig 2013-02-14 2:48 ` Simon Horman @ 2013-02-14 7:49 ` Guennadi Liakhovetski 2013-02-14 8:36 ` Simon Horman 0 siblings, 1 reply; 14+ messages in thread From: Guennadi Liakhovetski @ 2013-02-14 7:49 UTC (permalink / raw) To: linux-arm-kernel Hi Simon On Thu, 14 Feb 2013, Simon Horman wrote: > On Wed, Feb 13, 2013 at 10:11:42PM +0900, Simon Horman wrote: > > As well as being a generally sane thing to do this > > is required for MMCIF to function in conjunction with > > "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva". > > > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > > --- > > > > v2 > > * Don't enable REGULATOR_DUMMY, it is only intended for development / testing. > > --- > > arch/arm/configs/armadillo800eva_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig > > index 0b98100..0cc8014 100644 > > --- a/arch/arm/configs/armadillo800eva_defconfig > > +++ b/arch/arm/configs/armadillo800eva_defconfig > > @@ -88,6 +88,7 @@ CONFIG_I2C=y > > CONFIG_I2C_GPIO=y > > CONFIG_I2C_SH_MOBILE=y > > # CONFIG_HWMON is not set > > +CONFIG_REGULATOR=y > > CONFIG_MEDIA_SUPPORT=y > > CONFIG_VIDEO_DEV=y > > CONFIG_MEDIA_CAMERA_SUPPORT=y > > This patch seems to break NIC initialisation. > > smsc911x: Driver version 2008-10-21 > smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 > smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 > platform smsc911x.0: Driver smsc911x requests probe deferral Hm? Why is smsc911x even probing on armadillo800eva for you? Only sh-eth should be probing. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig 2013-02-14 7:49 ` Guennadi Liakhovetski @ 2013-02-14 8:36 ` Simon Horman 0 siblings, 0 replies; 14+ messages in thread From: Simon Horman @ 2013-02-14 8:36 UTC (permalink / raw) To: linux-arm-kernel On Thu, Feb 14, 2013 at 08:49:34AM +0100, Guennadi Liakhovetski wrote: > Hi Simon > > On Thu, 14 Feb 2013, Simon Horman wrote: > > > On Wed, Feb 13, 2013 at 10:11:42PM +0900, Simon Horman wrote: > > > As well as being a generally sane thing to do this > > > is required for MMCIF to function in conjunction with > > > "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva". > > > > > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > > > > --- > > > > > > v2 > > > * Don't enable REGULATOR_DUMMY, it is only intended for development / testing. > > > --- > > > arch/arm/configs/armadillo800eva_defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig > > > index 0b98100..0cc8014 100644 > > > --- a/arch/arm/configs/armadillo800eva_defconfig > > > +++ b/arch/arm/configs/armadillo800eva_defconfig > > > @@ -88,6 +88,7 @@ CONFIG_I2C=y > > > CONFIG_I2C_GPIO=y > > > CONFIG_I2C_SH_MOBILE=y > > > # CONFIG_HWMON is not set > > > +CONFIG_REGULATOR=y > > > CONFIG_MEDIA_SUPPORT=y > > > CONFIG_VIDEO_DEV=y > > > CONFIG_MEDIA_CAMERA_SUPPORT=y > > > > This patch seems to break NIC initialisation. > > > > smsc911x: Driver version 2008-10-21 > > smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 > > smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 > > platform smsc911x.0: Driver smsc911x requests probe deferral Sorry, I replied to the wrong patch. It was on KZM9G that I observed this. It seems to need REGULATOR_DUMMY. ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig 2013-02-13 13:11 [PATCH 0/3 v2] ARM: mach-shmobile: defconfig REGULATOR settings Simon Horman 2013-02-13 13:11 ` [PATCH 1/3] ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig Simon Horman 2013-02-13 13:11 ` [PATCH 2/3] ARM: mach-shmobile: armadillo800eva: " Simon Horman @ 2013-02-13 13:11 ` Simon Horman 2013-02-14 8:36 ` Simon Horman 2 siblings, 1 reply; 14+ messages in thread From: Simon Horman @ 2013-02-13 13:11 UTC (permalink / raw) To: linux-arm-kernel Don't enable REGULATOR_DUMMY, it is only intended for development / testing. There doesn't seem to be any value in setting it here and doing so was an error on my part. Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm/configs/kzm9g_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig index 670c3b6..6751c02 100644 --- a/arch/arm/configs/kzm9g_defconfig +++ b/arch/arm/configs/kzm9g_defconfig @@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y CONFIG_GPIO_PCF857X=y # CONFIG_HWMON is not set CONFIG_REGULATOR=y -CONFIG_REGULATOR_DUMMY=y CONFIG_FB=y CONFIG_FB_SH_MOBILE_LCDC=y CONFIG_FRAMEBUFFER_CONSOLE=y -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig 2013-02-13 13:11 ` [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY " Simon Horman @ 2013-02-14 8:36 ` Simon Horman 2013-02-14 8:45 ` Guennadi Liakhovetski 0 siblings, 1 reply; 14+ messages in thread From: Simon Horman @ 2013-02-14 8:36 UTC (permalink / raw) To: linux-arm-kernel On Wed, Feb 13, 2013 at 10:11:43PM +0900, Simon Horman wrote: > Don't enable REGULATOR_DUMMY, it is only intended for development / testing. > There doesn't seem to be any value in setting it here and doing > so was an error on my part. > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm/configs/kzm9g_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig > index 670c3b6..6751c02 100644 > --- a/arch/arm/configs/kzm9g_defconfig > +++ b/arch/arm/configs/kzm9g_defconfig > @@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y > CONFIG_GPIO_PCF857X=y > # CONFIG_HWMON is not set > CONFIG_REGULATOR=y > -CONFIG_REGULATOR_DUMMY=y > CONFIG_FB=y > CONFIG_FB_SH_MOBILE_LCDC=y > CONFIG_FRAMEBUFFER_CONSOLE=y This patch seems to break NIC initialisation. smsc911x: Driver version 2008-10-21 smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 platform smsc911x.0: Driver smsc911x requests probe deferral ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig 2013-02-14 8:36 ` Simon Horman @ 2013-02-14 8:45 ` Guennadi Liakhovetski 2013-02-15 13:13 ` Simon Horman 0 siblings, 1 reply; 14+ messages in thread From: Guennadi Liakhovetski @ 2013-02-14 8:45 UTC (permalink / raw) To: linux-arm-kernel On Thu, 14 Feb 2013, Simon Horman wrote: > On Wed, Feb 13, 2013 at 10:11:43PM +0900, Simon Horman wrote: > > Don't enable REGULATOR_DUMMY, it is only intended for development / testing. > > There doesn't seem to be any value in setting it here and doing > > so was an error on my part. > > > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > arch/arm/configs/kzm9g_defconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig > > index 670c3b6..6751c02 100644 > > --- a/arch/arm/configs/kzm9g_defconfig > > +++ b/arch/arm/configs/kzm9g_defconfig > > @@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y > > CONFIG_GPIO_PCF857X=y > > # CONFIG_HWMON is not set > > CONFIG_REGULATOR=y > > -CONFIG_REGULATOR_DUMMY=y > > CONFIG_FB=y > > CONFIG_FB_SH_MOBILE_LCDC=y > > CONFIG_FRAMEBUFFER_CONSOLE=y > > This patch seems to break NIC initialisation. > > smsc911x: Driver version 2008-10-21 > smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 > smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 > platform smsc911x.0: Driver smsc911x requests probe deferral Right, you need a fixed regulator similar to how I adde it here http://www.spinics.net/lists/linux-sh/msg15713.html Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig 2013-02-14 8:45 ` Guennadi Liakhovetski @ 2013-02-15 13:13 ` Simon Horman 2013-02-15 13:23 ` Guennadi Liakhovetski 0 siblings, 1 reply; 14+ messages in thread From: Simon Horman @ 2013-02-15 13:13 UTC (permalink / raw) To: linux-arm-kernel On Thu, Feb 14, 2013 at 09:45:24AM +0100, Guennadi Liakhovetski wrote: > On Thu, 14 Feb 2013, Simon Horman wrote: > > > On Wed, Feb 13, 2013 at 10:11:43PM +0900, Simon Horman wrote: > > > Don't enable REGULATOR_DUMMY, it is only intended for development / testing. > > > There doesn't seem to be any value in setting it here and doing > > > so was an error on my part. > > > > > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > --- > > > arch/arm/configs/kzm9g_defconfig | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig > > > index 670c3b6..6751c02 100644 > > > --- a/arch/arm/configs/kzm9g_defconfig > > > +++ b/arch/arm/configs/kzm9g_defconfig > > > @@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y > > > CONFIG_GPIO_PCF857X=y > > > # CONFIG_HWMON is not set > > > CONFIG_REGULATOR=y > > > -CONFIG_REGULATOR_DUMMY=y > > > CONFIG_FB=y > > > CONFIG_FB_SH_MOBILE_LCDC=y > > > CONFIG_FRAMEBUFFER_CONSOLE=y > > > > This patch seems to break NIC initialisation. > > > > smsc911x: Driver version 2008-10-21 > > smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 > > smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 > > platform smsc911x.0: Driver smsc911x requests probe deferral > > Right, you need a fixed regulator similar to how I adde it here > > http://www.spinics.net/lists/linux-sh/msg15713.html Perhaps that is the wrong link? The code in the link seems to be the same as what is preseng in boards-kzm9g.c already and with it in place I see the error above if CONFIG_REGULATOR_DUMMY is not enabled. I am testing against with next branch in the renesas tree with the kzm9g_defconfig, less CONFIG_REGULATOR_DUMMY. ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig 2013-02-15 13:13 ` Simon Horman @ 2013-02-15 13:23 ` Guennadi Liakhovetski 2013-02-15 13:39 ` Simon Horman 0 siblings, 1 reply; 14+ messages in thread From: Guennadi Liakhovetski @ 2013-02-15 13:23 UTC (permalink / raw) To: linux-arm-kernel Hi Simon On Fri, 15 Feb 2013, Simon Horman wrote: > On Thu, Feb 14, 2013 at 09:45:24AM +0100, Guennadi Liakhovetski wrote: > > On Thu, 14 Feb 2013, Simon Horman wrote: > > > > > On Wed, Feb 13, 2013 at 10:11:43PM +0900, Simon Horman wrote: > > > > Don't enable REGULATOR_DUMMY, it is only intended for development / testing. > > > > There doesn't seem to be any value in setting it here and doing > > > > so was an error on my part. > > > > > > > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > > --- > > > > arch/arm/configs/kzm9g_defconfig | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig > > > > index 670c3b6..6751c02 100644 > > > > --- a/arch/arm/configs/kzm9g_defconfig > > > > +++ b/arch/arm/configs/kzm9g_defconfig > > > > @@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y > > > > CONFIG_GPIO_PCF857X=y > > > > # CONFIG_HWMON is not set > > > > CONFIG_REGULATOR=y > > > > -CONFIG_REGULATOR_DUMMY=y > > > > CONFIG_FB=y > > > > CONFIG_FB_SH_MOBILE_LCDC=y > > > > CONFIG_FRAMEBUFFER_CONSOLE=y > > > > > > This patch seems to break NIC initialisation. > > > > > > smsc911x: Driver version 2008-10-21 > > > smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 > > > smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 > > > platform smsc911x.0: Driver smsc911x requests probe deferral > > > > Right, you need a fixed regulator similar to how I adde it here > > > > http://www.spinics.net/lists/linux-sh/msg15713.html > > Perhaps that is the wrong link? No, the link is right > The code in the link seems to be the same as what is preseng > in boards-kzm9g.c already Indeed, that should be fine. Ah, wait, what if you add ".0" to device names in regulators like REGULATOR_SUPPLY("vddvario", "smsc911x.0"), REGULATOR_SUPPLY("vdd33a", "smsc911x.0"), ? Thanks Guennadi > and with it in place I see the error > above if CONFIG_REGULATOR_DUMMY is not enabled. > > I am testing against with next branch in the renesas tree > with the kzm9g_defconfig, less CONFIG_REGULATOR_DUMMY. > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig 2013-02-15 13:23 ` Guennadi Liakhovetski @ 2013-02-15 13:39 ` Simon Horman 0 siblings, 0 replies; 14+ messages in thread From: Simon Horman @ 2013-02-15 13:39 UTC (permalink / raw) To: linux-arm-kernel On Fri, Feb 15, 2013 at 02:23:46PM +0100, Guennadi Liakhovetski wrote: > Hi Simon > > On Fri, 15 Feb 2013, Simon Horman wrote: > > > On Thu, Feb 14, 2013 at 09:45:24AM +0100, Guennadi Liakhovetski wrote: > > > On Thu, 14 Feb 2013, Simon Horman wrote: > > > > > > > On Wed, Feb 13, 2013 at 10:11:43PM +0900, Simon Horman wrote: > > > > > Don't enable REGULATOR_DUMMY, it is only intended for development / testing. > > > > > There doesn't seem to be any value in setting it here and doing > > > > > so was an error on my part. > > > > > > > > > > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > > > --- > > > > > arch/arm/configs/kzm9g_defconfig | 1 - > > > > > 1 file changed, 1 deletion(-) > > > > > > > > > > diff --git a/arch/arm/configs/kzm9g_defconfig b/arch/arm/configs/kzm9g_defconfig > > > > > index 670c3b6..6751c02 100644 > > > > > --- a/arch/arm/configs/kzm9g_defconfig > > > > > +++ b/arch/arm/configs/kzm9g_defconfig > > > > > @@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y > > > > > CONFIG_GPIO_PCF857X=y > > > > > # CONFIG_HWMON is not set > > > > > CONFIG_REGULATOR=y > > > > > -CONFIG_REGULATOR_DUMMY=y > > > > > CONFIG_FB=y > > > > > CONFIG_FB_SH_MOBILE_LCDC=y > > > > > CONFIG_FRAMEBUFFER_CONSOLE=y > > > > > > > > This patch seems to break NIC initialisation. > > > > > > > > smsc911x: Driver version 2008-10-21 > > > > smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 > > > > smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 > > > > platform smsc911x.0: Driver smsc911x requests probe deferral > > > > > > Right, you need a fixed regulator similar to how I adde it here > > > > > > http://www.spinics.net/lists/linux-sh/msg15713.html > > > > Perhaps that is the wrong link? > > No, the link is right > > > The code in the link seems to be the same as what is preseng > > in boards-kzm9g.c already > > Indeed, that should be fine. Ah, wait, what if you add ".0" to device > names in regulators like > > REGULATOR_SUPPLY("vddvario", "smsc911x.0"), > REGULATOR_SUPPLY("vdd33a", "smsc911x.0"), Bingo! Thanks, I'll send a patch. ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-02-15 13:39 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-02-13 13:11 [PATCH 0/3 v2] ARM: mach-shmobile: defconfig REGULATOR settings Simon Horman 2013-02-13 13:11 ` [PATCH 1/3] ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig Simon Horman 2013-02-13 13:21 ` Guennadi Liakhovetski 2013-02-13 14:10 ` Simon Horman 2013-02-13 13:11 ` [PATCH 2/3] ARM: mach-shmobile: armadillo800eva: " Simon Horman 2013-02-14 2:48 ` Simon Horman 2013-02-14 7:49 ` Guennadi Liakhovetski 2013-02-14 8:36 ` Simon Horman 2013-02-13 13:11 ` [PATCH 3/3] ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY " Simon Horman 2013-02-14 8:36 ` Simon Horman 2013-02-14 8:45 ` Guennadi Liakhovetski 2013-02-15 13:13 ` Simon Horman 2013-02-15 13:23 ` Guennadi Liakhovetski 2013-02-15 13:39 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).