linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: fweisbec@gmail.com (Frederic Weisbecker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] cpustat: use atomic operations to read/update stats
Date: Fri, 22 Feb 2013 15:23:05 +0100	[thread overview]
Message-ID: <20130222142302.GC18149@somewhere.redhat.com> (raw)
In-Reply-To: <1361542891.3683.6.camel@edumazet-glaptop>

On Fri, Feb 22, 2013 at 06:21:31AM -0800, Eric Dumazet wrote:
> On Fri, 2013-02-22 at 15:09 +0100, Peter Zijlstra wrote:
> > On Fri, 2013-02-22 at 13:50 +0100, Frederic Weisbecker wrote:
> > > > Argh!! at what cost? 64bit atomics are like expensive. Wouldn't
> > > adding
> > > > a seqlock be saner?
> > > 
> > > Not sure. This requires a spinlock in the write side which is called
> > > from
> > > fast path like the timer interrupt.
> > 
> > A single spinlock is _way_ cheaper than a ton of cmpxchg8b()s to update
> > a few variables.
> 
> We also have include/linux/u64_stats_sync.h since 2.6.36

Interesting, we should probably use that instead.

  reply	other threads:[~2013-02-22 14:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-22  5:56 [PATCH 0/2] cpustat: use atomic operations to read/update stats Kevin Hilman
2013-02-22  5:56 ` [PATCH 1/2] cpustat: use accessor functions for get/set/add Kevin Hilman
2013-02-22  6:21   ` Viresh Kumar
2013-02-22  7:17     ` Amit Kucheria
2013-02-22  7:50       ` Viresh Kumar
2013-02-22 12:34       ` Frederic Weisbecker
2013-02-22 15:14     ` Kevin Hilman
2013-02-22 13:38   ` Frederic Weisbecker
2013-02-22 13:58     ` Peter Zijlstra
2013-02-22 14:03       ` Frederic Weisbecker
2013-02-22  5:56 ` [PATCH 2/2] cpustat: convert to atomic operations Kevin Hilman
2013-02-22  8:46 ` [PATCH 0/2] cpustat: use atomic operations to read/update stats Peter Zijlstra
2013-02-22 12:50   ` Frederic Weisbecker
2013-02-22 13:48     ` Peter Zijlstra
2013-02-22 13:54       ` Ingo Molnar
2013-02-22 14:04         ` Peter Zijlstra
2013-02-22 14:16           ` Ingo Molnar
2013-02-22 14:25             ` Peter Zijlstra
2013-02-22 14:05     ` Peter Zijlstra
2013-02-22 14:15       ` Frederic Weisbecker
2013-02-22 14:09     ` Peter Zijlstra
2013-02-22 14:18       ` Ingo Molnar
2013-02-22 14:21       ` Eric Dumazet
2013-02-22 14:23         ` Frederic Weisbecker [this message]
2013-02-22 19:01           ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130222142302.GC18149@somewhere.redhat.com \
    --to=fweisbec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).