From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: question about arch/arm/mach-s3c24xx/irq.c
Date: Sun, 24 Feb 2013 12:38:49 +0000 [thread overview]
Message-ID: <20130224123849.GH17833@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1302241241440.1943@hadrien>
On Sun, Feb 24, 2013 at 12:45:11PM +0100, Julia Lawall wrote:
> The function s3c24xx_irq_map in arch/arm/mach-s3c24xx/irq.c contains the
> code:
>
> parent_irq_data = &parent_intc->irqs[irq_data->parent_irq];
> if (!irq_data) {
> pr_err("irq-s3c24xx: no irq data found for hwirq %lu\n",
> hw);
> goto err;
> }
>
> At this point irq_data has already been tested, so the null test on
> irq_data does not look correct. But I wonder if parent_irq_data could
> ever be null here?
That would be really obscure - because that would require parent_intc to
be a "negative" pointer (to counter-act the indexing by
irq_data->parent_irq). So it looks to me like the above is redundant.
next prev parent reply other threads:[~2013-02-24 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 11:45 question about arch/arm/mach-s3c24xx/irq.c Julia Lawall
2013-02-24 12:38 ` Russell King - ARM Linux [this message]
2013-02-24 13:39 ` Julia Lawall
2013-02-24 15:11 ` Heiko Stübner
2013-02-24 15:45 ` Julia Lawall
2013-02-24 17:49 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130224123849.GH17833@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox