From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: compat_sys_sigsuspend: init local blocked mask not current process mask
Date: Mon, 25 Feb 2013 12:58:03 +0000 [thread overview]
Message-ID: <20130225125803.GB28172@arm.com> (raw)
In-Reply-To: <1361796007-20143-1-git-send-email-ryan.harkin@linaro.org>
On Mon, Feb 25, 2013 at 12:40:07PM +0000, Ryan Harkin wrote:
> The original version changed the signal mask in the current process,
> and then passed an unitialized variable to sigsuspend, which in turn,
> besides the other work, sets current->blocked.
>
> The value of mask, passed from a process, was effectively overwritten
> by some random value. If the random value was zero, all signals were
> blocked and pipes no longer work.
>
> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
Thanks for the patch. It's a candidate for stable since mainline no
longer has this function, removed by commit 84b9e9b40 (arm64: switch
compat to generic old sigsuspend).
--
Catalin
prev parent reply other threads:[~2013-02-25 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 12:40 [PATCH] arm64: compat_sys_sigsuspend: init local blocked mask not current process mask Ryan Harkin
2013-02-25 12:58 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130225125803.GB28172@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox