linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] DMA: PL330: allow submitting 2 requests at a time
Date: Mon, 4 Mar 2013 10:26:25 +0530	[thread overview]
Message-ID: <20130304045625.GD22513@intel.com> (raw)
In-Reply-To: <1360752194-6506-1-git-send-email-jaswinder.singh@linaro.org>

On Wed, Feb 13, 2013 at 04:13:14PM +0530, Jassi Brar wrote:
> Fix the logic to allow mc programming of second transfer after first
> has been done, by removing immediate return upon success and iterating
> until we detect QFull or DMAC dying.
> 
> Reported-by: Alvaro Moran <dirac3000@gmail.com>
> Tested-by: Alvaro Moran <dirac3000@gmail.com>
> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Applied, thanks

> ---
>  drivers/dma/pl330.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 80680ee..c1a867e 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2282,13 +2282,12 @@ static inline void fill_queue(struct dma_pl330_chan *pch)
>  
>  		/* If already submitted */
>  		if (desc->status == BUSY)
> -			break;
> +			continue;
>  
>  		ret = pl330_submit_req(pch->pl330_chid,
>  						&desc->req);
>  		if (!ret) {
>  			desc->status = BUSY;
> -			break;
>  		} else if (ret == -EAGAIN) {
>  			/* QFull or DMAC Dying */
>  			break;
> -- 
> 1.7.10.4
> 

      parent reply	other threads:[~2013-03-04  4:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 10:43 [PATCH] DMA: PL330: allow submitting 2 requests at a time Jassi Brar
2013-02-14 14:25 ` Vinod Koul
2013-03-04  4:56 ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130304045625.GD22513@intel.com \
    --to=vinod.koul@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).