From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] DMA: PL330: Add check if device tree compatible
Date: Mon, 4 Mar 2013 12:58:38 +0000 [thread overview]
Message-ID: <201303041258.39222.arnd@arndb.de> (raw)
In-Reply-To: <1362374943-29312-1-git-send-email-padma.v@samsung.com>
On Monday 04 March 2013, Padmavathi Venna wrote:
> +
> + if (adev->dev.of_node) {
> + ret = of_dma_controller_register(adev->dev.of_node,
> + of_dma_pl330_xlate, pdmac);
> + if (ret) {
> + dev_err(&adev->dev,
> + "unable to register DMA to the generic DT DMA helpers\n");
> + goto probe_err4;
> + }
> }
Hmm, when I did the same thing in dw_dma, Andy commented that this should
not be a failure at all, since the device is still usable. Could we
instead make of_dma_controller_register return silently when it
gets a NULL of_node?
Arnd
next prev parent reply other threads:[~2013-03-04 12:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 5:29 [PATCH] DMA: PL330: Add check if device tree compatible Padmavathi Venna
2013-03-04 12:58 ` Arnd Bergmann [this message]
2013-03-05 5:51 ` Padma Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303041258.39222.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).