From mboxrd@z Thu Jan  1 00:00:00 1970
From: arnd@arndb.de (Arnd Bergmann)
Date: Mon, 4 Mar 2013 12:58:38 +0000
Subject: [PATCH] DMA: PL330: Add check if device tree compatible
In-Reply-To: <1362374943-29312-1-git-send-email-padma.v@samsung.com>
References: <1362374943-29312-1-git-send-email-padma.v@samsung.com>
Message-ID: <201303041258.39222.arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Monday 04 March 2013, Padmavathi Venna wrote:
> +
> +       if (adev->dev.of_node) {
> +               ret = of_dma_controller_register(adev->dev.of_node,
> +                                        of_dma_pl330_xlate, pdmac);
> +               if (ret) {
> +                       dev_err(&adev->dev,
> +                       "unable to register DMA to the generic DT DMA helpers\n");
> +                       goto probe_err4;
> +               }
>         }

Hmm, when I did the same thing in dw_dma, Andy commented that this should
not be a failure at all, since the device is still usable. Could we
instead make of_dma_controller_register return silently when it
gets a NULL of_node?

	Arnd