From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: omap2: mux: fix debugfs file permission
Date: Mon, 4 Mar 2013 11:18:31 -0800 [thread overview]
Message-ID: <20130304191830.GV11806@atomide.com> (raw)
In-Reply-To: <1361269464-20263-1-git-send-email-balbi@ti.com>
* Felipe Balbi <balbi@ti.com> [130219 02:28]:
> OMAP's debugfs interface creates one file
> for each signal in the mux table, such file
> provides a read method but didn't provide
> read permission. Fix it.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Heh indeed, although read still seems to work without it.
Applying into omap-for-v3.9/fixes.
Regards,
Tony
> ---
> arch/arm/mach-omap2/mux.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
> index 6a217c9..03fa4f4 100644
> --- a/arch/arm/mach-omap2/mux.c
> +++ b/arch/arm/mach-omap2/mux.c
> @@ -739,8 +739,9 @@ static void __init omap_mux_dbg_create_entry(
> list_for_each_entry(e, &partition->muxmodes, node) {
> struct omap_mux *m = &e->mux;
>
> - (void)debugfs_create_file(m->muxnames[0], S_IWUSR, mux_dbg_dir,
> - m, &omap_mux_dbg_signal_fops);
> + (void)debugfs_create_file(m->muxnames[0], S_IWUSR | S_IRUGO,
> + mux_dbg_dir, m,
> + &omap_mux_dbg_signal_fops);
> }
> }
>
> --
> 1.8.1.rc1.5.g7e0651a
>
next prev parent reply other threads:[~2013-03-04 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 10:24 [PATCH 1/2] arm: omap2: mux: fix debugfs file permission Felipe Balbi
2013-02-19 10:24 ` [PATCH 2/2] arm: omap2: voltage: remove unnecessary header Felipe Balbi
2013-03-04 19:18 ` Tony Lindgren [this message]
2013-03-04 20:19 ` [PATCH 1/2] arm: omap2: mux: fix debugfs file permission Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304191830.GV11806@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).