linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: imx: avic: Move avic_saved_mask_reg under CONFIG_PM
@ 2013-02-05 17:36 Fabio Estevam
  2013-03-05 11:07 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-02-05 17:36 UTC (permalink / raw)
  To: linux-arm-kernel

When building a kernel with CONFIG_PM undefined, the following warning happens:

arch/arm/mach-imx/avic.c:57:12: warning: 'avic_saved_mask_reg' defined but not used [-Wunused-variable]

Move avic_saved_mask_reg definition inside the '#ifdef CONFIG_PM' block to
avoid the warning.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/mach-imx/avic.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-imx/avic.c b/arch/arm/mach-imx/avic.c
index 0eff23e..49c87e7 100644
--- a/arch/arm/mach-imx/avic.c
+++ b/arch/arm/mach-imx/avic.c
@@ -54,8 +54,6 @@
 void __iomem *avic_base;
 static struct irq_domain *domain;
 
-static u32 avic_saved_mask_reg[2];
-
 #ifdef CONFIG_MXC_IRQ_PRIOR
 static int avic_irq_set_priority(unsigned char irq, unsigned char prio)
 {
@@ -113,6 +111,8 @@ static struct mxc_extra_irq avic_extra_irq = {
 };
 
 #ifdef CONFIG_PM
+static u32 avic_saved_mask_reg[2];
+
 static void avic_irq_suspend(struct irq_data *d)
 {
 	struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: imx: avic: Move avic_saved_mask_reg under CONFIG_PM
  2013-02-05 17:36 [PATCH] ARM: imx: avic: Move avic_saved_mask_reg under CONFIG_PM Fabio Estevam
@ 2013-03-05 11:07 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2013-03-05 11:07 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Feb 05, 2013 at 03:36:16PM -0200, Fabio Estevam wrote:
> When building a kernel with CONFIG_PM undefined, the following warning happens:
> 
> arch/arm/mach-imx/avic.c:57:12: warning: 'avic_saved_mask_reg' defined but not used [-Wunused-variable]
> 
> Move avic_saved_mask_reg definition inside the '#ifdef CONFIG_PM' block to
> avoid the warning.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied, thanks

Sascha

> ---
>  arch/arm/mach-imx/avic.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/avic.c b/arch/arm/mach-imx/avic.c
> index 0eff23e..49c87e7 100644
> --- a/arch/arm/mach-imx/avic.c
> +++ b/arch/arm/mach-imx/avic.c
> @@ -54,8 +54,6 @@
>  void __iomem *avic_base;
>  static struct irq_domain *domain;
>  
> -static u32 avic_saved_mask_reg[2];
> -
>  #ifdef CONFIG_MXC_IRQ_PRIOR
>  static int avic_irq_set_priority(unsigned char irq, unsigned char prio)
>  {
> @@ -113,6 +111,8 @@ static struct mxc_extra_irq avic_extra_irq = {
>  };
>  
>  #ifdef CONFIG_PM
> +static u32 avic_saved_mask_reg[2];
> +
>  static void avic_irq_suspend(struct irq_data *d)
>  {
>  	struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
> -- 
> 1.7.9.5
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-05 11:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-05 17:36 [PATCH] ARM: imx: avic: Move avic_saved_mask_reg under CONFIG_PM Fabio Estevam
2013-03-05 11:07 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).