From: moinejf@free.fr (Jean-Francois Moine)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE"
Date: Tue, 5 Mar 2013 19:02:31 +0100 [thread overview]
Message-ID: <20130305190232.0b1a5e29@armhf> (raw)
In-Reply-To: <20130305140025.GO23237@titan.lakedaemon.net>
On Tue, 5 Mar 2013 09:00:25 -0500
Jason Cooper <jason@lakedaemon.net> wrote:
> On Tue, Mar 05, 2013 at 10:34:58AM +0100, Paul Bolle wrote:
> > Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to
> > DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's
> > Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which
> > makes this select statement a nop. Since the Marvell Dove code includes
> > <linux/clk-provider.h> we can assume that this entry needs to select
> > COMMON_CLK instead.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > Untested.
> >
> > arch/arm/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Nice catch, thanks for the patch. Sebastian, could you test this and
> report back?
I also have a Cubox and I generated a kernel 3.9-rc1 for it (not tested
yet).
The .config contains CONFIG_COMMON_CLK=y naturally because MACH_DOVE
selects PLAT_ORION_LEGACY which selects PLAT_ORION which selects
COMMON_CLK.
So, "select COMMON_CLK" is not needed in ARCH_DOVE.
BTW, why is there a PLAT_ORION_LEGACY?
--
Ken ar c'henta? | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2013-03-05 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 9:34 [PATCH] ARM: dove: Fix typo "COMMON_CLK_DOVE" Paul Bolle
2013-03-05 14:00 ` Jason Cooper
2013-03-05 18:02 ` Jean-Francois Moine [this message]
2013-03-05 18:23 ` Paul Bolle
2013-03-05 18:34 ` Sebastian Hesselbarth
2013-03-05 20:17 ` [PATCH v2] ARM: dove: drop "select COMMON_CLK_DOVE" Paul Bolle
2013-03-08 21:26 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305190232.0b1a5e29@armhf \
--to=moinejf@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).