[PATCH v11 4/9] usb: chipidea: udc: add pullup/pulldown dp at hw_device_state

Peter Chen
2013-03-08T08:05:56Z

On Fri, Mar 08, 2013 at 09:18:32AM +0200, Felipe Balbi wrote:
> > >
> > > This isn't legal. If you want to make sure vbus is alive before
> > > connecting pullups, then do it generically. Modify udc-core.c to make
> > > those checks for you. Bypassing the framework is dangerous because
> > > whenever I wanna change something, I might miss your private details and
> > > end up causing regressions.
> >
> > Let thing be generic is a good idea. Then, is it ok I post a patch let
> > udc manage pullup by itself (through a flag) just you did for uvc?
> > UDC core doesn't know VBUS, so the pullup can't be managed by udc core
> > totally.
>
> then teach UDC core about VBUS. Send the patches and we will figure out
> if they can be applied or not.

I will do it

>
> --
> balbi

--

Best Regards,
Peter Chen