From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: drop "select MACH_NOKIA_RM696"
Date: Fri, 8 Mar 2013 08:35:07 -0800 [thread overview]
Message-ID: <20130308163507.GC26093@atomide.com> (raw)
In-Reply-To: <20130308161159.GE14552@blackmetal.musicnaut.iki.fi>
* Aaro Koskinen <aaro.koskinen@iki.fi> [130308 08:16]:
> On Fri, Mar 08, 2013 at 11:29:56AM +0100, Paul Bolle wrote:
> > When support was added for Nokia N9 (RM-696), with commit
> > 63fc5f3bb3d0ca9ab4767a801b518aa6335f87ad ("ARM: OMAP: add minimal
> > support for Nokia RM-696"), a select statement for MACH_NOKIA_RM696 was
> > added to the tree. But there's no Kconfig symbol with that name. That
> > symbol would be superfluous, since support for that machine piggybacks
> > on MACH_NOKIA_RM680. So drop that select.
>
> This is needed because of arch/arm/tools/mach-types. See
> include/generated/mach-types.h.
>
> If you have just CONFIG_MACH_NOKIA_RM680 and run the kernel on RM-696,
> then machine_is_nokia_rm696() will return false. If I rememeber correctly,
> this broke at least early printk / uncompressor output at the time.
>
> I guess people may still want to use machine_is_... macros e.g. for
> debugging.
I think the righ fix is to just add
config MACH_NOKIA_RM680
bool
to the mach-omap2/Kconfig like we have for n8x0 also.
Regards,
Tony
next prev parent reply other threads:[~2013-03-08 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 10:29 [PATCH] ARM: OMAP: drop "select MACH_NOKIA_RM696" Paul Bolle
2013-03-08 16:11 ` Aaro Koskinen
2013-03-08 16:35 ` Tony Lindgren [this message]
2013-03-08 17:20 ` Paul Bolle
2013-03-08 17:55 ` Tony Lindgren
2013-03-08 18:02 ` Paul Bolle
2013-03-08 18:10 ` Tony Lindgren
2013-03-09 0:01 ` Russell King - ARM Linux
2013-03-09 19:48 ` Paul Bolle
2013-03-11 16:33 ` Tony Lindgren
2013-03-14 8:00 ` Paul Bolle
2013-03-08 17:18 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308163507.GC26093@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).