From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] ARM: smp_twd: Divorce smp_twd from local timer API
Date: Fri, 8 Mar 2013 12:08:12 -0800 [thread overview]
Message-ID: <20130308200811.GJ11806@atomide.com> (raw)
In-Reply-To: <513A40EF.8050403@codeaurora.org>
* Stephen Boyd <sboyd@codeaurora.org> [130308 11:54]:
> On 03/08/13 11:48, Tony Lindgren wrote:
> > * Stephen Boyd <sboyd@codeaurora.org> [130308 10:21]:
> >>
> >> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
> >> index 081de6f..4ea3e9d 100644
> >> --- a/arch/arm/kernel/smp_twd.c
> >> +++ b/arch/arm/kernel/smp_twd.c
> >> @@ -227,7 +227,7 @@ static void __cpuinit twd_calibrate_rate(void)
> >>
> >> static irqreturn_t twd_handler(int irq, void *dev_id)
> >> {
> >> - struct clock_event_device *evt = *(struct clock_event_device **)dev_id;
> >> + struct clock_event_device *evt = dev_id;
> >>
> >> if (twd_timer_ack()) {
> >> evt->event_handler(evt);
> >>
> > Yup thanks that fixes it, both fixes are needed. So for this patch + the
> > two fixes please feel free to add:
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
>
> Great. Thanks for testing.
Hmm noticed one more thing: vexpress no longer boots in qemu for
me after applying this. Sorry did not get any debug_ll output, but
maybe you can take a look at it. I tested with omap2plus_defconfig +
linaro-qemu:
$ qemu-system-arm -machine vexpress-a9 -m 1024 -curses -net nic -net \
user -serial stdio -append console=ttyAMA0,115200n8 rw \
root=/dev/mmcblk0p2 rootwait physmap.enabled=0 -kernel zImage \
-initrd initrd.img -sd rootfs.img
Regards,
Tony
next prev parent reply other threads:[~2013-03-08 20:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 0:03 [PATCHv2 0/10] Remove ARM local timer API Stephen Boyd
2013-03-07 0:03 ` [PATCH 01/10] clocksource: add generic dummy timer driver Stephen Boyd
2013-03-07 14:00 ` Thomas Gleixner
2013-03-07 21:41 ` Stephen Boyd
2013-03-07 0:03 ` [PATCH 02/10] ARM: smp: Remove duplicate dummy timer implementation Stephen Boyd
2013-03-07 0:03 ` [PATCH 03/10] ARM: smp_twd: Divorce smp_twd from local timer API Stephen Boyd
2013-03-08 0:40 ` Tony Lindgren
2013-03-08 1:14 ` Stephen Boyd
2013-03-08 18:07 ` Tony Lindgren
2013-03-08 18:17 ` Stephen Boyd
2013-03-08 19:48 ` Tony Lindgren
2013-03-08 19:50 ` Stephen Boyd
2013-03-08 20:08 ` Tony Lindgren [this message]
2013-03-08 20:17 ` Stephen Boyd
2013-03-08 20:29 ` Tony Lindgren
2013-03-09 1:06 ` Stephen Boyd
2013-03-11 17:28 ` Tony Lindgren
2013-03-11 22:17 ` Stephen Boyd
2013-03-11 22:50 ` Tony Lindgren
2013-03-12 1:20 ` Stephen Boyd
2013-03-12 17:06 ` Tony Lindgren
2013-03-07 0:04 ` [PATCH 04/10] ARM: OMAP2+: Divorce " Stephen Boyd
2013-03-08 19:50 ` Tony Lindgren
2013-03-11 15:29 ` Santosh Shilimkar
2013-03-07 0:04 ` [PATCH 05/10] ARM: EXYNOS4: Divorce mct " Stephen Boyd
2013-03-07 0:04 ` [PATCH 06/10] ARM: PRIMA2: Divorce timer-marco " Stephen Boyd
2013-03-07 0:04 ` [PATCH 07/10] ARM: msm: Divorce msm_timer " Stephen Boyd
2013-03-07 0:04 ` [PATCH 08/10] clocksource: time-armada-370-xp: Fix sparse warning Stephen Boyd
2013-03-07 0:04 ` [PATCH 09/10] clocksource: time-armada-370-xp: Divorce from local timer API Stephen Boyd
2013-03-07 0:04 ` [PATCH 10/10] ARM: smp: Remove " Stephen Boyd
2013-03-08 19:55 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308200811.GJ11806@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).