From: srinidhi.kasagar@stericsson.com (Srinidhi Kasagar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: ux500: Remove duplicate ux500_l2x0_unlock function
Date: Tue, 12 Mar 2013 11:12:29 +0530 [thread overview]
Message-ID: <20130312054226.GA811@bnru09> (raw)
In-Reply-To: <20130312045823.GA526@android11.spreadtrum.com>
On Tue, Mar 12, 2013 at 05:58:23 +0100, Steve zhan wrote:
> Hi Linus:
> Pls check/apply the below patch.
> Thanks.
NAK, I think you have not read the comment i guess. See below.
>
> -----
> steve
>
> commit f962757a91b1c83a080e7c5b05cc6fb7828f1d84
> Author: steve.zhan <zhanzhenbo@gmail.com>
> Date: Tue Mar 12 00:12:53 2013 +0800
>
> ARM: ux500: Remove duplicate ux500_l2x0_unlock function
>
> To avoids code duplication, remove reduplicate l2 cache unlock
> function "ux500_l2x0_unlock" in the ux500_l2x0_init, as arm\mm
> \cache-l2x0.c l2x0_init will call l2x0_unlock function to
> make sure that I&D is not locked down when starting.
>
> Signed-off-by: steve.zhan <zhanzhenbo@gmail.com>
>
> diff --git a/arch/arm/mach-ux500/cache-l2x0.c b/arch/arm/mach-ux500/cache-l2x0.c
> index 1c1609d..372bdf6 100644
> --- a/arch/arm/mach-ux500/cache-l2x0.c
> +++ b/arch/arm/mach-ux500/cache-l2x0.c
> @@ -15,26 +15,6 @@
>
> static void __iomem *l2x0_base;
>
> -static int __init ux500_l2x0_unlock(void)
> -{
> - int i;
> -
> - /*
> - * Unlock Data and Instruction Lock if locked. Ux500 U-Boot versions
> - * apparently locks both caches before jumping to the kernel. The
> - * l2x0 core will not touch the unlock registers if the l2x0 is
> - * already enabled, so we do it right here instead. The PL310 has
The l2x0 core will unlock only if l2x0 is already not enabled. So we need this.
/srinidhi
prev parent reply other threads:[~2013-03-12 5:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 4:58 [PATCH] ARM: ux500: Remove duplicate ux500_l2x0_unlock function Steve zhan
2013-03-12 5:42 ` Srinidhi Kasagar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312054226.GA811@bnru09 \
--to=srinidhi.kasagar@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox