* [PATCH 3.9-rc1] clk: vt8500: Fix variable name '*prate' compile error
@ 2013-02-26 17:34 Tim Gardner
2013-02-26 19:29 ` Mike Turquette
0 siblings, 1 reply; 6+ messages in thread
From: Tim Gardner @ 2013-02-26 17:34 UTC (permalink / raw)
To: linux-arm-kernel
commit 72480014b86c8b51fb51c5c6a0525876055c37c7 (clk: vt8500: Fix device clock
divisor calculations) introduced a compile error in the naming of a variable in
vt8500_dclk_set_rate(). It looks like a simple cut and paste error.
Cc: Mike Turquette <mturquette@linaro.org>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
drivers/clk/clk-vt8500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
index b5538bb..09c6331 100644
--- a/drivers/clk/clk-vt8500.c
+++ b/drivers/clk/clk-vt8500.c
@@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
divisor = parent_rate / rate;
/* If prate / rate would be decimal, incr the divisor */
- if (rate * divisor < *prate)
+ if (rate * divisor < parent_rate)
divisor++;
if (divisor == cdev->div_mask + 1)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3.9-rc1] clk: vt8500: Fix variable name '*prate' compile error
2013-02-26 17:34 [PATCH 3.9-rc1] clk: vt8500: Fix variable name '*prate' compile error Tim Gardner
@ 2013-02-26 19:29 ` Mike Turquette
2013-03-11 22:07 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Mike Turquette @ 2013-02-26 19:29 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Tim Gardner (2013-02-26 09:34:12)
> commit 72480014b86c8b51fb51c5c6a0525876055c37c7 (clk: vt8500: Fix device clock
> divisor calculations) introduced a compile error in the naming of a variable in
> vt8500_dclk_set_rate(). It looks like a simple cut and paste error.
>
> Cc: Mike Turquette <mturquette@linaro.org>
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Tim,
Thanks for the fix. I already have a fix for this issue in my clk-fixes
branch. In fact I forgot to bundle this one and another mxs fix in my
3.9 pull request so I'll send a follow-up bugfix branch after 3.9-rc1 is
out.
Regards,
Mike
> ---
> drivers/clk/clk-vt8500.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
> index b5538bb..09c6331 100644
> --- a/drivers/clk/clk-vt8500.c
> +++ b/drivers/clk/clk-vt8500.c
> @@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
> divisor = parent_rate / rate;
>
> /* If prate / rate would be decimal, incr the divisor */
> - if (rate * divisor < *prate)
> + if (rate * divisor < parent_rate)
> divisor++;
>
> if (divisor == cdev->div_mask + 1)
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3.9-rc1] clk: vt8500: Fix variable name '*prate' compile error
2013-02-26 19:29 ` Mike Turquette
@ 2013-03-11 22:07 ` Arnd Bergmann
2013-03-17 21:01 ` Mike Turquette
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2013-03-11 22:07 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 26 February 2013, Mike Turquette wrote:
> Quoting Tim Gardner (2013-02-26 09:34:12)
> > commit 72480014b86c8b51fb51c5c6a0525876055c37c7 (clk: vt8500: Fix device clock
> > divisor calculations) introduced a compile error in the naming of a variable in
> > vt8500_dclk_set_rate(). It looks like a simple cut and paste error.
> >
> > Cc: Mike Turquette <mturquette@linaro.org>
> > Cc: linux-arm-kernel at lists.infradead.org
> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
>
> Tim,
>
> Thanks for the fix. I already have a fix for this issue in my clk-fixes
> branch. In fact I forgot to bundle this one and another mxs fix in my
> 3.9 pull request so I'll send a follow-up bugfix branch after 3.9-rc1 is
> out.
>
It seems this hasn't happened yet. I also don't see the patch in linux-next.
Is this patch still on your radar?
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3.9-rc1] clk: vt8500: Fix variable name '*prate' compile error
2013-03-11 22:07 ` Arnd Bergmann
@ 2013-03-17 21:01 ` Mike Turquette
2013-03-17 21:13 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Mike Turquette @ 2013-03-17 21:01 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Arnd Bergmann (2013-03-11 15:07:32)
> On Tuesday 26 February 2013, Mike Turquette wrote:
> > Quoting Tim Gardner (2013-02-26 09:34:12)
> > > commit 72480014b86c8b51fb51c5c6a0525876055c37c7 (clk: vt8500: Fix device clock
> > > divisor calculations) introduced a compile error in the naming of a variable in
> > > vt8500_dclk_set_rate(). It looks like a simple cut and paste error.
> > >
> > > Cc: Mike Turquette <mturquette@linaro.org>
> > > Cc: linux-arm-kernel at lists.infradead.org
> > > Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> >
> > Tim,
> >
> > Thanks for the fix. I already have a fix for this issue in my clk-fixes
> > branch. In fact I forgot to bundle this one and another mxs fix in my
> > 3.9 pull request so I'll send a follow-up bugfix branch after 3.9-rc1 is
> > out.
> >
>
> It seems this hasn't happened yet. I also don't see the patch in linux-next.
> Is this patch still on your radar?
>
Arnd,
Yes it is. I haven't pushed a new branch out since 3.9-rc1 due to LCE
and vacation after that. This fix and other pending patches will get
pulled in this week.
Regards,
Mike
> Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3.9-rc1] clk: vt8500: Fix variable name '*prate' compile error
2013-03-17 21:01 ` Mike Turquette
@ 2013-03-17 21:13 ` Arnd Bergmann
2013-03-17 23:35 ` Mike Turquette
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2013-03-17 21:13 UTC (permalink / raw)
To: linux-arm-kernel
On Sunday 17 March 2013, Mike Turquette wrote:
> Yes it is. I haven't pushed a new branch out since 3.9-rc1 due to LCE
> and vacation after that. This fix and other pending patches will get
> pulled in this week.
>
I've actually put it into the arm-soc bug fix queue now, since I did not
hear back from you and it never showed up in linux-next.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3.9-rc1] clk: vt8500: Fix variable name '*prate' compile error
2013-03-17 21:13 ` Arnd Bergmann
@ 2013-03-17 23:35 ` Mike Turquette
0 siblings, 0 replies; 6+ messages in thread
From: Mike Turquette @ 2013-03-17 23:35 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Arnd Bergmann (2013-03-17 14:13:08)
> On Sunday 17 March 2013, Mike Turquette wrote:
> > Yes it is. I haven't pushed a new branch out since 3.9-rc1 due to LCE
> > and vacation after that. This fix and other pending patches will get
> > pulled in this week.
> >
>
> I've actually put it into the arm-soc bug fix queue now, since I did not
> hear back from you and it never showed up in linux-next.
>
That is fine by me.
Thanks,
Mike
> Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-17 23:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-26 17:34 [PATCH 3.9-rc1] clk: vt8500: Fix variable name '*prate' compile error Tim Gardner
2013-02-26 19:29 ` Mike Turquette
2013-03-11 22:07 ` Arnd Bergmann
2013-03-17 21:01 ` Mike Turquette
2013-03-17 21:13 ` Arnd Bergmann
2013-03-17 23:35 ` Mike Turquette
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).