From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: let mxs specific clk-div clock type be a generic clock type
Date: Mon, 18 Mar 2013 11:34:05 +0100 [thread overview]
Message-ID: <20130318103405.GA20530@pengutronix.de> (raw)
In-Reply-To: <CAJuYYwQ9nALy5T9-3m2q46ifHmUuHTsXHTL2VDUOMMFAeB36vQ@mail.gmail.com>
Hello,
On Mon, Mar 18, 2013 at 03:48:24PM +0530, Thomas Abraham wrote:
> On 18 March 2013 14:12, Shawn Guo <shawn.guo@linaro.org> wrote:
> > On Sat, Mar 16, 2013 at 06:20:01PM +0530, Thomas Abraham wrote:
> >> The mxs platform specific clk-div clock is an extended version of the
> >> basic integer divider clock type that supports checking the stability
> >> status of the divider clock output. This type of clock is found on
> >> some of the Samsung platforms as well. So let the mxs specfic clk-div
> >> clock type be a generic clock type that all platforms can utilize.
> >>
> >> Cc: Shawn Guo <shawn.guo@linaro.org>
> >> Cc: Mike Turquette <mturquette@linaro.org>
> >> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
> >> ---
> >> drivers/clk/Makefile | 1 +
> >> drivers/clk/clk-divider-status.c | 119 ++++++++++++++++++++++++++++++++++++++
> >> drivers/clk/mxs/Makefile | 2 +-
> >> drivers/clk/mxs/clk-div.c | 110 -----------------------------------
> >> drivers/clk/mxs/clk.h | 12 +++-
> >> include/linux/clk-provider.h | 21 +++++++
> >> 6 files changed, 151 insertions(+), 114 deletions(-)
> >> create mode 100644 drivers/clk/clk-divider-status.c
> >> delete mode 100644 drivers/clk/mxs/clk-div.c
> >
> > From my quick testing, it seems working for mxs platform. But it's hard
> > to review the changes. Making it two steps might be helpful for
> > reviewer:
> >
> > 1) git mv drivers/clk/mxs/clk-div.c drivers/clk/clk-divider-status.c
> > 2) make changes on drivers/clk/clk-divider-status.c
>
> Thanks Shawn for your comments. I will split this patch as you
> suggested and post again.
I didn't try to look at your patch, but maybe format-patch -M is enough
to make the patch easier to parse (for humans).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2013-03-18 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 12:50 [PATCH] clk: let mxs specific clk-div clock type be a generic clock type Thomas Abraham
2013-03-18 8:42 ` Shawn Guo
2013-03-18 10:18 ` Thomas Abraham
2013-03-18 10:34 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130318103405.GA20530@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).