From: mfuzzey@parkeon.com (Martin Fuzzey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Sound: sgtl5000 Allow codec clock frequency to be set.
Date: Tue, 19 Mar 2013 18:03:22 +0100 [thread overview]
Message-ID: <20130319170322.27828.7691.stgit@localhost> (raw)
If both clocks and clock-frequency DT properties are given set
the clock frequency.
This is useful when a programmable clock is used as the codec clock.
Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com>
---
.../devicetree/bindings/sound/sgtl5000.txt | 14 ++++++++++++++
sound/soc/fsl/imx-sgtl5000.c | 20 ++++++++++++++++----
2 files changed, 30 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/sgtl5000.txt b/Documentation/devicetree/bindings/sound/sgtl5000.txt
index 9cc4444..31e82f0 100644
--- a/Documentation/devicetree/bindings/sound/sgtl5000.txt
+++ b/Documentation/devicetree/bindings/sound/sgtl5000.txt
@@ -5,9 +5,23 @@ Required properties:
- reg : the I2C address of the device
+Optional properties:
+- clocks: phandle to of codec clock
+- clock-frequency: clock frequency to set or use (see below)
+
+If a clock is provided, clock-frequency is optional
+
+If no clock is provided clock-frequency is required (this represents the codec
+being clocked by an external signal not present in the clock tree)
+
+If both a clock and clock-frequency are provided the clock's rate will be set.
+
+
Example:
codec: sgtl5000 at 0a {
compatible = "fsl,sgtl5000";
reg = <0x0a>;
+ clock-frequency = <20000000>;
+ clocks = <&clks 162>; /* cko1 */
};
diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c
index 424347e..71ce1f6 100644
--- a/sound/soc/fsl/imx-sgtl5000.c
+++ b/sound/soc/fsl/imx-sgtl5000.c
@@ -128,18 +128,30 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
goto fail;
}
+ ret = of_property_read_u32(codec_np, "clock-frequency",
+ &data->clk_frequency);
data->codec_clk = clk_get(&codec_dev->dev, NULL);
+
if (IS_ERR(data->codec_clk)) {
- /* assuming clock enabled by default */
+ /* assuming clock enabled by default (frequency required) */
data->codec_clk = NULL;
- ret = of_property_read_u32(codec_np, "clock-frequency",
- &data->clk_frequency);
- if (ret) {
+ if (!data->clk_frequency) {
dev_err(&codec_dev->dev,
"clock-frequency missing or invalid\n");
goto fail;
}
} else {
+ if (data->clk_frequency) {
+ ret = clk_set_rate(
+ data->codec_clk, data->clk_frequency);
+ if (ret) {
+ dev_err(&codec_dev->dev,
+ "failed to set clock-frequency to %u\n",
+ data->clk_frequency);
+ goto fail;
+ }
+ }
+
data->clk_frequency = clk_get_rate(data->codec_clk);
clk_prepare_enable(data->codec_clk);
}
next reply other threads:[~2013-03-19 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 17:03 Martin Fuzzey [this message]
2013-03-21 1:35 ` [PATCH] Sound: sgtl5000 Allow codec clock frequency to be set Timur Tabi
2013-03-21 8:39 ` Martin Fuzzey
2013-03-21 16:11 ` Timur Tabi
2013-03-21 17:46 ` Martin Fuzzey
2013-03-21 17:52 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319170322.27828.7691.stgit@localhost \
--to=mfuzzey@parkeon.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).