From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/3] clk: Improve errorhandling for clk_set_parent
Date: Thu, 21 Mar 2013 14:00:19 -0700 [thread overview]
Message-ID: <20130321210019.834.12024@quantum> (raw)
In-Reply-To: <1363873693-30902-3-git-send-email-ulf.hansson@stericsson.com>
Quoting Ulf Hansson (2013-03-21 06:48:12)
> @@ -1344,8 +1341,9 @@ out:
> int clk_set_parent(struct clk *clk, struct clk *parent)
> {
> int ret = 0;
> + u8 p_index;
>
> - if (!clk || !clk->ops)
> + if (!clk || !clk->ops || !parent)
> return -EINVAL;
>
A NULL clock is valid according to the clk.h api. I would like to allow
parent to be NULL, resulting in a migration from the real clock tree to
the orphans list.
This feature was apparently buggy for some time and Rajagopal sent me a
patch off-list to fix it. Rajagopal, can you post your patch publicly?
Thanks,
Mike
next prev parent reply other threads:[~2013-03-21 21:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 13:48 [PATCH V2 0/3] clk: Fixup issues for clk_set_parent Ulf Hansson
2013-03-21 13:48 ` [PATCH V2 1/3] clk: Restructure code for __clk_reparent Ulf Hansson
2013-03-21 20:53 ` Mike Turquette
2013-03-22 11:08 ` Ulf Hansson
2013-03-22 20:39 ` Mike Turquette
2013-03-21 13:48 ` [PATCH V2 2/3] clk: Improve errorhandling for clk_set_parent Ulf Hansson
2013-03-21 21:00 ` Mike Turquette [this message]
2013-03-22 9:59 ` Rajagopal Venkat
2013-03-22 20:41 ` Mike Turquette
2013-03-22 11:13 ` Ulf Hansson
2013-03-21 13:48 ` [PATCH V2 3/3] clk: Fixup locking issues " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321210019.834.12024@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox