From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] gpio: mvebu: add dbg_show function
Date: Sat, 23 Mar 2013 17:26:41 +0100 [thread overview]
Message-ID: <20130323172641.79ba1dfb@skate> (raw)
In-Reply-To: <20130323154317.GN4977@n2100.arm.linux.org.uk>
Russell,
On Sat, 23 Mar 2013 15:43:18 +0000, Russell King - ARM Linux wrote:
> I don't think this is a good idea - and it's wrong. test_bit() operates
> on an array of bits, and needs to be passed an unsigned long pointer.
> blink etc are "u32"s which aren't unsigned long.
>
> Moreover, what if ngpio becomes greater than 32 (for whatever reason)?
> test_bit(), when used correctly, will access the following word, which
> is probably a bad thing. The original won't have that behaviour,
> which is safer.
You're right, indeed.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-03-23 16:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 18:49 [PATCH 0/2] Add dbg_show functions to the Marvell GPIO drivers Simon Guinot
2013-03-22 18:49 ` [PATCH 1/2] gpio: mvebu: add dbg_show function Simon Guinot
2013-03-22 19:51 ` Jason Cooper
2013-03-23 15:21 ` Thomas Petazzoni
2013-03-23 15:29 ` Simon Guinot
2013-03-23 15:43 ` Russell King - ARM Linux
2013-03-23 16:26 ` Thomas Petazzoni [this message]
2013-03-22 18:49 ` [PATCH 2/2] ARM: Orion: add dbg_show function to gpio-orion driver Simon Guinot
2013-03-30 20:44 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130323172641.79ba1dfb@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).