From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/14] Marvell EBU thermal sensor consolidation
Date: Mon, 25 Mar 2013 07:45:14 -0300 [thread overview]
Message-ID: <20130325104513.GC2502@localhost> (raw)
In-Reply-To: <20130325093001.GH5627@lunn.ch>
On Mon, Mar 25, 2013 at 10:30:01AM +0100, Andrew Lunn wrote:
[...]
>
> What does all this mean? I _think_ there will be less and less shared
> code in future as these extra features are added.
>
Yes, I see your point. On the other side, I don't like the idea of
taking this decision based in the uncertain science of futurology :)
When will we add this extra features? Will we add them at all?
> I've not a strong opinion, but i think separate drivers are better.
>
Don't you think a single driver could make maintenance cheaper?
> If we do stick to one driver, i would however want #ifdef
> CONFIG_ARCH_DOVE, CONFIG_ARCH_KIRKWOOD, CONFIG_MACH_ARMADA_XP &
> CONFIG_MACH_ARMADA_370 scattered through the code.
>
Mmm... I'm not a fan for ifdefs. Actually, I really *hate* ifdefs.
I'll try to come up with an ifdef solution without making it too nasty.
Otherwise, perhaps I'll send a patch for Armada 370/XP only; I don't
want to push harder on something I'm not *absolutely* sure about either.
If we see there's an opportunity to merge the drivers, we can do always
do that later.
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-03-25 10:45 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 22:25 [PATCH v2 00/14] Marvell EBU thermal sensor consolidation Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 01/14] thermal: Rename driver 'kirkwood' -> 'mvebu' Ezequiel Garcia
2013-04-11 16:00 ` [v2,01/14] " Eduardo Valentin
2013-04-11 16:31 ` Ezequiel Garcia
2013-04-11 18:47 ` Eduardo Valentin
2013-04-11 18:57 ` Eduardo Valentin
2013-04-11 19:09 ` Ezequiel Garcia
2013-04-11 16:21 ` Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 02/14] thermal: mvebu: Rename symbols " Ezequiel Garcia
2013-04-11 16:18 ` [v2,02/14] " Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 03/14] thermal: mvebu: Move MODULE_DEVICE_TABLE upwards Ezequiel Garcia
2013-04-11 16:25 ` [v2,03/14] " Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 04/14] thermal: mvebu: Remove unneeded variable initialization Ezequiel Garcia
2013-04-11 16:29 ` [v2, " Eduardo Valentin
2013-04-11 18:54 ` Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 05/14] thermal: mvebu: Convert to devm_ioremap_resource() Ezequiel Garcia
2013-04-11 16:35 ` [v2,05/14] " Eduardo Valentin
2013-04-11 18:55 ` Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 06/14] thermal: mvebu: Fix license declaration Ezequiel Garcia
2013-04-11 16:40 ` [v2,06/14] " Eduardo Valentin
2013-04-11 18:55 ` Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 07/14] thermal: mvebu: Rename kirkwood definitions to mvebu Ezequiel Garcia
2013-04-11 16:43 ` [v2,07/14] " Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 08/14] thermal: mvebu: Add infrastructure to support more multiple SoC variants Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 09/14] thermal: mvebu: Add support for Armada XP thermal sensor Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 10/14] thermal: mvebu: Add support for Armada 370 " Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 11/14] thermal: mvebu: Add support for Marvell Dove SoC family Ezequiel Garcia
2013-03-23 11:26 ` Sebastian Hesselbarth
2013-03-24 0:16 ` Ezequiel Garcia
2013-03-25 9:34 ` Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 12/14] ARM: mvebu: Add thermal support to Armada XP device tree Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 13/14] ARM: mvebu: Add thermal support to Armada 370 " Ezequiel Garcia
2013-03-23 14:18 ` Sergei Shtylyov
2013-03-23 14:20 ` Sergei Shtylyov
2013-03-23 14:25 ` Sergei Shtylyov
2013-03-24 0:22 ` Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 14/14] ARM: configs: Update mvebu, dove and kirkwood defconfigs for thermal Ezequiel Garcia
2013-03-23 18:16 ` [PATCH v2 00/14] Marvell EBU thermal sensor consolidation Jason Cooper
2013-03-23 18:28 ` Sebastian Hesselbarth
2013-03-23 18:31 ` Jason Cooper
2013-03-23 18:38 ` Sebastian Hesselbarth
2013-03-25 9:30 ` Andrew Lunn
2013-03-25 10:45 ` Ezequiel Garcia [this message]
2013-03-25 12:23 ` Sebastian Hesselbarth
2013-03-25 12:39 ` Ezequiel Garcia
2013-03-25 13:58 ` Sebastian Hesselbarth
2013-03-25 16:29 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325104513.GC2502@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).