From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: tegra: Don't enable PLLs during early boot
Date: Mon, 25 Mar 2013 11:02:36 +0000 [thread overview]
Message-ID: <20130325110236.GP4977@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <514C7D3B.40602@wwwdotorg.org>
On Fri, Mar 22, 2013 at 09:48:11AM -0600, Stephen Warren wrote:
> This assumption was made long ago. I know drivers are supposed to assume
> that clocks are disabled when they're probed, but historically that
> wasn't always the case, so if the audio drivers assumed that, and then
> did clk_enable() as the first thing, they got a warning due to the
> enabling an already enabled clock and/or later attempts to disable the
> clocks wouldn't actually disable them.
No. clocks have always been able to be enabled multiple times. You
should only get a warning if you try and disable it more times than you
enabled it, because that's a violation of the API.
Consider two drivers sharing the same input clock. If one driver
disables the clock more times than it enables it, then it's treading
on the other drivers need to have the clock enabled.
next prev parent reply other threads:[~2013-03-25 11:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 11:54 [PATCH] clk: tegra: Don't enable PLLs during early boot Peter De Schrijver
2013-03-22 15:48 ` Stephen Warren
2013-03-25 10:15 ` Peter De Schrijver
2013-03-25 11:14 ` Prashant Gaikwad
2013-03-25 17:32 ` Stephen Warren
2013-03-25 11:02 ` Russell King - ARM Linux [this message]
2013-03-25 16:12 ` Stephen Warren
-- strict thread matches above, loose matches on Subject: below --
2013-03-22 12:02 Peter De Schrijver
2013-03-22 12:09 ` Peter De Schrijver
2013-03-22 12:06 Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325110236.GP4977@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).