From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 12/17] ARM: mach-imx: tzic: Staticize *tzic_base
Date: Mon, 25 Mar 2013 14:45:50 +0100 [thread overview]
Message-ID: <20130325134550.GF1906@pengutronix.de> (raw)
In-Reply-To: <1364214044-13950-12-git-send-email-fabio.estevam@freescale.com>
On Mon, Mar 25, 2013 at 09:20:39AM -0300, Fabio Estevam wrote:
> Fix the following sparse warning:
>
> arch/arm/mach-imx/tzic.c:52:14: warning: symbol 'tzic_base' was not declared. Should it be static?
>
> Also, reduce the comment in order to fit into 80 characters.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/mach-imx/tzic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/tzic.c b/arch/arm/mach-imx/tzic.c
> index 9721161..1488a4a 100644
> --- a/arch/arm/mach-imx/tzic.c
> +++ b/arch/arm/mach-imx/tzic.c
> @@ -49,7 +49,7 @@
> #define TZIC_SWINT 0x0F00 /* Software Interrupt Rigger Register */
> #define TZIC_ID0 0x0FD0 /* Indentification Register 0 */
>
> -void __iomem *tzic_base; /* Used as irq controller base in entry-macro.S */
> +static void __iomem *tzic_base; /* irq controller base in entry-macro.S */
The comment is wrong since Linux v3.2, you should remove it.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-03-25 13:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 12:20 [PATCH 1/17] ARM: mach-imx: cpu: Include "common.h" Fabio Estevam
2013-03-25 12:20 ` [PATCH 2/17] ARM: mach-imx: mm-imx3: Staticize imx3_init_l2x0() Fabio Estevam
2013-03-25 12:20 ` [PATCH 3/17] ARM: mach-imx: iomux-imx31: Staticize mxc_pin_alloc_map Fabio Estevam
2013-03-25 12:20 ` [PATCH 4/17] ARM: mach-imx: cpu-imx5: Include "common.h" Fabio Estevam
2013-03-25 12:20 ` [PATCH 5/17] ARM: mach-imx: cpu_op-mx51: Include "cpu_op-mx51.h" Fabio Estevam
2013-03-25 12:20 ` [PATCH 6/17] ARM: mach-imx: clk-pllv1: Staticize clk_pllv1_ops Fabio Estevam
2013-03-25 12:20 ` [PATCH 7/17] ARM: mach-imx: clk-pllv2: Staticize clk_pllv2_ops Fabio Estevam
2013-03-25 12:20 ` [PATCH 8/17] ARM: mach-imx: clk-gate2: Include "clk.h" Fabio Estevam
2013-03-25 12:20 ` [PATCH 9/17] ARM: mach-imx: irq-common: Remove imx_irq_set_priority() Fabio Estevam
2013-03-25 12:20 ` [PATCH 10/17] ARM: mach-imx: clk-busy: Staticize clk_busy_mux_ops Fabio Estevam
2013-03-25 12:20 ` [PATCH 11/17] ARM: mach-imx: clk: Include "clk.h" Fabio Estevam
2013-03-25 12:20 ` [PATCH 12/17] ARM: mach-imx: tzic: Staticize *tzic_base Fabio Estevam
2013-03-25 13:45 ` Sascha Hauer [this message]
2013-03-25 12:20 ` [PATCH 13/17] ARM: mach-imx: avic: Staticize *avic_base Fabio Estevam
2013-03-25 12:20 ` [PATCH 14/17] ARM: mach-imx: anatop: Include "common.h" Fabio Estevam
2013-03-25 12:20 ` [PATCH 15/17] ARM: mach-imx: gpc: " Fabio Estevam
2013-03-25 12:20 ` [PATCH 16/17] ARM: mach-imx: src: Include "common.h Fabio Estevam
2013-03-25 12:20 ` [PATCH 17/17] ARM: mach-imx: mach-imx6q: Fix sparse warnings Fabio Estevam
2013-03-26 5:33 ` [PATCH 1/17] ARM: mach-imx: cpu: Include "common.h" Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325134550.GF1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).