From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] clk: allow reentrant calls into the clk framework
Date: Wed, 27 Mar 2013 01:38:40 -0700 [thread overview]
Message-ID: <20130327083840.4014.41560@quantum> (raw)
In-Reply-To: <1364355211.22943.8.camel@bilhuang-vm1>
Quoting Bill Huang (2013-03-26 20:33:31)
> On Thu, 2013-02-28 at 12:49 +0800, Mike Turquette wrote:
> > Reentrancy into the clock framework from the clk.h api is highly
> > desirable. This feature is necessary for clocks that are prepared and
> > unprepared via i2c_transfer (which includes many PMICs and discrete
> > audio chips) and it is also necessary for performing dynamic voltage &
> > frequency scaling via clock rate-change notifiers.
> >
> > This patch implements reentrancy by adding a global atomic_t which
> > tracks the context of the current caller. Context in this case is the
> > return value from get_current(). The clk.h api implementations are
> > modified to first see if the relevant global lock is already held and if
> > so compare the global context (set by whoever is holding the lock)
> > against their own context (via a call to get_current()). If the two
> > match then this function is a nested call from the one already holding
> > the lock and we procede. If the context does not match then procede to
> > call mutex_lock and busy-wait for the existing task to complete.
> >
> > Thus this patch set does not increase concurrency for unrelated calls
> > into the clock framework. Instead it simply allows reentrancy by the
> > single task which is currently holding the global clock framework lock.
> >
> > Thanks to Rajagoapl Venkat for the original idea to use get_current()
> > and to David Brown for the suggestion to replace my previous rwlock
> > scheme with atomic operations during code review at ELC 2013.
> >
> > Signed-off-by: Mike Turquette <mturquette@linaro.org>
> > Cc: Rajagopal Venkat <rajagopal.venkat@linaro.org>
> > Cc: David Brown <davidb@codeaurora.org>
> > ---
> Hi Mike,
>
> Will this single patch be accepted? I guess you might not merge the
> whole series but I think this one is useful, is it possible that you can
> send out this single patch (or just merge this one) as an improvement of
> CCF? Or you think otherwise?
>
Bill,
Yes, I plan to merge this single patch for 3.10 and have posted a new
version fixing the issue pointed out by Ulf. Please leave any review
comments you have.
Thanks,
Mike
> Thanks,
> Bill
next prev parent reply other threads:[~2013-03-27 8:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 4:49 [PATCH v3 0/5] common clk framework reentrancy & dvfs, take 3 Mike Turquette
2013-02-28 4:49 ` [PATCH 1/5] clk: allow reentrant calls into the clk framework Mike Turquette
2013-02-28 9:54 ` Ulf Hansson
2013-03-18 20:15 ` Mike Turquette
2013-03-18 21:00 ` Russell King - ARM Linux
2013-03-18 21:35 ` Mike Turquette
2013-03-27 3:33 ` Bill Huang
2013-03-27 8:38 ` Mike Turquette [this message]
2013-02-28 4:49 ` [PATCH 2/5] clk: notifier handler for dynamic voltage scaling Mike Turquette
2013-03-01 9:41 ` Bill Huang
2013-03-01 18:22 ` Mike Turquette
2013-03-01 20:48 ` Mike Turquette
2013-03-02 2:55 ` Bill Huang
2013-03-02 8:22 ` Richard Zhao
2013-03-03 10:54 ` Mike Turquette
2013-03-03 13:27 ` Richard Zhao
2013-03-04 7:25 ` Mike Turquette
2013-03-13 13:59 ` Ulf Hansson
2013-03-01 20:49 ` Stephen Warren
2013-03-02 2:58 ` Bill Huang
2013-03-10 10:21 ` Francesco Lavra
2013-04-02 17:49 ` Taras Kondratiuk
2013-02-28 4:49 ` [PATCH 3/5] cpufreq: omap: scale regulator from clk notifier Mike Turquette
2013-02-28 4:49 ` [PATCH 4/5] HACK: set_parent callback for OMAP4 non-core DPLLs Mike Turquette
2013-02-28 4:49 ` [PATCH 5/5] HACK: omap: opp: add fake 400MHz OPP to bypass MPU Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327083840.4014.41560@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox