[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Michael Grzeschik]

Nearly every SoC from Freescale has this non-core usb registers. This series
adds support for more users of this driver.

This series is based on Peter Chen's work. Its needed to merge his master branch
before applying this series:

https://github.com/hzpeterchen/linux-usb.git

Changes since v3:
* removed [PATCH v3 5/7] usb: chipidea: usbmisc: add support for ahb, ipg and per clock


Marc Kleine-Budde (3):
  usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove
  usb: chipidea: usbmisc: fix a potential race condition
  usb: chipidea: usbmisc: prepare driver to handle more than one soc

Michael Grzeschik (3):
  usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx
  usb: chipidea: usbmisc: add mx53 support
  usb: chipidea: usbmisc: add post handling and errata fix for mx25

 .../devicetree/bindings/usb/ci13xxx-imx.txt        |    2 +
 drivers/usb/chipidea/Makefile                      |    2 +-
 drivers/usb/chipidea/ci13xxx_imx.c                 |   12 +
 drivers/usb/chipidea/ci13xxx_imx.h                 |    3 +
 drivers/usb/chipidea/usbmisc_imx.c                 |  252 ++++++++++++++++++++
 drivers/usb/chipidea/usbmisc_imx6q.c               |  162 -------------
 6 files changed, 270 insertions(+), 163 deletions(-)
 create mode 100644 drivers/usb/chipidea/usbmisc_imx.c
 delete mode 100644 drivers/usb/chipidea/usbmisc_imx6q.c

-- 
1.7.10.4

[PATCH v4 1/6] usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx

[Michael Grzeschik]

This driver will be used for every Freescale SoC which has this misc
memory layout to control the basic usb handling. So better name this
driver, function and struct names in a more generic way.

Reported-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
Changes since v1:
* added Makefile change to be build as well
* moved this patch infront all other

 drivers/usb/chipidea/Makefile                      |    2 +-
 .../chipidea/{usbmisc_imx6q.c => usbmisc_imx.c}    |   38 ++++++++++----------
 2 files changed, 20 insertions(+), 20 deletions(-)
 rename drivers/usb/chipidea/{usbmisc_imx6q.c => usbmisc_imx.c} (75%)

diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile
index 11f513c..146ecd7 100644
--- a/drivers/usb/chipidea/Makefile
+++ b/drivers/usb/chipidea/Makefile
@@ -17,5 +17,5 @@ ifneq ($(CONFIG_PCI),)
 endif
 
 ifneq ($(CONFIG_OF_DEVICE),)
-	obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_imx.o usbmisc_imx6q.o
+	obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_imx.o usbmisc_imx.o
 endif
diff --git a/drivers/usb/chipidea/usbmisc_imx6q.c b/drivers/usb/chipidea/usbmisc_imx.c
similarity index 75%
rename from drivers/usb/chipidea/usbmisc_imx6q.c
rename to drivers/usb/chipidea/usbmisc_imx.c
index 416e3fc..5da379a 100644
--- a/drivers/usb/chipidea/usbmisc_imx6q.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
@@ -21,14 +21,14 @@
 
 #define BM_OVER_CUR_DIS		BIT(7)
 
-struct imx6q_usbmisc {
+struct imx_usbmisc {
 	void __iomem *base;
 	spinlock_t lock;
 	struct clk *clk;
 	struct usbmisc_usb_device usbdev[USB_DEV_MAX];
 };
 
-static struct imx6q_usbmisc *usbmisc;
+static struct imx_usbmisc *usbmisc;
 
 static struct usbmisc_usb_device *get_usbdev(struct device *dev)
 {
@@ -77,15 +77,15 @@ static const struct usbmisc_ops imx6q_usbmisc_ops = {
 	.init = usbmisc_imx6q_init,
 };
 
-static const struct of_device_id usbmisc_imx6q_dt_ids[] = {
+static const struct of_device_id usbmisc_imx_dt_ids[] = {
 	{ .compatible = "fsl,imx6q-usbmisc"},
 	{ /* sentinel */ }
 };
 
-static int __devinit usbmisc_imx6q_probe(struct platform_device *pdev)
+static int __devinit usbmisc_imx_probe(struct platform_device *pdev)
 {
 	struct resource	*res;
-	struct imx6q_usbmisc *data;
+	struct imx_usbmisc *data;
 	int ret;
 
 	if (usbmisc)
@@ -127,36 +127,36 @@ static int __devinit usbmisc_imx6q_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int __devexit usbmisc_imx6q_remove(struct platform_device *pdev)
+static int __devexit usbmisc_imx_remove(struct platform_device *pdev)
 {
 	usbmisc_unset_ops(&imx6q_usbmisc_ops);
 	clk_disable_unprepare(usbmisc->clk);
 	return 0;
 }
 
-static struct platform_driver usbmisc_imx6q_driver = {
-	.probe = usbmisc_imx6q_probe,
-	.remove = __devexit_p(usbmisc_imx6q_remove),
+static struct platform_driver usbmisc_imx_driver = {
+	.probe = usbmisc_imx_probe,
+	.remove = __devexit_p(usbmisc_imx_remove),
 	.driver = {
-		.name = "usbmisc_imx6q",
+		.name = "usbmisc_imx",
 		.owner = THIS_MODULE,
-		.of_match_table = usbmisc_imx6q_dt_ids,
+		.of_match_table = usbmisc_imx_dt_ids,
 	 },
 };
 
-int __init usbmisc_imx6q_drv_init(void)
+int __init usbmisc_imx_drv_init(void)
 {
-	return platform_driver_register(&usbmisc_imx6q_driver);
+	return platform_driver_register(&usbmisc_imx_driver);
 }
-subsys_initcall(usbmisc_imx6q_drv_init);
+subsys_initcall(usbmisc_imx_drv_init);
 
-void __exit usbmisc_imx6q_drv_exit(void)
+void __exit usbmisc_imx_drv_exit(void)
 {
-	platform_driver_unregister(&usbmisc_imx6q_driver);
+	platform_driver_unregister(&usbmisc_imx_driver);
 }
-module_exit(usbmisc_imx6q_drv_exit);
+module_exit(usbmisc_imx_drv_exit);
 
-MODULE_ALIAS("platform:usbmisc-imx6q");
+MODULE_ALIAS("platform:usbmisc-imx");
 MODULE_LICENSE("GPL v2");
-MODULE_DESCRIPTION("driver for imx6q usb non-core registers");
+MODULE_DESCRIPTION("driver for imx usb non-core registers");
 MODULE_AUTHOR("Richard Zhao <richard.zhao@freescale.com>");
-- 
1.7.10.4

[PATCH v4 2/6] usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove

[Michael Grzeschik]

From: Marc Kleine-Budde <mkl@pengutronix.de>

The probe function checks usbmisc to be NULL in the beginning. Without
this patch the can only be loaded once.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
Changes since v1:
* split previous patch into two seperate.

 drivers/usb/chipidea/usbmisc_imx.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
index 5da379a..552c63f 100644
--- a/drivers/usb/chipidea/usbmisc_imx.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
@@ -131,6 +131,7 @@ static int __devexit usbmisc_imx_remove(struct platform_device *pdev)
 {
 	usbmisc_unset_ops(&imx6q_usbmisc_ops);
 	clk_disable_unprepare(usbmisc->clk);
+	usbmisc = NULL;
 	return 0;
 }
 
-- 
1.7.10.4

[PATCH v4 3/6] usb: chipidea: usbmisc: fix a potential race condition

[Michael Grzeschik]

From: Marc Kleine-Budde <mkl@pengutronix.de>

This fixes a potential race condition where the ci13xxx_imx glue code
could be fast enough to call one of the usbmisc_ops before he got a
valid value on the static usbmisc pointer. To fix that we first set
usbmisc, then call usbmisc_set_ops().

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
Changes since v1:
* split previous patch into two seperate.

 drivers/usb/chipidea/usbmisc_imx.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
index 552c63f..9145e04 100644
--- a/drivers/usb/chipidea/usbmisc_imx.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
@@ -116,14 +116,14 @@ static int __devinit usbmisc_imx_probe(struct platform_device *pdev)
 		return ret;
 	}
 
+	usbmisc = data;
 	ret = usbmisc_set_ops(&imx6q_usbmisc_ops);
 	if (ret) {
+		usbmisc = NULL;
 		clk_disable_unprepare(data->clk);
 		return ret;
 	}
 
-	usbmisc = data;
-
 	return 0;
 }
 
-- 
1.7.10.4

[PATCH v4 4/6] usb: chipidea: usbmisc: prepare driver to handle more than one soc

[Michael Grzeschik]

From: Marc Kleine-Budde <mkl@pengutronix.de>

This attaches the usbmisc_ops to the of_device_id data and
makes it possible to define special functions per soc.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
Changes since v2:
* renamed bitmask to reflect soctype mx6

 drivers/usb/chipidea/usbmisc_imx.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
index 9145e04..d0c7a03 100644
--- a/drivers/usb/chipidea/usbmisc_imx.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
@@ -19,13 +19,14 @@
 
 #define USB_DEV_MAX 4
 
-#define BM_OVER_CUR_DIS		BIT(7)
+#define MX6_BM_OVER_CUR_DIS		BIT(7)
 
 struct imx_usbmisc {
 	void __iomem *base;
 	spinlock_t lock;
 	struct clk *clk;
 	struct usbmisc_usb_device usbdev[USB_DEV_MAX];
+	const struct usbmisc_ops *ops;
 };
 
 static struct imx_usbmisc *usbmisc;
@@ -65,7 +66,7 @@ static int usbmisc_imx6q_init(struct device *dev)
 	if (usbdev->disable_oc) {
 		spin_lock_irqsave(&usbmisc->lock, flags);
 		reg = readl(usbmisc->base + usbdev->index * 4);
-		writel(reg | BM_OVER_CUR_DIS,
+		writel(reg | MX6_BM_OVER_CUR_DIS,
 			usbmisc->base + usbdev->index * 4);
 		spin_unlock_irqrestore(&usbmisc->lock, flags);
 	}
@@ -78,7 +79,7 @@ static const struct usbmisc_ops imx6q_usbmisc_ops = {
 };
 
 static const struct of_device_id usbmisc_imx_dt_ids[] = {
-	{ .compatible = "fsl,imx6q-usbmisc"},
+	{ .compatible = "fsl,imx6q-usbmisc", .data = (void *)&imx6q_usbmisc_ops },
 	{ /* sentinel */ }
 };
 
@@ -87,6 +88,7 @@ static int __devinit usbmisc_imx_probe(struct platform_device *pdev)
 	struct resource	*res;
 	struct imx_usbmisc *data;
 	int ret;
+	struct of_device_id *tmp_dev;
 
 	if (usbmisc)
 		return -EBUSY;
@@ -116,8 +118,11 @@ static int __devinit usbmisc_imx_probe(struct platform_device *pdev)
 		return ret;
 	}
 
+	tmp_dev = (struct of_device_id *)
+		of_match_device(usbmisc_imx_dt_ids, &pdev->dev);
+	data->ops = (const struct usbmisc_ops *)tmp_dev->data;
 	usbmisc = data;
-	ret = usbmisc_set_ops(&imx6q_usbmisc_ops);
+	ret = usbmisc_set_ops(data->ops);
 	if (ret) {
 		usbmisc = NULL;
 		clk_disable_unprepare(data->clk);
@@ -129,7 +134,7 @@ static int __devinit usbmisc_imx_probe(struct platform_device *pdev)
 
 static int __devexit usbmisc_imx_remove(struct platform_device *pdev)
 {
-	usbmisc_unset_ops(&imx6q_usbmisc_ops);
+	usbmisc_unset_ops(usbmisc->ops);
 	clk_disable_unprepare(usbmisc->clk);
 	usbmisc = NULL;
 	return 0;
-- 
1.7.10.4

[PATCH v4 5/6] usb: chipidea: usbmisc: add mx53 support

[Michael Grzeschik]

This adds mx53 as the next user of the usbmisc driver and makes it
possible to disable the overcurrent-detection of the internal phy.

Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
Changes since v2:
* added defines for register offsets and bitmasks
* fixed disable_oc option for all ports

Changes since v3:
* removed spare semicolons at end of defines

 drivers/usb/chipidea/usbmisc_imx.c |   51 ++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
index d0c7a03..69a49e5 100644
--- a/drivers/usb/chipidea/usbmisc_imx.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
@@ -19,6 +19,13 @@
 
 #define USB_DEV_MAX 4
 
+#define MX53_USB_OTG_PHY_CTRL_0_OFFSET	0x08
+#define MX53_USB_UH2_CTRL_OFFSET	0x14
+#define MX53_USB_UH3_CTRL_OFFSET	0x18
+#define MX53_BM_OVER_CUR_DIS_H1		BIT(5)
+#define MX53_BM_OVER_CUR_DIS_OTG	BIT(8)
+#define MX53_BM_OVER_CUR_DIS_UHx	BIT(30)
+
 #define MX6_BM_OVER_CUR_DIS		BIT(7)
 
 struct imx_usbmisc {
@@ -52,6 +59,45 @@ static struct usbmisc_usb_device *get_usbdev(struct device *dev)
 	return &usbmisc->usbdev[i];
 }
 
+static int usbmisc_imx53_init(struct device *dev)
+{
+	struct usbmisc_usb_device *usbdev;
+	void __iomem *reg = NULL;
+	unsigned long flags;
+	u32 val = 0;
+
+	usbdev = get_usbdev(dev);
+	if (IS_ERR(usbdev))
+		return PTR_ERR(usbdev);
+
+	if (usbdev->disable_oc) {
+		spin_lock_irqsave(&usbmisc->lock, flags);
+		switch (usbdev->index) {
+		case 0:
+			reg = usbmisc->base + MX53_USB_OTG_PHY_CTRL_0_OFFSET;
+			val = readl(reg) | MX53_BM_OVER_CUR_DIS_OTG;
+			break;
+		case 1:
+			reg = usbmisc->base + MX53_USB_OTG_PHY_CTRL_0_OFFSET;
+			val = readl(reg) | MX53_BM_OVER_CUR_DIS_H1;
+			break;
+		case 2:
+			reg = usbmisc->base + MX53_USB_UH2_CTRL_OFFSET;
+			val = readl(reg) | MX53_BM_OVER_CUR_DIS_UHx;
+			break;
+		case 3:
+			reg = usbmisc->base + MX53_USB_UH3_CTRL_OFFSET;
+			val = readl(reg) | MX53_BM_OVER_CUR_DIS_UHx;
+			break;
+		}
+		if (reg && val)
+			writel(val, reg);
+		spin_unlock_irqrestore(&usbmisc->lock, flags);
+	}
+
+	return 0;
+}
+
 static int usbmisc_imx6q_init(struct device *dev)
 {
 
@@ -74,11 +120,16 @@ static int usbmisc_imx6q_init(struct device *dev)
 	return 0;
 }
 
+static const struct usbmisc_ops imx53_usbmisc_ops = {
+	.init = usbmisc_imx53_init,
+};
+
 static const struct usbmisc_ops imx6q_usbmisc_ops = {
 	.init = usbmisc_imx6q_init,
 };
 
 static const struct of_device_id usbmisc_imx_dt_ids[] = {
+	{ .compatible = "fsl,imx53-usbmisc", .data = (void *)&imx53_usbmisc_ops },
 	{ .compatible = "fsl,imx6q-usbmisc", .data = (void *)&imx6q_usbmisc_ops },
 	{ /* sentinel */ }
 };
-- 
1.7.10.4

[PATCH v4 6/6] usb: chipidea: usbmisc: add post handling and errata fix for mx25

[Michael Grzeschik]

This adds a post handling routine which is called after
ci13xxx_add_device was called. The first user is the mx25, which has to
disable the external-vbus-divider after the udc has started.

Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
Changes since v3:
* fixed patch description typos
* used usleep_range instead of mdelay

 .../devicetree/bindings/usb/ci13xxx-imx.txt        |    2 ++
 drivers/usb/chipidea/ci13xxx_imx.c                 |   12 +++++++
 drivers/usb/chipidea/ci13xxx_imx.h                 |    3 ++
 drivers/usb/chipidea/usbmisc_imx.c                 |   33 ++++++++++++++++++++
 4 files changed, 50 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt b/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt
index 5778b9c..1c04a4c 100644
--- a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt
+++ b/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt
@@ -11,6 +11,7 @@ Optional properties:
   that indicate usb controller index
 - vbus-supply: regulator for vbus
 - disable-over-current: disable over current detect
+- external-vbus-divider: enables off-chip resistor divider for Vbus
 
 Examples:
 usb at 02184000 { /* USB OTG */
@@ -20,4 +21,5 @@ usb at 02184000 { /* USB OTG */
 	fsl,usbphy = <&usbphy1>;
 	fsl,usbmisc = <&usbmisc 0>;
 	disable-over-current;
+	external-vbus-divider;
 };
diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea/ci13xxx_imx.c
index 935de97..d346c99 100644
--- a/drivers/usb/chipidea/ci13xxx_imx.c
+++ b/drivers/usb/chipidea/ci13xxx_imx.c
@@ -79,6 +79,9 @@ int usbmisc_get_init_data(struct device *dev, struct usbmisc_usb_device *usbdev)
 	if (of_find_property(np, "disable-over-current", NULL))
 		usbdev->disable_oc = 1;
 
+	if (of_find_property(np, "external-vbus-divider", NULL))
+		usbdev->evdo = 1;
+
 	return 0;
 }
 EXPORT_SYMBOL_GPL(usbmisc_get_init_data);
@@ -213,6 +216,15 @@ static int __devinit ci13xxx_imx_probe(struct platform_device *pdev)
 		goto put_np;
 	}
 
+	if (usbmisc_ops && usbmisc_ops->post) {
+		ret = usbmisc_ops->post(&pdev->dev);
+		if (ret) {
+			dev_err(&pdev->dev,
+				"usbmisc post failed, ret=%d\n", ret);
+			goto put_np;
+		}
+	}
+
 	data->ci_pdev = plat_ci;
 	platform_set_drvdata(pdev, data);
 
diff --git a/drivers/usb/chipidea/ci13xxx_imx.h b/drivers/usb/chipidea/ci13xxx_imx.h
index 2e88acc..d065273 100644
--- a/drivers/usb/chipidea/ci13xxx_imx.h
+++ b/drivers/usb/chipidea/ci13xxx_imx.h
@@ -13,6 +13,8 @@
 struct usbmisc_ops {
 	/* It's called once when probe a usb device */
 	int (*init)(struct device *dev);
+	/* It's called once after adding a usb device */
+	int (*post)(struct device *dev);
 };
 
 struct usbmisc_usb_device {
@@ -20,6 +22,7 @@ struct usbmisc_usb_device {
 	int index;
 
 	int disable_oc:1; /* over current detect disabled */
+	int evdo:1; /* set external vbus divider option */
 };
 
 int usbmisc_set_ops(const struct usbmisc_ops *ops);
diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
index 69a49e5..44b3a7d 100644
--- a/drivers/usb/chipidea/usbmisc_imx.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
@@ -14,11 +14,15 @@
 #include <linux/clk.h>
 #include <linux/err.h>
 #include <linux/io.h>
+#include <linux/delay.h>
 
 #include "ci13xxx_imx.h"
 
 #define USB_DEV_MAX 4
 
+#define MX25_USB_PHY_CTRL_OFFSET	0x08
+#define MX25_BM_EXTERNAL_VBUS_DIVIDER	BIT(23)
+
 #define MX53_USB_OTG_PHY_CTRL_0_OFFSET	0x08
 #define MX53_USB_UH2_CTRL_OFFSET	0x14
 #define MX53_USB_UH3_CTRL_OFFSET	0x18
@@ -59,6 +63,30 @@ static struct usbmisc_usb_device *get_usbdev(struct device *dev)
 	return &usbmisc->usbdev[i];
 }
 
+static int usbmisc_imx25_post(struct device *dev)
+{
+	struct usbmisc_usb_device *usbdev;
+	void __iomem *reg;
+	unsigned long flags;
+	u32 val;
+
+	usbdev = get_usbdev(dev);
+	if (IS_ERR(usbdev))
+		return PTR_ERR(usbdev);
+
+	reg = usbmisc->base + MX25_USB_PHY_CTRL_OFFSET;
+
+	if (usbdev->evdo) {
+		spin_lock_irqsave(&usbmisc->lock, flags);
+		val = readl(reg);
+		writel(val | MX25_BM_EXTERNAL_VBUS_DIVIDER, reg);
+		spin_unlock_irqrestore(&usbmisc->lock, flags);
+		usleep_range(5000,10000); /* needed to stabilize voltage */
+	}
+
+	return 0;
+}
+
 static int usbmisc_imx53_init(struct device *dev)
 {
 	struct usbmisc_usb_device *usbdev;
@@ -120,6 +148,10 @@ static int usbmisc_imx6q_init(struct device *dev)
 	return 0;
 }
 
+static const struct usbmisc_ops imx25_usbmisc_ops = {
+	.post = usbmisc_imx25_post,
+};
+
 static const struct usbmisc_ops imx53_usbmisc_ops = {
 	.init = usbmisc_imx53_init,
 };
@@ -129,6 +161,7 @@ static const struct usbmisc_ops imx6q_usbmisc_ops = {
 };
 
 static const struct of_device_id usbmisc_imx_dt_ids[] = {
+	{ .compatible = "fsl,imx25-usbmisc", .data = (void *)&imx25_usbmisc_ops },
 	{ .compatible = "fsl,imx53-usbmisc", .data = (void *)&imx53_usbmisc_ops },
 	{ .compatible = "fsl,imx6q-usbmisc", .data = (void *)&imx6q_usbmisc_ops },
 	{ /* sentinel */ }
-- 
1.7.10.4

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Peter Chen]

On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote:
> Nearly every SoC from Freescale has this non-core usb registers. This series
> adds support for more users of this driver.
> 
> This series is based on Peter Chen's work. Its needed to merge his master branch
> before applying this series:
> 
> https://github.com/hzpeterchen/linux-usb.git

I have tested it at i.mx6q sabrelite board, it works good.

I have pushed your commit to my git, please cc me
your coming chipidea patches, thanks.

Alex, please add:

Reviewed-by: Peter Chen <peter.chen@freescale.com>
Tested-by: Peter Chen <peter.chen@freescale.com>


> 
> Changes since v3:
> * removed [PATCH v3 5/7] usb: chipidea: usbmisc: add support for ahb, ipg and per clock
> 
> 
> Marc Kleine-Budde (3):
>   usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove
>   usb: chipidea: usbmisc: fix a potential race condition
>   usb: chipidea: usbmisc: prepare driver to handle more than one soc
> 
> Michael Grzeschik (3):
>   usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx
>   usb: chipidea: usbmisc: add mx53 support
>   usb: chipidea: usbmisc: add post handling and errata fix for mx25
> 
>  .../devicetree/bindings/usb/ci13xxx-imx.txt        |    2 +
>  drivers/usb/chipidea/Makefile                      |    2 +-
>  drivers/usb/chipidea/ci13xxx_imx.c                 |   12 +
>  drivers/usb/chipidea/ci13xxx_imx.h                 |    3 +
>  drivers/usb/chipidea/usbmisc_imx.c                 |  252 ++++++++++++++++++++
>  drivers/usb/chipidea/usbmisc_imx6q.c               |  162 -------------
>  6 files changed, 270 insertions(+), 163 deletions(-)
>  create mode 100644 drivers/usb/chipidea/usbmisc_imx.c
>  delete mode 100644 drivers/usb/chipidea/usbmisc_imx6q.c
> 
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 

Best Regards,
Peter Chen

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Fabio Estevam]

Hi Alexander,

On Wed, Nov 28, 2012 at 12:52 AM, Peter Chen <peter.chen@freescale.com> wrote:

> I have tested it at i.mx6q sabrelite board, it works good.
>
> I have pushed your commit to my git, please cc me
> your coming chipidea patches, thanks.
>
> Alex, please add:
>
> Reviewed-by: Peter Chen <peter.chen@freescale.com>
> Tested-by: Peter Chen <peter.chen@freescale.com>

Could this series be applied, please?

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Alexander Shishkin]

Peter Chen <peter.chen@freescale.com> writes:

> On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote:
>> Nearly every SoC from Freescale has this non-core usb registers. This series
>> adds support for more users of this driver.
>> 
>> This series is based on Peter Chen's work. Its needed to merge his master branch
>> before applying this series:
>> 
>> https://github.com/hzpeterchen/linux-usb.git
>
> I have tested it at i.mx6q sabrelite board, it works good.
>
> I have pushed your commit to my git, please cc me
> your coming chipidea patches, thanks.
>
> Alex, please add:
>
> Reviewed-by: Peter Chen <peter.chen@freescale.com>
> Tested-by: Peter Chen <peter.chen@freescale.com>

Looks good, queueing this one for submission.

Regards,
--
Alex

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Michael Grzeschik]

Hey Alex,

On Thu, Jan 24, 2013 at 11:42:53AM +0200, Alexander Shishkin wrote:
> Peter Chen <peter.chen@freescale.com> writes:
> 
> > On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote:
> >> Nearly every SoC from Freescale has this non-core usb registers. This series
> >> adds support for more users of this driver.
> >> 
> >> This series is based on Peter Chen's work. Its needed to merge his master branch
> >> before applying this series:
> >> 
> >> https://github.com/hzpeterchen/linux-usb.git
> >
> > I have tested it at i.mx6q sabrelite board, it works good.
> >
> > I have pushed your commit to my git, please cc me
> > your coming chipidea patches, thanks.
> >
> > Alex, please add:
> >
> > Reviewed-by: Peter Chen <peter.chen@freescale.com>
> > Tested-by: Peter Chen <peter.chen@freescale.com>
> 
> Looks good, queueing this one for submission.

Now that you have your git-tree [1], could you queue that for
submission?

[1] git://github.com/virtuoso/linux-ci.git ci-for-greg

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Michael Grzeschik]

On Thu, Mar 07, 2013 at 11:54:03PM +0100, Michael Grzeschik wrote:
> Hey Alex,
> 
> On Thu, Jan 24, 2013 at 11:42:53AM +0200, Alexander Shishkin wrote:
> > Peter Chen <peter.chen@freescale.com> writes:
> > 
> > > On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote:
> > >> Nearly every SoC from Freescale has this non-core usb registers. This series
> > >> adds support for more users of this driver.
> > >> 
> > >> This series is based on Peter Chen's work. Its needed to merge his master branch
> > >> before applying this series:
> > >> 
> > >> https://github.com/hzpeterchen/linux-usb.git
> > >
> > > I have tested it at i.mx6q sabrelite board, it works good.
> > >
> > > I have pushed your commit to my git, please cc me
> > > your coming chipidea patches, thanks.
> > >
> > > Alex, please add:
> > >
> > > Reviewed-by: Peter Chen <peter.chen@freescale.com>
> > > Tested-by: Peter Chen <peter.chen@freescale.com>
> > 
> > Looks good, queueing this one for submission.
> 
> Now that you have your git-tree [1], could you queue that for
> submission?
> 
> [1] git://github.com/virtuoso/linux-ci.git ci-for-greg

Ping!

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Michael Grzeschik]

On Thu, Mar 07, 2013 at 11:54:03PM +0100, Michael Grzeschik wrote:
> Hey Alex,
> 
> On Thu, Jan 24, 2013 at 11:42:53AM +0200, Alexander Shishkin wrote:
> > Peter Chen <peter.chen@freescale.com> writes:
> > 
> > > On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote:
> > >> Nearly every SoC from Freescale has this non-core usb registers. This series
> > >> adds support for more users of this driver.
> > >> 
> > >> This series is based on Peter Chen's work. Its needed to merge his master branch
> > >> before applying this series:
> > >> 
> > >> https://github.com/hzpeterchen/linux-usb.git
> > >
> > > I have tested it at i.mx6q sabrelite board, it works good.
> > >
> > > I have pushed your commit to my git, please cc me
> > > your coming chipidea patches, thanks.
> > >
> > > Alex, please add:
> > >
> > > Reviewed-by: Peter Chen <peter.chen@freescale.com>
> > > Tested-by: Peter Chen <peter.chen@freescale.com>
> > 
> > Looks good, queueing this one for submission.
> 
> Now that you have your git-tree [1], could you queue that for
> submission?
> 
> [1] git://github.com/virtuoso/linux-ci.git ci-for-greg

PING!

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Fabio Estevam]

Hi Alexander,

On Thu, Jan 24, 2013 at 7:42 AM, Alexander Shishkin
<alexander.shishkin@linux.intel.com> wrote:
> Peter Chen <peter.chen@freescale.com> writes:
>
>> On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote:
>>> Nearly every SoC from Freescale has this non-core usb registers. This series
>>> adds support for more users of this driver.
>>>
>>> This series is based on Peter Chen's work. Its needed to merge his master branch
>>> before applying this series:
>>>
>>> https://github.com/hzpeterchen/linux-usb.git
>>
>> I have tested it at i.mx6q sabrelite board, it works good.
>>
>> I have pushed your commit to my git, please cc me
>> your coming chipidea patches, thanks.
>>
>> Alex, please add:
>>
>> Reviewed-by: Peter Chen <peter.chen@freescale.com>
>> Tested-by: Peter Chen <peter.chen@freescale.com>
>
> Looks good, queueing this one for submission.

Could you please let us know what is preventing this series to be applied?

Thanks,

Fabio Estevam

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Michael Grzeschik]

Hi Alexander, Fabio, Greg,

On Mon, Mar 25, 2013 at 10:11:15AM -0300, Fabio Estevam wrote:
> Hi Alexander,
> 
> On Thu, Jan 24, 2013 at 7:42 AM, Alexander Shishkin
> <alexander.shishkin@linux.intel.com> wrote:
> > Peter Chen <peter.chen@freescale.com> writes:
> >
> >> On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote:
> >>> Nearly every SoC from Freescale has this non-core usb registers. This series
> >>> adds support for more users of this driver.
> >>>
> >>> This series is based on Peter Chen's work. Its needed to merge his master branch
> >>> before applying this series:
> >>>
> >>> https://github.com/hzpeterchen/linux-usb.git
> >>
> >> I have tested it at i.mx6q sabrelite board, it works good.
> >>
> >> I have pushed your commit to my git, please cc me
> >> your coming chipidea patches, thanks.
> >>
> >> Alex, please add:
> >>
> >> Reviewed-by: Peter Chen <peter.chen@freescale.com>
> >> Tested-by: Peter Chen <peter.chen@freescale.com>
> >
> > Looks good, queueing this one for submission.
> 
> Could you please let us know what is preventing this series to be applied?

That's what our chipidea usb disaster currently looks like in detail:

http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/usb-phy
4414a59 Merge 'v3.9/topic/usb-phy' into usb-3.9
a806027 usb: otg: mxs-phy: remove clkgate/sftrst clearing
026881b usb: otg: mxs-phy: Improve mxs phy initialization
ed42fa9 usb: mxs-phy: register phy at usb phy library
d2783aa usb: phy: remove NULL pointer check in usb_add_phy()

/*
 * The series usb-ci-udc has already been posted some times
 * but it currently got no replies by Alexander.
 */
http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/usb-ci-udc
e548c9d Merge 'v3.9/topic/usb-ci-udc' into usb-3.9
80538f3 usb: chipidea: udc: add multiple td support to hardware_{en,de}queue
02e1c7b usb: chipidea: udc: manage dynamic amount of tds with an linked list
0ebb8f4 usb: chipidea: udc: prepare qhead with dma_alloc_coherent
39be042 usb: chipidea: udc: add the define TD_PAGE_COUNT and fix all users
c2f0562 usb: chipidea: udc: use gfp_flags in _hardware_enqueue
f818222 usb: chipidea: udc: move _ep_queue into an unlocked function
8aea3b0 usb: chipidea: udc: configure iso endpoints
8e61a12 usb: chipidea: udc: rework ep_enable cap setting
e5ceed7 usb: chipidea: udc: move ZLT flag change to ep_enable
2e33742 usb: chipidea: udc: read status of td only once in hardware_dequeue
516803b usb: chipidea: udc: only clear active and halted bits in qhead
ee95a49 usb: chipidea: udc: use {read,write}l to handle mapped data

http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/imx-usbmisc
1174002 Merge 'v3.9/topic/imx-usbmisc' into usb-3.9
f406383 usb: chipidea: usbmisc: skip clocks on i.MX6
d5c8d53 usb: chipidea: usbmisc: use module_platform_driver
105d5d0 usb: chipidea: usbmisc: add support for ahb, ipg and per clock

http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/imx-usb
df11f8b Merge 'v3.9/topic/imx-usb' into usb-3.9
9a967c4 usb: chipidea: udc: add force-full-speed option
a02af86 USB: chipidea: set STS bit in serial mode
af34326 usb: chipidea: ci13xxx_imx: add 2nd and 3rd clock to support imx5x and newer
5b7f6d8 usb: chipidea: pci: mark platformdata as static

/*
 * All above branches depent on the lower branches of Alexander and Peter
 * which we currently have rebased on v3.9-rc3 and on top of each other.
 * It is named alex-and-peter-for-3.9.
 */
http://git.pengutronix.de/git/mgr/linux.git alex-and-peter-for-3.9

/*
 * Peters branch already contain the usbmisc series,
 * but they never made it to ci-for-greg, although
 * Alexander already mentioned (24 Jan 2013) to queue them.
 */
https://github.com/hzpeterchen/linux-usb.git master^^
4d36511 Merge 'v3.9/topic/usb-peterchen'
90314f3 usb: chipidea: usbmisc: add post handling and errata fix for mx25
edde2ad usb: chipidea: usbmisc: add mx53 support
6150722 usb: chipidea: usbmisc: prepare driver to handle more than one soc
542384e usb: chipidea: usbmisc: fix a potential race condition
cdffb44 usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove
b8e47e3 usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx
c5863f9 usb: chipidea: imx: select usb id pin using syscon interface
8c8a1f5 usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget
c703723 usb: chipidea: imx: add getting vbus regulator code
e897d66 usb: chipidea: delete the delayed work
4c0be3e usb: chipidea: add vbus regulator control
f1e52f8 usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS
af4e743 usb: chipidea: udc: add pullup/pulldown dp at hw_device_state
1be0011 usb: chipidea: add otg id switch and vbus connect/disconnect detect
7c3c62d usb: chipidea: add otg file
618bfec Revert "USB: chipidea: add vbus detect for udc"
bfe5248 USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy
705620f USB mxs-phy: Register phy with framework
f5e9796 USB chipidea i.MX: introduce dr_mode property
dc622c4 USB chipidea: introduce dual role mode pdata flags
b1d4a9e USB: chipidea: add PTW and PTS handling
747eee3 USB: chipidea: ci13xxx-imx: create dynamic platformdata
2f2bb89 USB: add devicetree helpers for determining dr_mode and phy_type
4f30039 USB: move bulk of otg/otg.c to phy/phy.c
760d9a8 nop-xceiv: make nop to use usb_add_phy_dev

/*
 * This branch is already one month old and stays untouched
 * /
https://github.com/hzpeterchen/linux-ci.git ci-for-greg
e0fe4d5 Merge 'ci-for-greg'
e160513 usb: chipidea: don't redefine __ffs()
93b27aa usb: chipidea: fix precedence bug in ci_requests_show()
67d0531 usb: chipidea: move debug files creation/removal to the core
5a958dd usb: chipidea: move role to debugfs
038429c usb: chipidea: convert debug entries in sysfs to debugfs
25dc0fb usb: chipidea: replace interrupt accounting with tracepoints
dc43e8c usb: chipidea: convert events to tracepoints
a84a5bf usb: chipidea: trim include list in the core
f2bf55e usb: chipidea: trim include list in udc code
adf1889 usb: chipidea: drop redundant includes

Thanks,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Greg KH]

On Mon, Mar 25, 2013 at 05:29:31PM +0100, Michael Grzeschik wrote:
> Hi Alexander, Fabio, Greg,
> 
> On Mon, Mar 25, 2013 at 10:11:15AM -0300, Fabio Estevam wrote:
> > Hi Alexander,
> > 
> > On Thu, Jan 24, 2013 at 7:42 AM, Alexander Shishkin
> > <alexander.shishkin@linux.intel.com> wrote:
> > > Peter Chen <peter.chen@freescale.com> writes:
> > >
> > >> On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote:
> > >>> Nearly every SoC from Freescale has this non-core usb registers. This series
> > >>> adds support for more users of this driver.
> > >>>
> > >>> This series is based on Peter Chen's work. Its needed to merge his master branch
> > >>> before applying this series:
> > >>>
> > >>> https://github.com/hzpeterchen/linux-usb.git
> > >>
> > >> I have tested it at i.mx6q sabrelite board, it works good.
> > >>
> > >> I have pushed your commit to my git, please cc me
> > >> your coming chipidea patches, thanks.
> > >>
> > >> Alex, please add:
> > >>
> > >> Reviewed-by: Peter Chen <peter.chen@freescale.com>
> > >> Tested-by: Peter Chen <peter.chen@freescale.com>
> > >
> > > Looks good, queueing this one for submission.
> > 
> > Could you please let us know what is preventing this series to be applied?
> 
> That's what our chipidea usb disaster currently looks like in detail:
> 
> http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/usb-phy
> 4414a59 Merge 'v3.9/topic/usb-phy' into usb-3.9
> a806027 usb: otg: mxs-phy: remove clkgate/sftrst clearing
> 026881b usb: otg: mxs-phy: Improve mxs phy initialization
> ed42fa9 usb: mxs-phy: register phy at usb phy library
> d2783aa usb: phy: remove NULL pointer check in usb_add_phy()
> 
> /*
>  * The series usb-ci-udc has already been posted some times
>  * but it currently got no replies by Alexander.
>  */
> http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/usb-ci-udc
> e548c9d Merge 'v3.9/topic/usb-ci-udc' into usb-3.9
> 80538f3 usb: chipidea: udc: add multiple td support to hardware_{en,de}queue
> 02e1c7b usb: chipidea: udc: manage dynamic amount of tds with an linked list
> 0ebb8f4 usb: chipidea: udc: prepare qhead with dma_alloc_coherent
> 39be042 usb: chipidea: udc: add the define TD_PAGE_COUNT and fix all users
> c2f0562 usb: chipidea: udc: use gfp_flags in _hardware_enqueue
> f818222 usb: chipidea: udc: move _ep_queue into an unlocked function
> 8aea3b0 usb: chipidea: udc: configure iso endpoints
> 8e61a12 usb: chipidea: udc: rework ep_enable cap setting
> e5ceed7 usb: chipidea: udc: move ZLT flag change to ep_enable
> 2e33742 usb: chipidea: udc: read status of td only once in hardware_dequeue
> 516803b usb: chipidea: udc: only clear active and halted bits in qhead
> ee95a49 usb: chipidea: udc: use {read,write}l to handle mapped data
> 
> http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/imx-usbmisc
> 1174002 Merge 'v3.9/topic/imx-usbmisc' into usb-3.9
> f406383 usb: chipidea: usbmisc: skip clocks on i.MX6
> d5c8d53 usb: chipidea: usbmisc: use module_platform_driver
> 105d5d0 usb: chipidea: usbmisc: add support for ahb, ipg and per clock
> 
> http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/imx-usb
> df11f8b Merge 'v3.9/topic/imx-usb' into usb-3.9
> 9a967c4 usb: chipidea: udc: add force-full-speed option
> a02af86 USB: chipidea: set STS bit in serial mode
> af34326 usb: chipidea: ci13xxx_imx: add 2nd and 3rd clock to support imx5x and newer
> 5b7f6d8 usb: chipidea: pci: mark platformdata as static
> 
> /*
>  * All above branches depent on the lower branches of Alexander and Peter
>  * which we currently have rebased on v3.9-rc3 and on top of each other.
>  * It is named alex-and-peter-for-3.9.
>  */
> http://git.pengutronix.de/git/mgr/linux.git alex-and-peter-for-3.9
> 
> /*
>  * Peters branch already contain the usbmisc series,
>  * but they never made it to ci-for-greg, although
>  * Alexander already mentioned (24 Jan 2013) to queue them.
>  */
> https://github.com/hzpeterchen/linux-usb.git master^^
> 4d36511 Merge 'v3.9/topic/usb-peterchen'
> 90314f3 usb: chipidea: usbmisc: add post handling and errata fix for mx25
> edde2ad usb: chipidea: usbmisc: add mx53 support
> 6150722 usb: chipidea: usbmisc: prepare driver to handle more than one soc
> 542384e usb: chipidea: usbmisc: fix a potential race condition
> cdffb44 usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove
> b8e47e3 usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx
> c5863f9 usb: chipidea: imx: select usb id pin using syscon interface
> 8c8a1f5 usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget
> c703723 usb: chipidea: imx: add getting vbus regulator code
> e897d66 usb: chipidea: delete the delayed work
> 4c0be3e usb: chipidea: add vbus regulator control
> f1e52f8 usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS
> af4e743 usb: chipidea: udc: add pullup/pulldown dp at hw_device_state
> 1be0011 usb: chipidea: add otg id switch and vbus connect/disconnect detect
> 7c3c62d usb: chipidea: add otg file
> 618bfec Revert "USB: chipidea: add vbus detect for udc"
> bfe5248 USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy
> 705620f USB mxs-phy: Register phy with framework
> f5e9796 USB chipidea i.MX: introduce dr_mode property
> dc622c4 USB chipidea: introduce dual role mode pdata flags
> b1d4a9e USB: chipidea: add PTW and PTS handling
> 747eee3 USB: chipidea: ci13xxx-imx: create dynamic platformdata
> 2f2bb89 USB: add devicetree helpers for determining dr_mode and phy_type
> 4f30039 USB: move bulk of otg/otg.c to phy/phy.c
> 760d9a8 nop-xceiv: make nop to use usb_add_phy_dev
> 
> /*
>  * This branch is already one month old and stays untouched
>  * /
> https://github.com/hzpeterchen/linux-ci.git ci-for-greg
> e0fe4d5 Merge 'ci-for-greg'
> e160513 usb: chipidea: don't redefine __ffs()
> 93b27aa usb: chipidea: fix precedence bug in ci_requests_show()
> 67d0531 usb: chipidea: move debug files creation/removal to the core
> 5a958dd usb: chipidea: move role to debugfs
> 038429c usb: chipidea: convert debug entries in sysfs to debugfs
> 25dc0fb usb: chipidea: replace interrupt accounting with tracepoints
> dc43e8c usb: chipidea: convert events to tracepoints
> a84a5bf usb: chipidea: trim include list in the core
> f2bf55e usb: chipidea: trim include list in udc code
> adf1889 usb: chipidea: drop redundant includes

Ugh, this is getting to be a horrible mess.

Alexander, what is going on here?  You can't just constantly ignore
patches, that's reserved for kernel developers with more experience :)

If I don't hear back from you by Wednesday this week, with a specific
plan for how to get all of these fixes to me by the end of this week,
I'm going to assume that you are missing, and will just start taking
chipidea patches directly myself, sorry.

greg k-h

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Alexander Shishkin]

Michael Grzeschik <mgr@pengutronix.de> writes:

> Hi Alexander, Fabio, Greg,
>
> On Mon, Mar 25, 2013 at 10:11:15AM -0300, Fabio Estevam wrote:
>> Hi Alexander,
>> 
>> On Thu, Jan 24, 2013 at 7:42 AM, Alexander Shishkin
>> <alexander.shishkin@linux.intel.com> wrote:
>> > Peter Chen <peter.chen@freescale.com> writes:
>> >
>> >> On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote:
>> >>> Nearly every SoC from Freescale has this non-core usb registers. This series
>> >>> adds support for more users of this driver.
>> >>>
>> >>> This series is based on Peter Chen's work. Its needed to merge his master branch
>> >>> before applying this series:
>> >>>
>> >>> https://github.com/hzpeterchen/linux-usb.git
>> >>
>> >> I have tested it at i.mx6q sabrelite board, it works good.
>> >>
>> >> I have pushed your commit to my git, please cc me
>> >> your coming chipidea patches, thanks.
>> >>
>> >> Alex, please add:
>> >>
>> >> Reviewed-by: Peter Chen <peter.chen@freescale.com>
>> >> Tested-by: Peter Chen <peter.chen@freescale.com>
>> >
>> > Looks good, queueing this one for submission.
>> 
>> Could you please let us know what is preventing this series to be
>> applied?

I think the main problem is that there is a bunch of patchsets with
interdependencies that are quite obscure at least to me. Also, I see a
whole lot of patches that were posted some time ago, commented on, never
reposted.
Right now, I'm looking at one patchset which you have sent last
friday. So far it looks like a good candidate, although I see a few
comments there that suggest that it still needs fixing.

> That's what our chipidea usb disaster currently looks like in detail:
>

this patchset

> http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/usb-phy
> 4414a59 Merge 'v3.9/topic/usb-phy' into usb-3.9
> a806027 usb: otg: mxs-phy: remove clkgate/sftrst clearing
> 026881b usb: otg: mxs-phy: Improve mxs phy initialization
> ed42fa9 usb: mxs-phy: register phy at usb phy library
> d2783aa usb: phy: remove NULL pointer check in usb_add_phy()

looks like Felipe's call, doesn't it? I also can't seem to find these in
my inbox. If you want me to ack them, you should at least send them to
me. :)

Felipe, btw, is also often not copied on chipidea-related phy patches
that I see. And just in case, Cc'ing him on this thread.

> /*
>  * The series usb-ci-udc has already been posted some times
>  * but it currently got no replies by Alexander.
>  */
> http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/usb-ci-udc
> e548c9d Merge 'v3.9/topic/usb-ci-udc' into usb-3.9
> 80538f3 usb: chipidea: udc: add multiple td support to hardware_{en,de}queue
> 02e1c7b usb: chipidea: udc: manage dynamic amount of tds with an linked list
> 0ebb8f4 usb: chipidea: udc: prepare qhead with dma_alloc_coherent
> 39be042 usb: chipidea: udc: add the define TD_PAGE_COUNT and fix all users
> c2f0562 usb: chipidea: udc: use gfp_flags in _hardware_enqueue
> f818222 usb: chipidea: udc: move _ep_queue into an unlocked function
> 8aea3b0 usb: chipidea: udc: configure iso endpoints
> 8e61a12 usb: chipidea: udc: rework ep_enable cap setting
> e5ceed7 usb: chipidea: udc: move ZLT flag change to ep_enable
> 2e33742 usb: chipidea: udc: read status of td only once in hardware_dequeue
> 516803b usb: chipidea: udc: only clear active and halted bits in qhead
> ee95a49 usb: chipidea: udc: use {read,write}l to handle mapped data

Yes, that's the one. You were in discussion with Peter about some of
these patches, so I haven't had a close look before.

> http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/imx-usbmisc
> 1174002 Merge 'v3.9/topic/imx-usbmisc' into usb-3.9
> f406383 usb: chipidea: usbmisc: skip clocks on i.MX6
> d5c8d53 usb: chipidea: usbmisc: use module_platform_driver

These two do not exist in my inbox.

> 105d5d0 usb: chipidea: usbmisc: add support for ahb, ipg and per clock

This one is ok, but it was posted in a patchset, which claims to depend
on Peter's vbus detection patchset, which is still a work in progress.

> http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/imx-usb
> df11f8b Merge 'v3.9/topic/imx-usb' into usb-3.9
> 9a967c4 usb: chipidea: udc: add force-full-speed option

The only version that I have of this patch in my inbox has a problem
wrt DEVLC vs PORTSC in lpm/nolpm devices. I have seen you fix this
problem for the phy mode configuration patch, but not for this one.

> a02af86 USB: chipidea: set STS bit in serial mode

Doesn't exist in my inbox.

> af34326 usb: chipidea: ci13xxx_imx: add 2nd and 3rd clock to support
> imx5x and newer

This patch started a discussion which didn't end in a revised version of
the patch in my inbox.

> 5b7f6d8 usb: chipidea: pci: mark platformdata as static

That obviously should go in. It is not applied because it was posted as
a part of the patchset that required fixing.

>
> /*
>  * All above branches depent on the lower branches of Alexander and Peter
>  * which we currently have rebased on v3.9-rc3 and on top of each other.
>  * It is named alex-and-peter-for-3.9.
>  */
> http://git.pengutronix.de/git/mgr/linux.git alex-and-peter-for-3.9
>
> /*
>  * Peters branch already contain the usbmisc series,
>  * but they never made it to ci-for-greg, although
>  * Alexander already mentioned (24 Jan 2013) to queue them.
>  */
> https://github.com/hzpeterchen/linux-usb.git master^^
> 4d36511 Merge 'v3.9/topic/usb-peterchen'
> 90314f3 usb: chipidea: usbmisc: add post handling and errata fix for mx25
> edde2ad usb: chipidea: usbmisc: add mx53 support
> 6150722 usb: chipidea: usbmisc: prepare driver to handle more than one soc
> 542384e usb: chipidea: usbmisc: fix a potential race condition
> cdffb44 usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove
> b8e47e3 usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx
> c5863f9 usb: chipidea: imx: select usb id pin using syscon interface
> 8c8a1f5 usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget
> c703723 usb: chipidea: imx: add getting vbus regulator code
> e897d66 usb: chipidea: delete the delayed work
> 4c0be3e usb: chipidea: add vbus regulator control
> f1e52f8 usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS
> af4e743 usb: chipidea: udc: add pullup/pulldown dp at hw_device_state
> 1be0011 usb: chipidea: add otg id switch and vbus connect/disconnect detect
> 7c3c62d usb: chipidea: add otg file

This patchset is a work in progress, it can't be applied anywhere yet.

> 618bfec Revert "USB: chipidea: add vbus detect for udc"

This one, though, I will pick.

> bfe5248 USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy
> 705620f USB mxs-phy: Register phy with framework
> f5e9796 USB chipidea i.MX: introduce dr_mode property
> dc622c4 USB chipidea: introduce dual role mode pdata flags
> b1d4a9e USB: chipidea: add PTW and PTS handling
> 747eee3 USB: chipidea: ci13xxx-imx: create dynamic platformdata

> 2f2bb89 USB: add devicetree helpers for determining dr_mode and
> phy_type

This guy was commented on and didn't show up in my inbox after that.

> 4f30039 USB: move bulk of otg/otg.c to phy/phy.c

this one seems to be in Felipe's testing branch

> 760d9a8 nop-xceiv: make nop to use usb_add_phy_dev

doesn't exist in my inbox and looks like Felipe's call.

>
> /*
>  * This branch is already one month old and stays untouched
>  * /
> https://github.com/hzpeterchen/linux-ci.git ci-for-greg
> e0fe4d5 Merge 'ci-for-greg'
> e160513 usb: chipidea: don't redefine __ffs()
> 93b27aa usb: chipidea: fix precedence bug in ci_requests_show()
> 67d0531 usb: chipidea: move debug files creation/removal to the core
> 5a958dd usb: chipidea: move role to debugfs
> 038429c usb: chipidea: convert debug entries in sysfs to debugfs
> 25dc0fb usb: chipidea: replace interrupt accounting with tracepoints
> dc43e8c usb: chipidea: convert events to tracepoints
> a84a5bf usb: chipidea: trim include list in the core
> f2bf55e usb: chipidea: trim include list in udc code
> adf1889 usb: chipidea: drop redundant includes

Yes, I am still waiting for the patches that can be actually
applied. There is one fix from Felipe and a few that I mentioned above
and probably also one or two from Svetoslav.

So, if you feel like including any of the above patches in this round,
please add them on top of the patchset that you're currently resending
or at least point me at the fixed versions (that could be, for example,
the force fullspeed patch) or the patches that can be taken out of
context of the patchsets that they were sent in.

Regards,
--
Alex

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Felipe Balbi]

Hi,

On Tue, Mar 26, 2013 at 02:08:05PM +0200, Alexander Shishkin wrote:
> > http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/usb-phy
> > 4414a59 Merge 'v3.9/topic/usb-phy' into usb-3.9
> > a806027 usb: otg: mxs-phy: remove clkgate/sftrst clearing
> > 026881b usb: otg: mxs-phy: Improve mxs phy initialization
> > ed42fa9 usb: mxs-phy: register phy at usb phy library
> > d2783aa usb: phy: remove NULL pointer check in usb_add_phy()
> 
> looks like Felipe's call, doesn't it? I also can't seem to find these in
> my inbox. If you want me to ack them, you should at least send them to
> me. :)
> 
> Felipe, btw, is also often not copied on chipidea-related phy patches
> that I see. And just in case, Cc'ing him on this thread.

if it's not in my tree yet, it needs to be rebased to my 'next' brach,
since PHY drivers have moved out of drivers/usb/otg/. Rebase and resend.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130326/95ca4e5b/attachment.sig>

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Alexander Shishkin]

Michael Grzeschik <mgr@pengutronix.de> writes:

> Hi Alexander, Fabio, Greg,
>

Some more fun:

> /*
>  * Peters branch already contain the usbmisc series,
>  * but they never made it to ci-for-greg, although
>  * Alexander already mentioned (24 Jan 2013) to queue them.
>  */
> https://github.com/hzpeterchen/linux-usb.git master^^
> 4d36511 Merge 'v3.9/topic/usb-peterchen'
> 90314f3 usb: chipidea: usbmisc: add post handling and errata fix for mx25
> edde2ad usb: chipidea: usbmisc: add mx53 support
> 6150722 usb: chipidea: usbmisc: prepare driver to handle more than one soc
> 542384e usb: chipidea: usbmisc: fix a potential race condition
> cdffb44 usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove
> b8e47e3 usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx

These patches were not part of Peter's patchset, but the one that I
acked before. Yes, these go in too.

> c5863f9 usb: chipidea: imx: select usb id pin using syscon interface

Can't see it in my mailbox.

> 8c8a1f5 usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget
> c703723 usb: chipidea: imx: add getting vbus regulator code
> e897d66 usb: chipidea: delete the delayed work
> 4c0be3e usb: chipidea: add vbus regulator control
> f1e52f8 usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS
> af4e743 usb: chipidea: udc: add pullup/pulldown dp at hw_device_state
> 1be0011 usb: chipidea: add otg id switch and vbus connect/disconnect detect
> 7c3c62d usb: chipidea: add otg file
> 618bfec Revert "USB: chipidea: add vbus detect for udc"

This is, btw, an o-o-o-old version of Peter's work.

Regards,
--
Alex

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Alexander Shishkin]

Greg KH <gregkh@linuxfoundation.org> writes:

> Ugh, this is getting to be a horrible mess.
>
> Alexander, what is going on here?  You can't just constantly ignore
> patches, that's reserved for kernel developers with more experience :)

Long story short, I'm waiting for a coherent set of patches to arrive to
my inbox (I guess that's a fair expectation) for them to be included in
what I am going to send you on friday, if that's reasonable. I'll also
post my current stack of chipidea patches later today to sync with
everybody.

This email did bring to my attention 6 patches that I could have missed
otherwise. And these are the *only* patches from the abovementioned ones
that don't have unaddressed comments or obscure dependencies on other
patchsets and/or trees.

> If I don't hear back from you by Wednesday this week, with a specific
> plan for how to get all of these fixes to me by the end of this week,
> I'm going to assume that you are missing, and will just start taking
> chipidea patches directly myself, sorry.

For a long story, see my other email [1].

[1] http://marc.info/?l=linux-arm-kernel&m=136429960606655&w=2

Regards,
--
Alex

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Michael Grzeschik]

Hi Alexander,

On Tue, Mar 26, 2013 at 02:29:40PM +0200, Alexander Shishkin wrote:
> Michael Grzeschik <mgr@pengutronix.de> writes:
> Some more fun:
> 
> > /*
> >  * Peters branch already contain the usbmisc series,
> >  * but they never made it to ci-for-greg, although
> >  * Alexander already mentioned (24 Jan 2013) to queue them.
> >  */
> > https://github.com/hzpeterchen/linux-usb.git master^^
> > 4d36511 Merge 'v3.9/topic/usb-peterchen'
> > 90314f3 usb: chipidea: usbmisc: add post handling and errata fix for mx25
> > edde2ad usb: chipidea: usbmisc: add mx53 support
> > 6150722 usb: chipidea: usbmisc: prepare driver to handle more than one soc
> > 542384e usb: chipidea: usbmisc: fix a potential race condition
> > cdffb44 usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove
> > b8e47e3 usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx
> 
> These patches were not part of Peter's patchset, but the one that I
> acked before. Yes, these go in too.

This are the patches that whole thread was basically about. I did not
want to force pressure with our ground truth of patches, but as you did
not collect the series on your extra prepared mainlining ci-for-greg
tree and did not even answer on any mail about it, I just wanted some
more eyes to pay attention.

> > c5863f9 usb: chipidea: imx: select usb id pin using syscon interface
> 
> Can't see it in my mailbox.

Obviously we did not start posting every patch we got in the queue when
we don't even see the oldest accepted patches show up where they should.

> > 8c8a1f5 usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget
> > c703723 usb: chipidea: imx: add getting vbus regulator code
> > e897d66 usb: chipidea: delete the delayed work
> > 4c0be3e usb: chipidea: add vbus regulator control
> > f1e52f8 usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS
> > af4e743 usb: chipidea: udc: add pullup/pulldown dp at hw_device_state
> > 1be0011 usb: chipidea: add otg id switch and vbus connect/disconnect detect
> > 7c3c62d usb: chipidea: add otg file
> > 618bfec Revert "USB: chipidea: add vbus detect for udc"
> 
> This is, btw, an o-o-o-old version of Peter's work.

Actually, its just the series he got in his github tree. [?]
That the patches here are way to old is due to the missing
workflow we all currently suffer from.

[?] https://github.com/hzpeterchen/linux-usb.git master

Thanks,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Alexander Shishkin]

Michael Grzeschik <mgr@pengutronix.de> writes:

> On Thu, Mar 07, 2013 at 11:54:03PM +0100, Michael Grzeschik wrote:
>> Hey Alex,
>> 
>> On Thu, Jan 24, 2013 at 11:42:53AM +0200, Alexander Shishkin wrote:
>> > Peter Chen <peter.chen@freescale.com> writes:
>> > 
>> > > On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote:
>> > >> Nearly every SoC from Freescale has this non-core usb registers. This series
>> > >> adds support for more users of this driver.
>> > >> 
>> > >> This series is based on Peter Chen's work. Its needed to merge his master branch
>> > >> before applying this series:
>> > >> 
>> > >> https://github.com/hzpeterchen/linux-usb.git
>> > >
>> > > I have tested it at i.mx6q sabrelite board, it works good.
>> > >
>> > > I have pushed your commit to my git, please cc me
>> > > your coming chipidea patches, thanks.
>> > >
>> > > Alex, please add:
>> > >
>> > > Reviewed-by: Peter Chen <peter.chen@freescale.com>
>> > > Tested-by: Peter Chen <peter.chen@freescale.com>
>> > 
>> > Looks good, queueing this one for submission.
>> 
>> Now that you have your git-tree [1], could you queue that for
>> submission?
>> 
>> [1] git://github.com/virtuoso/linux-ci.git ci-for-greg
>
> Ping!

What would have been more helpful here is a resend of these patches
rebased so that they at least apply.

So I had to fix that, fix some warnings here and there (before the
sparse police catches up with you) and otherwise had a good time.

Applied and pushed to ci-for-greg.

Thanks,
--
Alex

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Michael Grzeschik]

On Tue, Mar 26, 2013 at 02:08:05PM +0200, Alexander Shishkin wrote:
> Michael Grzeschik <mgr@pengutronix.de> writes:
> > Hi Alexander, Fabio, Greg,

[...]

> > 618bfec Revert "USB: chipidea: add vbus detect for udc"
> 
> This one, though, I will pick.

I miss that patch in your posted series.

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Alexander Shishkin]

Michael Grzeschik <mgr@pengutronix.de> writes:

> On Tue, Mar 26, 2013 at 02:08:05PM +0200, Alexander Shishkin wrote:
>> Michael Grzeschik <mgr@pengutronix.de> writes:
>> > Hi Alexander, Fabio, Greg,
>
> [...]
>
>> > 618bfec Revert "USB: chipidea: add vbus detect for udc"
>> 
>> This one, though, I will pick.
>
> I miss that patch in your posted series.

I haven't decided yet if it is better to apply a revert or to fix the
existing patch for the time being. If you have any opinions on this,
please share.

Regards,
--
Alex

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Alexander Shishkin]

Greg KH <gregkh@linuxfoundation.org> writes:

> If I don't hear back from you by Wednesday this week, with a specific
> plan for how to get all of these fixes to me by the end of this week,
> I'm going to assume that you are missing, and will just start taking
> chipidea patches directly myself, sorry.

Actually it looks like there might be more patches coming for this
round, so I'd like to send chipidea stuff to you after rc5 if that's ok
with you.

Regards,
--
Alex

[PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

[Greg KH]

On Fri, Mar 29, 2013 at 06:00:36PM +0200, Alexander Shishkin wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
> 
> > If I don't hear back from you by Wednesday this week, with a specific
> > plan for how to get all of these fixes to me by the end of this week,
> > I'm going to assume that you are missing, and will just start taking
> > chipidea patches directly myself, sorry.
> 
> Actually it looks like there might be more patches coming for this
> round, so I'd like to send chipidea stuff to you after rc5 if that's ok
> with you.

That's cutting it _really_ close.  How about sending me what you have
now, and if you have more later, send them then.  No need to postpone
some of these patches any longer than you already have :)

thanks,

greg k-h