From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: clk: imx35 sound admux_gate bugfix
Date: Wed, 27 Mar 2013 15:50:11 +0000 [thread overview]
Message-ID: <20130327155011.GY18316@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20130327150420.GB6347@pengutronix.de>
On Wed, Mar 27, 2013 at 04:04:20PM +0100, Markus Pargmann wrote:
> On Wed, Mar 27, 2013 at 12:37:00PM +0000, Mark Brown wrote:
> > This is a patch to the ASoC driver? I just ignored it since it said it
> > was an ARM patch... Anyway, what I'd expect should be happening here is
> > that the clock API walks up the tree enabling supply clocks - that would
> > mean that either that code isn't there or there's a missing parent child
> > relationship in the data.
> It changes some things in imx-ssi, sorry, perhaps I should have
> splitted it into two patches.
> admux clock does not seem to be a physical parent of the ssi clock, so
> I don't think it should be a parent in the clock tree. But imx-ssi (or
> some other evice) needs this clock to work. As mentioned in the other
> response, I will put it directly into clk-imx35.c so this won't be a
> patch for ASoC in the next version.
If it's the IP that needs the clock then I'd expect the IP to be
requesting it so changing the driver does make sense. Do we actually
know what the clock does?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130327/3ed7a7e1/attachment.sig>
next prev parent reply other threads:[~2013-03-27 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 11:22 [PATCH 0/2] ARM: imx35 clk bugfixes Markus Pargmann
2013-03-27 11:22 ` [PATCH 1/2] ARM: clk: Bugfix imx35 iomux clock Markus Pargmann
2013-03-27 11:22 ` [PATCH 2/2] ARM: clk: imx35 sound admux_gate bugfix Markus Pargmann
2013-03-27 11:57 ` Philipp Zabel
2013-03-27 12:14 ` Markus Pargmann
2013-03-27 12:37 ` Mark Brown
2013-03-27 15:04 ` Markus Pargmann
2013-03-27 15:50 ` Mark Brown [this message]
2013-03-27 16:37 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327155011.GY18316@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).