From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 27 Mar 2013 13:49:30 -0700 Subject: [PATCH 1/9] ARM: OMAP4+: Use common scratchpad SAR RAM offsets for all architectures In-Reply-To: <51535B66.60307@ti.com> References: <1361373527-21695-1-git-send-email-santosh.shilimkar@ti.com> <1361373527-21695-2-git-send-email-santosh.shilimkar@ti.com> <87mwto7ki5.fsf@linaro.org> <51535B66.60307@ti.com> Message-ID: <20130327204930.GM10155@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Santosh Shilimkar [130327 13:52]: > On Thursday 28 March 2013 12:11 AM, Kevin Hilman wrote: > > Santosh Shilimkar writes: > > > >> From: Tero Kristo > >> > >> Simplifies code and also allows the re-use as is on OMAP5 devices. > > > > nit: changelog here is rather weak. It claims "simplifies code" but > > it's not obvious from the patch how changing a few #defines does that. > > > I agree. Basically the offset are chosen such a way that they can > work on OMAP4 and OMAP5 instead of having two separate sets. > Will expand the changelog to make it clear. You might want to mention also that the offsets are only used by the kernel to save and restore registers from so people don't think those are hardare registers and that the patch might break some things. Regards, Tony