* [PATCH iv2] ARM: kirkwood: fix a compilation warning
@ 2013-03-28 16:12 Jean-Francois Moine
0 siblings, 0 replies; only message in thread
From: Jean-Francois Moine @ 2013-03-28 16:12 UTC (permalink / raw)
To: linux-arm-kernel
In the function kirkwood_set_rate, when the rate cannot be satisfied
by the internal nor by an extern clock, the clock source could be set
to an undefined value.
As the ALSA subsystem should never gives such a rate, this patch removes
the check of the external clock pointer.
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
v2
- this patch replaces the previous
[PATCH 1/2] ARM: kirkwood: fix a not initialized variable in the sound subsystem
- no error message and don't check the external clock pointer (from Russell King)
---
sound/soc/kirkwood/kirkwood-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c
index c74c890..9ca1321 100644
--- a/sound/soc/kirkwood/kirkwood-i2s.c
+++ b/sound/soc/kirkwood/kirkwood-i2s.c
@@ -111,7 +111,7 @@ static void kirkwood_set_rate(struct snd_soc_dai *dai,
kirkwood_set_dco(priv->io, rate);
clks_ctrl = KIRKWOOD_MCLK_SOURCE_DCO;
- } else if (!IS_ERR(priv->extclk)) {
+ } else {
/* use optional external clk for other rates */
dev_dbg(dai->dev, "%s: extclk set rate = %lu -> %lu\n",
__func__, rate, 256 * rate);
--
1.7.10.4
--
Ken ar c'henta? | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-03-28 16:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-28 16:12 [PATCH iv2] ARM: kirkwood: fix a compilation warning Jean-Francois Moine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).