linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: mvebu: Add GPIO LEDs to Mirabox board
@ 2013-03-29  2:10 Ryan Press
  2013-03-29  7:24 ` Neil Greatorex
  2013-03-31  0:24 ` Jason Cooper
  0 siblings, 2 replies; 4+ messages in thread
From: Ryan Press @ 2013-03-29  2:10 UTC (permalink / raw)
  To: linux-arm-kernel

Add the three external LED definitions to the device tree file on
the Mirabox.

The Mirabox user guide calls out one as a power LED, and the other
two are defined for WiFi, but as the current mwifiex drivers don't
have LED support, we make them status LEDs.

These have been tested working by writing to the appropriate
/sys/class/leds trigger.

Signed-off-by: Ryan Press <ryan@presslab.us>
---
 arch/arm/boot/dts/armada-370-mirabox.dts | 37 ++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/arch/arm/boot/dts/armada-370-mirabox.dts b/arch/arm/boot/dts/armada-370-mirabox.dts
index dd0c57d..242796e 100644
--- a/arch/arm/boot/dts/armada-370-mirabox.dts
+++ b/arch/arm/boot/dts/armada-370-mirabox.dts
@@ -33,6 +33,43 @@
 			clock-frequency = <600000000>;
 			status = "okay";
 		};
+
+		pinctrl {
+			pwr_led_pin: pwr-led-pin {
+				marvell,pins = "mpp63";
+				marvell,function = "gpo";
+			};
+
+			stat_led_pins: stat-led-pins {
+				marvell,pins = "mpp64", "mpp65";
+				marvell,function = "gpio";
+			};
+		};
+
+		gpio_leds {
+			compatible = "gpio-leds";
+			pinctrl-names = "default";
+			pinctrl-0 = <&pwr_led_pin &stat_led_pins>;
+
+			green_pwr_led {
+				label = "mirabox:green:pwr";
+				gpios = <&gpio1 31 1>;
+				linux,default-trigger = "heartbeat";
+			};
+
+			blue_stat_led {
+				label = "mirabox:blue:stat";
+				gpios = <&gpio2 0 1>;
+				linux,default-trigger = "cpu0";
+			};
+
+			green_stat_led {
+				label = "mirabox:green:stat";
+				gpios = <&gpio2 1 1>;
+				default-state = "off";
+			};
+		};
+
 		mdio {
 			phy0: ethernet-phy at 0 {
 				reg = <0>;
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] arm: mvebu: Add GPIO LEDs to Mirabox board
  2013-03-29  2:10 [PATCH] arm: mvebu: Add GPIO LEDs to Mirabox board Ryan Press
@ 2013-03-29  7:24 ` Neil Greatorex
  2013-03-29 18:13   ` Ezequiel Garcia
  2013-03-31  0:24 ` Jason Cooper
  1 sibling, 1 reply; 4+ messages in thread
From: Neil Greatorex @ 2013-03-29  7:24 UTC (permalink / raw)
  To: linux-arm-kernel


On Thu, 28 Mar 2013, Ryan Press wrote:

> Add the three external LED definitions to the device tree file on
> the Mirabox.
>
> The Mirabox user guide calls out one as a power LED, and the other
> two are defined for WiFi, but as the current mwifiex drivers don't
> have LED support, we make them status LEDs.
>
> These have been tested working by writing to the appropriate
> /sys/class/leds trigger.
>
> Signed-off-by: Ryan Press <ryan@presslab.us>
> ---
> arch/arm/boot/dts/armada-370-mirabox.dts | 37 ++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)

Tested-by: Neil Greatorex <neil@fatboyfat.co.uk>

Cheers,
Neil

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] arm: mvebu: Add GPIO LEDs to Mirabox board
  2013-03-29  7:24 ` Neil Greatorex
@ 2013-03-29 18:13   ` Ezequiel Garcia
  0 siblings, 0 replies; 4+ messages in thread
From: Ezequiel Garcia @ 2013-03-29 18:13 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Mar 29, 2013 at 07:24:04AM +0000, Neil Greatorex wrote:
> 
> On Thu, 28 Mar 2013, Ryan Press wrote:
> 
> > Add the three external LED definitions to the device tree file on
> > the Mirabox.
> >
> > The Mirabox user guide calls out one as a power LED, and the other
> > two are defined for WiFi, but as the current mwifiex drivers don't
> > have LED support, we make them status LEDs.
> >
> > These have been tested working by writing to the appropriate
> > /sys/class/leds trigger.
> >
> > Signed-off-by: Ryan Press <ryan@presslab.us>
> > ---
> > arch/arm/boot/dts/armada-370-mirabox.dts | 37 ++++++++++++++++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> 
> Tested-by: Neil Greatorex <neil@fatboyfat.co.uk>
> 

Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] arm: mvebu: Add GPIO LEDs to Mirabox board
  2013-03-29  2:10 [PATCH] arm: mvebu: Add GPIO LEDs to Mirabox board Ryan Press
  2013-03-29  7:24 ` Neil Greatorex
@ 2013-03-31  0:24 ` Jason Cooper
  1 sibling, 0 replies; 4+ messages in thread
From: Jason Cooper @ 2013-03-31  0:24 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Mar 28, 2013 at 07:10:24PM -0700, Ryan Press wrote:
> Add the three external LED definitions to the device tree file on
> the Mirabox.
> 
> The Mirabox user guide calls out one as a power LED, and the other
> two are defined for WiFi, but as the current mwifiex drivers don't
> have LED support, we make them status LEDs.
> 
> These have been tested working by writing to the appropriate
> /sys/class/leds trigger.
> 
> Signed-off-by: Ryan Press <ryan@presslab.us>
> ---
>  arch/arm/boot/dts/armada-370-mirabox.dts | 37 ++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)

Applied to mvebu/dt

thx,

Jason.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-03-31  0:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-29  2:10 [PATCH] arm: mvebu: Add GPIO LEDs to Mirabox board Ryan Press
2013-03-29  7:24 ` Neil Greatorex
2013-03-29 18:13   ` Ezequiel Garcia
2013-03-31  0:24 ` Jason Cooper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).