From: jason@lakedaemon.net (Jason Cooper)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] Fix GE0/GE1 init on ix2-200 as GE0 has no PHY
Date: Sun, 31 Mar 2013 17:23:35 -0400 [thread overview]
Message-ID: <20130331212335.GM13280@titan.lakedaemon.net> (raw)
In-Reply-To: <1364703204-14982-3-git-send-email-nigel@nobiscuit.com>
Nigel,
On Sun, Mar 31, 2013 at 03:13:24PM +1100, Nigel Roberts wrote:
Please include a description here about the problem and how this fixed
it.
Also, please Cc: Alan Butler alanbutty12 at gmail.com, he's the original
author of the support for this board. I'd like to know why it
(hopefully) worked for him, but doesn't work for you.
> ---
> arch/arm/mach-kirkwood/board-iomega_ix2_200.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-kirkwood/board-iomega_ix2_200.c b/arch/arm/mach-kirkwood/board-iomega_ix2_200.c
> index f655b26..e5f7041 100644
> --- a/arch/arm/mach-kirkwood/board-iomega_ix2_200.c
> +++ b/arch/arm/mach-kirkwood/board-iomega_ix2_200.c
> @@ -20,10 +20,15 @@ static struct mv643xx_eth_platform_data iomega_ix2_200_ge00_data = {
> .duplex = DUPLEX_FULL,
> };
>
> +static struct mv643xx_eth_platform_data iomega_ix2_200_ge01_data = {
> + .phy_addr = MV643XX_ETH_PHY_ADDR(11),
> +};
> +
> void __init iomega_ix2_200_init(void)
> {
> /*
> * Basic setup. Needs to be called early.
> */
> - kirkwood_ge01_init(&iomega_ix2_200_ge00_data);
> + kirkwood_ge00_init(&iomega_ix2_200_ge00_data);
> + kirkwood_ge01_init(&iomega_ix2_200_ge01_data);
This looks a lot more legit, have you tried removing .speed and .duplex
from ge00? We see that a lot with boards converted from out-of-tree
legacy board files, I'm not certain those declarations are necessary.
thx,
Jason.
next prev parent reply other threads:[~2013-03-31 21:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-31 4:13 ix2-200 device tree related fixes Nigel Roberts
2013-03-31 4:13 ` [PATCH 1/2] Fix typo in the definition of rebuild LED pins for ix2-200 Nigel Roberts
2013-03-31 12:23 ` Sergei Shtylyov
2013-03-31 21:14 ` Jason Cooper
2013-03-31 4:13 ` [PATCH 2/2] Fix GE0/GE1 init on ix2-200 as GE0 has no PHY Nigel Roberts
2013-03-31 21:23 ` Jason Cooper [this message]
2013-04-01 11:39 ` Nigel Roberts
2013-04-10 16:55 ` Jason Cooper
2013-03-31 21:11 ` ix2-200 device tree related fixes Jason Cooper
2013-03-31 21:25 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130331212335.GM13280@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox