From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] clk: divider: Tolerate 0 divider for one based dividers
Date: Mon, 01 Apr 2013 11:25:22 -0700 [thread overview]
Message-ID: <20130401182522.8177.96562@quantum> (raw)
In-Reply-To: <c9f78c47-4926-4233-8cc3-51e0a4cc9c5e@AM1EHSMHS003.ehs.local>
Quoting S?ren Brinkmann (2013-03-22 11:00:15)
> Since some of our dividers have a reset value of 0, I see this warning
> during boot up. My intention here is to get rid of the warning for clocks
> which deem 0 a valid divider value.
> I thought, reusing the ONE_BASED flag might be okay, since all such
> dividers have this redundant 0 state and might handle it similar.
> Otherwise a new flag might be required.
>
Hi Soren,
A flag will be necessary. I just checked some documentation for the
divider outputs for OMAP's PLLs and (which use the common clk_divider
type) and programming zero into those dividers is not allowed. At reset
the divider registers are set to 1.
So it is unsafe to simply reuse the ONE_BASED flag.
Let's keep the current behavior as the default and introduce a new flag
to handle the special case of a zero divider. Would you like to take a
crack at it? It might also be nice to update the WARN message with a
hint to take a look at your new flag in case future platforms hit the
same issue as you.
Regards,
Mike
> S?ren
next prev parent reply other threads:[~2013-04-01 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 21:13 [PATCH RFC] clk: divider: Tolerate 0 divider for one based dividers Soren Brinkmann
2013-03-22 17:11 ` Mike Turquette
2013-03-22 18:00 ` Sören Brinkmann
2013-04-01 18:25 ` Mike Turquette [this message]
2013-04-01 18:31 ` Sören Brinkmann
2013-04-01 21:35 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401182522.8177.96562@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).