From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 16/30] ARM: shmobile: sh7372: use fixed ratio clock
Date: Tue, 2 Apr 2013 15:41:52 +0000 [thread overview]
Message-ID: <201304021541.52531.arnd@arndb.de> (raw)
In-Reply-To: <515ACC46.9020402@cogentembedded.com>
On Tuesday 02 April 2013, Sergei Shtylyov wrote:
> > @@ -83,39 +84,12 @@ struct clk sh7372_extal2_clk = {
> [...]
> > +SH_FIXED_RATIO_CLKg(sh7372_dv_clki_div2_clk, sh7372_dv_clki_clk, div2);
> > +SH_FIXED_RATIO_CLK(extal1_div2_clk, sh7372_extal1_clk, div2);
> > +SH_FIXED_RATIO_CLK(extal2_div2_clk, sh7372_extal2_clk, div2);
> > +SH_FIXED_RATIO_CLK(extal2_div4_clk, extal2_div2_clk, div2);
>
> Note that SH_FIXED_RATIO_CLK() definition already includes ; -- it
> probably should be removed from there.
Most macros that we have in the kernel like this don't include the semicolon,
which seems better since it is harder to misuse (the compiler will complain
about a missing semicolon but not always about an extranous one) and gives
a more consistent syntax overall.
It's probably not worth changing it now for the shmobile clock code, since
that is getting changed over to common clock in the future, but you may
want to remember this for future macro definitions.
Arnd
next prev parent reply other threads:[~2013-04-02 15:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 5:06 [GIT PULL] Renesas ARM SoC updates for v3.10 #2 Simon Horman
2013-04-02 5:06 ` [PATCH 01/30] ARM: shmobile: Initial r8a73a4 SoC support V3 Simon Horman
2013-04-02 5:06 ` [PATCH 02/30] ARM: shmobile: r8a73a4 SCIF " Simon Horman
2013-04-02 5:06 ` [PATCH 03/30] ARM: shmobile: r8a73a4 IRQC support V2 Simon Horman
2013-04-02 5:07 ` [PATCH 04/30] ARM: shmobile: r8a73a4 PFC support Simon Horman
2013-04-02 5:07 ` [PATCH 05/30] ARM: shmobile: sh73a0: wait for completion when kicking the clock Simon Horman
2013-04-02 5:07 ` [PATCH 06/30] ARM: shmobile: add R8A7778 basis support Simon Horman
2013-04-02 5:07 ` [PATCH 07/30] ARM: shmobile: r8a7778 SCIF support Simon Horman
2013-04-02 5:07 ` [PATCH 08/30] ARM: shmobile: sh73a0: add irqpin DT nodes Simon Horman
2013-04-02 5:07 ` [PATCH 09/30] ARM: shmobile: Disallow PINCTRL without GPIOLIB Simon Horman
2013-04-02 5:07 ` [PATCH 10/30] ARM: shmobile: r8a73a4: add thermal driver support Simon Horman
2013-04-02 5:07 ` [PATCH 11/30] ARM: shmobile: r8a7740: Migrate from INTC to GIC Simon Horman
2013-04-02 5:07 ` [PATCH 12/30] ARM: shmobile: sh73a0: add a TWD clock Simon Horman
2013-04-02 5:07 ` [PATCH 13/30] ARM: shmobile: sh73a0: remove DIV4_ZT* clocks Simon Horman
2013-04-02 5:07 ` [PATCH 14/30] ARM: shmobile: sh7372: " Simon Horman
2013-04-02 5:07 ` [PATCH 15/30] ARM: shmobile: add struct clk_ratio and fixed ratio clock macro Simon Horman
2013-04-02 5:07 ` [PATCH 16/30] ARM: shmobile: sh7372: use fixed ratio clock Simon Horman
2013-04-02 12:17 ` Sergei Shtylyov
2013-04-02 15:41 ` Arnd Bergmann [this message]
2013-04-02 5:07 ` [PATCH 17/30] ARM: shmobile: sh73a0: " Simon Horman
2013-04-02 5:07 ` [PATCH 18/30] ARM: shmobile: r8a7740: tidyup comment/implementation mismatch Simon Horman
2013-04-02 5:07 ` [PATCH 19/30] ARM: shmobile: r8a7740: use fixed ratio clock Simon Horman
2013-04-02 5:07 ` [PATCH 20/30] ARM: shmobile: r8a7779: remove DIV4 clocks and " Simon Horman
2013-04-02 5:07 ` [PATCH 21/30] ARM: shmobile: sh7372: move global functions to sh7372.h Simon Horman
2013-04-02 5:07 ` [PATCH 22/30] ARM: shmobile: sh73a0: move global functions to sh73a0.h Simon Horman
2013-04-02 5:07 ` [PATCH 23/30] ARM: shmobile: r8a7740: move global functions to r8a7740.h Simon Horman
2013-04-02 5:07 ` [PATCH 24/30] ARM: shmobile: r8a7779: move global functions to r8a7779.h Simon Horman
2013-04-02 5:07 ` [PATCH 25/30] ARM: shmobile: Initial r8a7790 SoC support Simon Horman
2013-04-02 5:07 ` [PATCH 26/30] ARM: shmobile: r8a7790 SCIF support Simon Horman
2013-04-02 5:07 ` [PATCH 27/30] ARM: shmobile: r8a7790 IRQC support Simon Horman
2013-04-02 5:07 ` [PATCH 28/30] ARM: shmobile: r8a7790 PFC support Simon Horman
2013-04-02 5:07 ` [PATCH 29/30] ARM: shmobile: r8a73a4 SoC 64-bit DT support Simon Horman
2013-04-02 5:07 ` [PATCH 30/30] ARM: shmobile: r8a7790 " Simon Horman
2013-04-02 20:25 ` [GIT PULL] Renesas ARM SoC updates for v3.10 #2 Olof Johansson
2013-04-03 0:57 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304021541.52531.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).