From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexey.pelykh@gmail.com (Alexey Pelykh) Date: Wed, 3 Apr 2013 14:31:46 -0400 Subject: [PATCH] OMAP/serial: Revert bad fix of Rx FIFO threshold granularity Message-ID: <20130403183146.GA4072@inertiallabs-linux64> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: Alexey Pelykh Partially reverts 1776fd059c40907297d6c26c51876575d63fd9e2 that introduced regression reported by Paul Walmsley. This commit restores setting granularity in SCR register and adds note about comments below being inconsistent with actual code. Signed-off-by: Alexey Pelykh Cc: Paul Walmsley Cc: Kevin Hilman Cc: Felipe Balbi Cc: linux-serial at vger.kernel.org Cc: linux-arm-kernel at lists.infradead.org Cc: linux-omap at vger.kernel.org --- Paul, please confirm that this patch solves the regression. diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 4dc4140..30d4f7a 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -886,6 +886,17 @@ serial_omap_set_termios(struct uart_port *port, struct ktermios *termios, serial_out(up, UART_MCR, up->mcr | UART_MCR_TCRTLR); /* FIFO ENABLE, DMA MODE */ + up->scr |= OMAP_UART_SCR_RX_TRIG_GRANU1_MASK; + /* + * NOTE: Setting OMAP_UART_SCR_RX_TRIG_GRANU1_MASK + * sets Enables the granularity of 1 for TRIGGER RX + * level. Along with setting RX FIFO trigger level + * to 1 (as noted below, 16 characters) and TLR[3:0] + * to zero this will result RX FIFO threshold level + * to 1 character, instead of 16 as noted in comment + * below. + */ + /* Set receive FIFO threshold to 16 characters and * transmit FIFO threshold to 16 spaces */