* [PATCH] ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting
@ 2013-04-03 9:43 Marc Zyngier
2013-04-03 23:17 ` Christoffer Dall
0 siblings, 1 reply; 2+ messages in thread
From: Marc Zyngier @ 2013-04-03 9:43 UTC (permalink / raw)
To: linux-arm-kernel
Commit 3401d54696f9 (KVM: ARM: Introduce KVM_ARM_SET_DEVICE_ADDR
ioctl) added support for the KVM_CAP_ARM_SET_DEVICE_ADDR capability,
but failed to add a break in the relevant case statement, returning
the number of CPUs instead.
Luckilly enough, the CONFIG_NR_CPUS=0 patch hasn't been merged yet
(https://lkml.org/lkml/diff/2012/3/31/131/1), so the bug wasn't
noticed.
Just give it a break!
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
arch/arm/kvm/arm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
index 6cc076e..d568e83 100644
--- a/arch/arm/kvm/arm.c
+++ b/arch/arm/kvm/arm.c
@@ -198,6 +198,7 @@ int kvm_dev_ioctl_check_extension(long ext)
break;
case KVM_CAP_ARM_SET_DEVICE_ADDR:
r = 1;
+ break;
case KVM_CAP_NR_VCPUS:
r = num_online_cpus();
break;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting
2013-04-03 9:43 [PATCH] ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting Marc Zyngier
@ 2013-04-03 23:17 ` Christoffer Dall
0 siblings, 0 replies; 2+ messages in thread
From: Christoffer Dall @ 2013-04-03 23:17 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Apr 03, 2013 at 10:43:13AM +0100, Marc Zyngier wrote:
> Commit 3401d54696f9 (KVM: ARM: Introduce KVM_ARM_SET_DEVICE_ADDR
> ioctl) added support for the KVM_CAP_ARM_SET_DEVICE_ADDR capability,
> but failed to add a break in the relevant case statement, returning
> the number of CPUs instead.
>
> Luckilly enough, the CONFIG_NR_CPUS=0 patch hasn't been merged yet
> (https://lkml.org/lkml/diff/2012/3/31/131/1), so the bug wasn't
> noticed.
>
> Just give it a break!
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> arch/arm/kvm/arm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
> index 6cc076e..d568e83 100644
> --- a/arch/arm/kvm/arm.c
> +++ b/arch/arm/kvm/arm.c
> @@ -198,6 +198,7 @@ int kvm_dev_ioctl_check_extension(long ext)
> break;
> case KVM_CAP_ARM_SET_DEVICE_ADDR:
> r = 1;
> + break;
> case KVM_CAP_NR_VCPUS:
> r = num_online_cpus();
> break;
> --
> 1.8.1.4
>
>
Whoops, nice catch. Thanks.
-Christoffer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-03 23:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-03 9:43 [PATCH] ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting Marc Zyngier
2013-04-03 23:17 ` Christoffer Dall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).